Re: [GROW] [Gen-art] Genart last call review of draft-ietf-grow-bgp-gshut-11

Alissa Cooper <alissa@cooperw.in> Wed, 13 December 2017 03:10 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB4991272E1; Tue, 12 Dec 2017 19:10:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=h3ZX+y3T; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=m+K2fkK5
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9JB6nnJEJ3d4; Tue, 12 Dec 2017 19:10:42 -0800 (PST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0812F127275; Tue, 12 Dec 2017 19:10:39 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 259DE20985; Tue, 12 Dec 2017 22:10:38 -0500 (EST)
Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Tue, 12 Dec 2017 22:10:38 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=0+QPf7okf+fvaGpvzuOwReaBHwH8c mfK+c1b5Hm2zEE=; b=h3ZX+y3T/2URI/1PHbGTi5Wb3nyd6q0j2Ko1j/VwIfQcy GmuAl4e/j5EMYYZaES/7C1+d6SiI0JMQrSm7Z/zbFuizOoq5/iCMKoHRM3OvgEmm SnKb4AZn6QGFDwcdrT63vpaLlyqohqY1I8mdnJS6nDrmBZaaoHNiK9jERLukqU3s K9OqYhqSX77JK3Wn/hHE5n6HbGLhFZfZ+V8T9pjuneJgjqvz0eD9Vcs8BqJGRDtm 7WMG2iZFWC3MN/59WhinD0HrwTwzbz3zNPRWtXObQrDfzXhe1zi9juufIQv/GwRi 8YqlXR4pW9xsEocuspVIbF1hd7o+AnqBmG6F807XQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0+QPf7 okf+fvaGpvzuOwReaBHwH8cmfK+c1b5Hm2zEE=; b=m+K2fkK5oQoBzu9wuxBd4s 2R3Zl6H0ggXNsyHNOusXzbJ8CFYIVMPhaJ0mvWZCTm3XNtnVKa4NDeZAPhAbfYrk aQ9QIUiK9t2FWr4NDCMASkwhSuh1Odokav0cJ+yFNKfhrND2V05gpRuFkf0L0jqU zJaXpZSNl3WzpbpN1cQtFkJqLk1GyijBvuLrRvHBG4EVRNnG/vP0pauotrcKjnSB KC3XXYhOHC4U3YPfFp568vATjLl7m6xv/9B4Mv7Eoi01r/MR7vr4p6xmcNKTlDaK 1TTcSknEh1nSAWioL58PQPUXBg9nzsCDjqihHJq2l77Hp0+ATFi/4rihcg2hBS4Q ==
X-ME-Sender: <xms:LpowWs1sLtveIFVbBx_UekO8PuySMt0v09CiU-Nx1MabXXyEUatwOA>
Received: from alcoop-m-mx19.fios-router.home (pool-108-48-166-97.washdc.fios.verizon.net [108.48.166.97]) by mail.messagingengine.com (Postfix) with ESMTPA id CCE8524009; Tue, 12 Dec 2017 22:10:37 -0500 (EST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <150759929173.18515.8831141207586025582@ietfa.amsl.com>
Date: Tue, 12 Dec 2017 22:10:37 -0500
Cc: gen-art <gen-art@ietf.org>, grow@ietf.org, draft-ietf-grow-bgp-gshut.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <EA9ADE0F-84D9-470F-9A0A-509D51D4EB74@cooperw.in>
References: <150759929173.18515.8831141207586025582@ietfa.amsl.com>
To: Matthew Miller <linuxwolf+ietf@outer-planes.net>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/CVnWIOqoRoDOqRzvAiL0LKQDZio>
Subject: Re: [GROW] [Gen-art] Genart last call review of draft-ietf-grow-bgp-gshut-11
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Dec 2017 03:10:44 -0000

Matt, thanks for your review. Authors/WG, thanks for addressing Matt’s issues. I have entered a No Objection ballot.

Best,
Alissa

> On Oct 9, 2017, at 9:34 PM, Matthew Miller <linuxwolf+ietf@outer-planes.net> wrote:
> 
> Reviewer: Matthew Miller
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-grow-bgp-gshut-11
> Reviewer: Matthew A. Miller
> Review Date: 2017-10-09
> IETF LC End Date: 2017-10-11
> IESG Telechat date: N/A
> 
> Summary:
> 
> This document is ready to be published as an Informational document, but
> there is one issue that I think clarification would help.
> 
> Major issues:
> 
> NONE
> 
> Minor issues:
> 
> In Section 4. "EBGP graceful shutdown procedure", it states that 0 can
> used in all cases except where the AS already has a special meaning for
> 0. It seems to me more ought to be said, but I admit I'm not well-versed
> on (I) BGP and might be seeing dragons where only windmills are present.
> 
> 
> Nits/editorial comments:
> 
> * I suggest using RFC 8174 and its terminology boiler plate to help
>  disambiguate "may" versus "MAY".
> 
> * A number of acronyms are used throughout without being spelled out (e.g.,
>  RR, IBGP, FIB, EBGP, AS), but some (e.g., ASBR) are spelled out.  I would
>  find it helpful to be consistent here, preferably by spelling them out on
>  first use.
> 
> * In Section 1. "Introduction", second paragraph, the word "operation"
>  seems to be missing from the first sentence:
> 
>  """
>  This document discusses operational procedures to be applied in order
>  to reduce or eliminate loss of packets during a maintenance.
>  """
> 
> * Throughout the Appendices, there are some inconsistent uses of some terms,
>  especially when compared to the rest of the document:
> 
>  - "Local-Pref" versus "LOCAL_PREF"
>  - "nexhop" versus "NEXT_HOP"
> 
> * In Appendix A. "Alternative techniques with limited applicability", the
>  phrase "describe them" ought to be "describes them".
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art