[GROW] AD Review of draft-ietf-grow-bgp-session-culling

Warren Kumari <warren@kumari.net> Sun, 10 September 2017 22:55 UTC

Return-Path: <warren@kumari.net>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E6594132F30 for <grow@ietfa.amsl.com>; Sun, 10 Sep 2017 15:55:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=kumari-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fPSpXvhUjEWa for <grow@ietfa.amsl.com>; Sun, 10 Sep 2017 15:55:42 -0700 (PDT)
Received: from mail-wr0-x233.google.com (mail-wr0-x233.google.com [IPv6:2a00:1450:400c:c0c::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7DC72120724 for <grow@ietf.org>; Sun, 10 Sep 2017 15:55:42 -0700 (PDT)
Received: by mail-wr0-x233.google.com with SMTP id 108so11401137wra.5 for <grow@ietf.org>; Sun, 10 Sep 2017 15:55:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kumari-net.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=+3NEqmwfH8+a+oqtU3VX1sG6F8aLKuFVI9ulkM68Las=; b=aKvQoixiHtvFKhmY6QzmSwjZA8sXyZ2N+fS2oQWZJTYqaiBfoIPwEwAyhw5A+ESETz 7QZM4o54OTDSB8tKmDSNZGFcF+FaPH8M9W+wMStG3J/LKW0BkqhhQrgSsAILK4o/I5rE YJ1FjBv1AcywcwYVamwLinYT1wuT5dqy77DuaeQ72tmHMkp0ZMaXtAI9qVGEST9GS1GV aBK3Vuye44Q7x+eRpyJ2/pkx/usflI6PwW6a4Qjf1gj3q9DiDUEwtIAaKx8D1lscoYJG DJpAWDjIbabwGsgzP7e5VMbxrMLJuq/+ZSn18ry1P2u/WdAuJfkRkVC+BPd57B1TiswA hgmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+3NEqmwfH8+a+oqtU3VX1sG6F8aLKuFVI9ulkM68Las=; b=Obgor1xvFSRzYYTMrL6CDdw0dEgmBNXi6jW9ekvMByo1STT3jrb3LXcbAMRZ7LwT+7 qzMnrxK9f9bPfYR2l73BxxP8xF2uSorMMtpG8UmAbMDt58vW1XF6xrSfVPKM+4SZR3i6 rsA4nwDEwusdy+evMfapEZKYhq/NJvANgKjTjME0+V1ToWGk1irAhpSwrZe8kSOx8huO j+G6a+Mn6zDz/3S9T8wqMsEEOTYundiMyrluOJeLaq/qOEddIEcsySrUzeuzXLKeCFXI iWjkJZYgX1FPQ+DPrKrNIqROKCCtuYgtYuSQn6SPH91t6ZurG8XRUA0Vb6NyEKVi4h4i 3K5Q==
X-Gm-Message-State: AHPjjUiuXR4+eNiZ/zMtB46Ke5n8ttzQ6xgfWRS7NecvgrV7Rkj7Sxsq LVGVNY90acrRjlf8eT+w2ln9m+WHzlN1JBWUXw==
X-Google-Smtp-Source: ADKCNb4DZMtnHxnzvF5J9sH3fwYJ3y7Wh47XZ0x84wyNdkLVN+UOFOlJumgcuvaqXSRu9oGVaNRJ6LjCKT7bRg8DpQM=
X-Received: by 10.223.182.11 with SMTP id f11mr6758538wre.112.1505084140855; Sun, 10 Sep 2017 15:55:40 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.164.141 with HTTP; Sun, 10 Sep 2017 15:55:00 -0700 (PDT)
From: Warren Kumari <warren@kumari.net>
Date: Sun, 10 Sep 2017 18:55:00 -0400
Message-ID: <CAHw9_iL9zHeBxsBo41bPsbYbeFB2sM=A-_KyzLTop125=mHPAA@mail.gmail.com>
To: draft-ietf-grow-bgp-session-culling@ietf.org, grow@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/JLUfWVpvZPRwrzqjxGM9MB7j5iU>
Subject: [GROW] AD Review of draft-ietf-grow-bgp-session-culling
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Sep 2017 22:55:44 -0000

Hi there,

I've just completed my AD review of draft-ietf-grow-bgp-session-culling.

I only had a few small nits:

Section 3:
"Involuntary BGP Session Teardown: The Caretaker of the lower layer
  network disrupts BGP control-plane traffic in the upper layer,
  causing the BGP Hold Timers of the affected BGP session to expire,"
-- it took me a few readings to parse this sentence -- I think that
the "in the upper layer" is redundant and confuses the sentence.
I think just removing it and

"Involuntary BGP Session Teardown:  The Caretaker of the lower layer
  network disrupts (higher layer) BGP control-plane traffic,
  causing the BGP Hold Timers of the affected BGP session to expire,..." ?


2: Section 3.2. Involuntary BGP Session Teardown Recommendations
"Such culling of control-plane traffic will pre-empt the" - s/pre-empt/preempt/


3: I really like the fact that this has actual exmaple config. I think
it would be nice it if also included some more vendors.

Anyway, I'm fine to start IETF LC like this, but it you are able to
post a new version I think things might go smoother.

Please let me know either way.
W



-- 
I don't think the execution is relevant when it was obviously a bad
idea in the first place.
This is like putting rabid weasels in your pants, and later expressing
regret at having chosen those particular rabid weasels and that pair
of pants.
   ---maf