Re: [GROW] On LC for draft-ietf-grow-bmp-tlv (ends December 1st 2021)

Ben Maddison <benm@workonline.africa> Wed, 08 December 2021 16:01 UTC

Return-Path: <benm@workonline.africa>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BBD8E3A0AA7 for <grow@ietfa.amsl.com>; Wed, 8 Dec 2021 08:01:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=workonline.africa
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 85wc18BycWPp for <grow@ietfa.amsl.com>; Wed, 8 Dec 2021 08:01:01 -0800 (PST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10047.outbound.protection.outlook.com [40.107.1.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9AC503A0AA5 for <grow@ietf.org>; Wed, 8 Dec 2021 08:00:58 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DW6w/Ne3QLwp3xWO6/YFoiT03jqhYqGuTTNYOivKC37wWVLDPl0hCoGwr28y2TcK6544cXR6djfGq4FbwD+Kcj6MOB6u38ACWseK3vN12Lg/lLeifBYfAKmWWcmtSlwOa+4fMwaCOD5WWgXEsHgpda+YNbxL+ajg8uPgt1uhTTPi11z9DU8jkbPtBvsPelEb0oFDzJCjdMd6j92LDArfYBH4EMOGD6wUJeYOUkx1YnQC3LxAWvT83g3urJPPEwIQkKiKFAi02x9bqp+2fgi0m2IJAEWMN/Ntjck7rfx4uOsVkGWSmVFqEQw1/CqyuDAxjNP2xIfmwDGtn4yHgY+suw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g0/sMVTkB8WH8pZJ0CYRLD+Vlf6Wl0gTJFMoBv9pOcc=; b=ACm92QV4WOQ1hI2ExvhCF5Dg82HFx2+IhJBGvZJuKWeGAhylcBKgZ6UWTO31n6LIO7vRY+BvBnNiyjzyaIvhUm3aO1D4LRnkmuD4uj0e0YTmRicsCWpVa8x2ftTa16oLkdy+Z5EEh3tHdfxsJO3MtRAlb4h/hqwsFrGB9KO0U+kkdzM2u2qJBxr5AE2bZeaoVV2ObAFflIC31x+AHmtwlUSqTYEpafigSwe8gf7MiK5QgYO3c357bbaZClQ2n949c1lZjw/f440LXfFDqhiLZeTRbffPugFLOY6krVMDFa8SPdho2jKtPm59h5UQ9YV+rkmEidGb4SB+zr25z4hANA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=workonline.africa; dmarc=pass action=none header.from=workonline.africa; dkim=pass header.d=workonline.africa; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=workonline.africa; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g0/sMVTkB8WH8pZJ0CYRLD+Vlf6Wl0gTJFMoBv9pOcc=; b=SO/N2GXCB/VU/QgdE+ST3PlglqHJ9nEC4ow6DljnO1IsE/iGkHCx+iW9irf/QToIDiGAv8wGhDe6UPExkbnWBwAH3vPxed1GLaddELw/zGFl/bDP8WQbvdH8ZxIUX8ZHGeZdmmOtcABYo4z5102Z217+ooxnT28jS7kw+G6TO1M=
Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=workonline.africa;
Received: from AS8P190MB1078.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:2e7::13) by AS8P190MB1413.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:3f0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Wed, 8 Dec 2021 16:00:51 +0000
Received: from AS8P190MB1078.EURP190.PROD.OUTLOOK.COM ([fe80::a079:73c5:8443:3068]) by AS8P190MB1078.EURP190.PROD.OUTLOOK.COM ([fe80::a079:73c5:8443:3068%5]) with mapi id 15.20.4755.021; Wed, 8 Dec 2021 16:00:51 +0000
Date: Wed, 8 Dec 2021 18:00:44 +0200
From: Ben Maddison <benm@workonline.africa>
To: Paolo Lucente <paolo@ntt.net>
Cc: Job Snijders <job@fastly.com>, grow@ietf.org
Message-ID: <20211208160044.44dyabjt5g3lcf6y@benm-laptop>
References: <d7828b07-8f2d-1642-4a12-ea0606b68343@ntt.net> <YZPZUdnQN3BC5CgN@vurt.sobornost.net> <ZRAP278MB0176E2FD40048FFCAC59B1FE89999@ZRAP278MB0176.CHEP278.PROD.OUTLOOK.COM> <Yajh8yO+qBRwqG6X@snel> <20211208134021.dfhosulotmictqwz@benm-laptop> <f84de5b6-8911-c665-0303-d82be96143de@ntt.net>
Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6xvjnrbme52g6tnm"
Content-Disposition: inline
In-Reply-To: <f84de5b6-8911-c665-0303-d82be96143de@ntt.net>
X-ClientProxiedBy: CTXP275CA0006.ZAFP275.PROD.OUTLOOK.COM (2603:1086:100::18) To AS8P190MB1078.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:2e7::13)
MIME-Version: 1.0
Received: from localhost (105.233.97.54) by CTXP275CA0006.ZAFP275.PROD.OUTLOOK.COM (2603:1086:100::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend Transport; Wed, 8 Dec 2021 16:00:50 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7897b749-0abb-4c10-853c-08d9ba63e84b
X-MS-TrafficTypeDiagnostic: AS8P190MB1413:EE_
X-Microsoft-Antispam-PRVS: <AS8P190MB14131D98708C8AE122C36C90C06F9@AS8P190MB1413.EURP190.PROD.OUTLOOK.COM>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ouoTBN7dLISsXMq6Kq708CQj9kiH3u8ILDIoGJukwv+kxLZD73lnYVHfx3+EneexT8tRvdMf/vcH8DAxa6SRb4E+nGHC80tS0HcO1mO7ys4BUAOxSzIl4YtBrOf+3y1Jlu+McEgij6AZp8eCWvJ3wYF8nbtl0duYXKdHqCGSiuVzndogUIqOC8fF7vFxc7xpMVtVdhg+p3xSQmJ5N3qY++HDUDB/s9U2COBqwbzdnn8dLuc7dLcTLzUrbeQNwadbBm7XKeNdNp2KrU7qvh9it3hvk+ucswvtTUvmmz84Hi8m7LF0iZAGqVOExCOtvY9cQms8HWyT9th+HxDOivcLHcQN86fB4Y26gkFFgPn0YgqFhYlfURLrmdqohjlpiL3hzTpqiW6EXhqJaMmNAK93fWOlPsWYjksCJSHkMC/y7aBKwHFJNe3w1f0ai3wtTYuzTYQA9SFo7DY9uNsNVmzKzOzlRVhxlvYajnV/rVjZC/p+GG3IeyJdzEjpjtQlkqTj17AvCaRBPIh8a0FqQYezb0dtJtgGuV900NxyRtqAYh/eSFg/8JcQ+JuXiPCYvDi9mavSedpOHbbtsRcmSwLvnHOfG1gCtU/hNJRXzwFYlP5+nHk//dopxl7H+IEWAchLD1K58YJEU0qkrt8wQUAFNmmRMBGzsO4w/DgKCCKho8B/REeRp1WKIdBmK9tol3SyXKDaw2/hLKka43OzVDsphx+0+bslOIyoiru359vm8dBZfRSy6VFTxCsfUbYLMxjtiakNN1Z2m7zMjqXq9UqIKA==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8P190MB1078.EURP190.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(7916004)(376002)(39830400003)(366004)(396003)(346002)(136003)(66946007)(21480400003)(4326008)(66556008)(9686003)(508600001)(44144004)(86362001)(33716001)(66476007)(26005)(6486002)(6916009)(8936002)(8676002)(6496006)(52116002)(2906002)(956004)(6666004)(186003)(1076003)(38100700002)(316002)(38350700002)(5660300002)(46492014)(2700100001); DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QYVHzF9ChRKtwWNgpdptBssVJOdT0q3UXxXnOgFF139yn1yGybSVPEVxx8kp?= =?us-ascii?Q?fEyKFU+yK5OvG5znNWx5T/rgfAu7Kqm+nYoT+avKJsqXBmkMgCgQMWD7xcFn?= =?us-ascii?Q?v1usBS5bYJb4mNq0ue2RXAAL039hb2XLMHvjINWBSpLXwNUXKQe8I0SzmxjV?= =?us-ascii?Q?S8Z6Uw1FfZWPEz2DCdn8aGmPNQDl5RfdIEWxaypa2p+DrvZd8UFZAfnr5Fr3?= =?us-ascii?Q?BnSs2ofpkZBZ5PTan+1ArA0mX1OyYApqzOgK3kczjdvKdSyGcMgl6rIy56dg?= =?us-ascii?Q?LxjTLlRpNDYxGvtAmuyLMx8LYq2qJE11FhMZjLaiyOLFyhvs9LTuqe9I6RG4?= =?us-ascii?Q?TpfjJulBg99DfmpwdyMSy7L9rRGkxtKBb+Oxko19NiDirsB/s02XRd8Oi5yT?= =?us-ascii?Q?+D/w4x67vm+YxYiuXefuGKInsJL25L6fQIFQgwyWnKdBadsxWifMW/UhpGty?= =?us-ascii?Q?YOOAR0hakCCnfa7NYvg1vCTUunsBoHWKye2sHLPBofMXXKbxAmTWEpCBI5A3?= =?us-ascii?Q?YElZnlBiA5KbOIxF1pHTrzwQHunn1ZcmTzJTCo10kfIMZZVTPg8h2YjMnHEi?= =?us-ascii?Q?/pPgjJCWxDW/j1Ejvqrbr17c4BKqeV02Lnpn3VNl2c2ySLr/zRaouOiHrLwh?= =?us-ascii?Q?TCv9tAIWLfyGrDTJvRE1gu84/oy0ffRF+GtfyK/Ntf74rn2hhHejAOUL5hbr?= =?us-ascii?Q?+ncEauMQJ2zmFl/mSEAJK1eXnpSGQRpXfJnMqSZNXkstDmuHDpHgQZTbHCPC?= =?us-ascii?Q?XcSI1YENMhWyJLbch5vWjF9RxONv6kZ0hvLpWf9rEWyVdbTEgEsUmA/v9D4H?= =?us-ascii?Q?ERH8ezmDwNeE2O3kQOPTFZV7UFiY2c0gLgr3y/unaq76ZVN0Rk0eK+1Y6+4+?= =?us-ascii?Q?37oIdm/ZyuklCL2BQvdLC1NQw0Y6NqXn11WMBzwlhldlfCZY5kB2F/XWCWuk?= =?us-ascii?Q?iekf9bW/aEjQrZ0PYUrD2fe3nZcODDvdTOljaKPRm5siUOYn/H0LV3qrZ75P?= =?us-ascii?Q?OBq7MWQ7+GOwdQRt+bE58vh1bKhUQaIzzVUBiMgshguoDO1FQFMCDPqjTv0R?= =?us-ascii?Q?mfNsp3liAATf8TIl2MjrdlGcTxkIPXz2NeTa6iw3dfpV9UKLqylzJEsRnAP4?= =?us-ascii?Q?2ayXPf59f/95cDmkxRkMpgxQCw+ZYiSCx6NEKTlH74V1M+FhzS3mFHXcdITs?= =?us-ascii?Q?OnOtelh1cNlR3wL1FD/6HYX0ykufxXfcM4IsNT/mpNrr4ZBiifC6ImysTnHo?= =?us-ascii?Q?R5HqNvKiaLQ6jkrH5mEolJiW3rMVxQmASAQeyGv2fT4xHIhHOtU7NdEHo0UV?= =?us-ascii?Q?pLepM/OLN0aaRpb13/dx07DP876hiKQqUfSNlZR8odtPt6IJIsv+y1V5hLoV?= =?us-ascii?Q?dl1HWdPpK2IfBWAT62e8TOFPih8PAOe4lydY4RG5XK0L2HjNWG9ur4T5EYRk?= =?us-ascii?Q?l+FIX0omJHl81b+CUIm5CbCv1H3EohErnHhJe6kE3RCJfoYT3brf9f+hXlDY?= =?us-ascii?Q?4ARlTxMh1UxthAB4KvDpgHwyFpVgp2eC42oXdBdNZdoZzRhwi3IYtNImuVob?= =?us-ascii?Q?eJ0MS1DZ1YYapuCV+Nh5tR1WrbXavQbRWL8SBB5C03zTrWfJgmUcOJD5JAFz?= =?us-ascii?Q?U2W75gmUzHKIAYQnmLpqAsM=3D?=
X-OriginatorOrg: workonline.africa
X-MS-Exchange-CrossTenant-Network-Message-Id: 7897b749-0abb-4c10-853c-08d9ba63e84b
X-MS-Exchange-CrossTenant-AuthSource: AS8P190MB1078.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 16:00:51.2365 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b4e811d5-95e8-453a-b640-0fba8d3b9ef7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f7bNsb1OOr8cDr4l4S+qc79FPdmQIYrEhKGMF4w2k4MdYs/Tp0NMfUT1uYnctaZK8OaCG+LZ86IFgS+emM1GCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P190MB1413
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/QlKcks4yD6C_uNrg6FkJw3gi3-Y>
Subject: Re: [GROW] On LC for draft-ietf-grow-bmp-tlv (ends December 1st 2021)
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Dec 2021 16:01:08 -0000

Hi Paolo,

On 12/08, Paolo Lucente wrote:
> 
> Hi Ben,
> 
> Thank you for your review, very much appreciated. I will merge your PR on
> GitHub asap. With regards to the other two points:
> 
> 1) This came through a suggestion back then from Jeff Haas that i support as
> it made sense to me, see here his comment on this list:
> 
> ==
> While a bit pedantic, I strongly suggest "TLVs SHOULD be sorted by their
> code point.".
> 
> Many implementations that deal with TLV based protocols will canonicalize
> data structures based on the TLVs using sorted structures.  Having them
> sorted on the wire means the canonicalization step is cheaper.
> 
> Note that this is a general justification for the procedure and it's not
> critical for something like BMP.
> ==
> 
That makes sense, thanks.
Having never written a routine that does this, I am slightly surprised
that it is still cheaper, even if the implementation cannot *require* that
it will arrive sorted - but I am more than happy to take yours and Jeff's
word for it!

> 2) That is right & suggestion accapted. I will make it further explicit.
> 
Ack. Thanks.

Cheers,

Ben