Re: [GROW] Genart last call review of draft-ietf-grow-bgp-session-culling-04

Matt Griswold <grizz@20c.com> Thu, 21 September 2017 19:09 UTC

Return-Path: <grizz@20c.com>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA7F713300C for <grow@ietfa.amsl.com>; Thu, 21 Sep 2017 12:09:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=20c-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SMlqD0GEB84l for <grow@ietfa.amsl.com>; Thu, 21 Sep 2017 12:09:01 -0700 (PDT)
Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C457313292A for <grow@ietf.org>; Thu, 21 Sep 2017 12:08:59 -0700 (PDT)
Received: by mail-io0-x231.google.com with SMTP id d16so13139178ioj.3 for <grow@ietf.org>; Thu, 21 Sep 2017 12:08:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=20c-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ajY+IoGbpz70jvGBLnqSu+a9imlBvp4KbffcvxrT5qI=; b=RugmZYcUnPPhHK16xOGm4YGGBiBpbEv/ToH+vZBQ5adACxHLH6mWOEki633OO18SC2 deAQz51D02YukX5K9nPJteJt+eCkAYeH+wiwdTmZQotX3MvTh1vvc+NiT5/DcDs2Z1bT U83PeAdn3Nrdgf8kKXmlGDiSmQg3AbXIvhYmJ+8nYgcoEJEGDMwwi2i07wXMarvpECGU iXHPhoCi5zYY+IAl1AQiIDRUSrhJJuEJsi3k8i/5G461WoqijHoKWCCfO1CTn200ix6h 5Qtda6brefKO+l5qs/MvuettKFnuig7FFvE8exqQtlD/a71c4yKMgvjnVchyX4nubtDK 9FFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ajY+IoGbpz70jvGBLnqSu+a9imlBvp4KbffcvxrT5qI=; b=ZIyCTzM4yH5FdqH9WDBG5DNhhITi68Z9K5lUZmtJji+sRZ9vHO1C3shv+WIjWntJhQ r62lGJtcvFhI2KvUt8ZylLJ+eGTedGrs1n1OtBIZSoI9dfy3oazdMUrf9cqvN6ga3tGR gMKn57d3JMJvovQR/HP8gIe5Lpp3NlIlcVmgxFoVQWRRxa/Bfcm62Mg2JeT6ly/fNi/S 820edNTfHV+crSYTl/jT8fXTCzHO2J0/aB8i3wK5bK12DOEDocFxPISDL3S6/1gvXYQ+ nxadgfiX1Ey1rSWrBGnablmi/MvSh8RNfy7S3BUrBCFAQueBefDQLTpI80d8c7RQglnQ QRmA==
X-Gm-Message-State: AHPjjUjwkPdMHh1lCen4Pf1vcORhmDXLGEPrKdgAsv2RKZQUpzmLUWFo O+Cu+9QXcuj3MKGvonIzbQ/XZQ==
X-Google-Smtp-Source: AOwi7QABrz1ZnnNqmMum3LizFLzkdG0dk1pw4AkFh/HDINNhF5+mGP9ZDe0G7IyDDnc2MPgUDeP9Uw==
X-Received: by 10.107.29.149 with SMTP id d143mr4679842iod.201.1506020938883; Thu, 21 Sep 2017 12:08:58 -0700 (PDT)
Received: from x0r (97-83-204-249.dhcp.eucl.wi.charter.com. [97.83.204.249]) by smtp.gmail.com with ESMTPSA id 193sm1138094ion.83.2017.09.21.12.08.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 12:08:57 -0700 (PDT)
Date: Thu, 21 Sep 2017 19:08:55 +0000
From: Matt Griswold <grizz@20c.com>
To: Brian E Carpenter <brian.e.carpenter@gmail.com>
Cc: gen-art@ietf.org, grow@ietf.org, draft-ietf-grow-bgp-session-culling.all@ietf.org
Message-ID: <20170921190855.303addad@x0r>
In-Reply-To: <5aedafdd-8cc6-8d25-e702-26b4beac15ea@gmail.com>
References: <150579629891.15651.17244647188709040958@ietfa.amsl.com> <20170921001353.260a3439@x0r> <5aedafdd-8cc6-8d25-e702-26b4beac15ea@gmail.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/S1LHd8dyAeVNb2uZaaClwouCbF4>
Subject: Re: [GROW] Genart last call review of draft-ietf-grow-bgp-session-culling-04
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2017 19:09:03 -0000

* Brian E Carpenter <brian.e.carpenter@gmail.com> [170921 14:19 +1200]:
> On 21/09/2017 12:13, Matt Griswold wrote:
> > * Brian Carpenter <brian.e.carpenter@gmail.com> [170918 21:44
> >   -0700]:  
> >> Minor Issues:
> >> -------------
> >>  
> >>> 3.1.1.  Maintenance Considerations
> >>>
> >>>  Initiators of the administrative shutdown could consider using
> >>>  Graceful Shutdown [I-D.ietf-grow-bgp-gshut] to facilitate smooth
> >>>  drainage of traffic prior to session tear down, and the Shutdown
> >>>  Communication [I-D.ietf-idr-shutdown]...    
> >>
> >> This strikes me as vague. "Could consider"? Surely if this is
> >> a BCP, they MUST use some mechanisms and perhaps SHOULD use these
> >> particular mechanisms. Otherwise the document doesn't specify
> >> anything much at all for this case.  
> > 
> > Graceful Shutdown is just one of multiple ways an Operator can
> > accomplish that.  
> 
> Understood, so perhaps it's a MAY not a SHOULD

You're right, I will update it to MAY.

> but the text still really only seems to say "do the right thing"
> without saying what that is. To be honest the whole document is a bit
> like that - written for members of the club who know how to run BGP,
> rather than for a newcomer who wants to know how to run BGP.

That's really by design, the document is for people who know and run
BGP, I think putting too much basic BGP knowledge would make it
monotonous. Any ideas on how to meet in the middle?

> >> Secondly, if there are no fault indications, what causes the
> >> Caretaker to cull sessions? What's the trigger? Is the Caretaker
> >> supposed to know by magic that layer 2 maintenance is planned?  
> > 
> > The Caretaker controls the layer 2 network, so yes, would do this as
> > part of the maintenance process.  
> 
> Again: not clear to a newcomer.

The updated language is:

  Throughout this document the "Caretaker" is defined to be in control
  of the lower layer network, while "Operators" directly administrate
  the BGP speakers.

I think that clears it up?

> >> And in Appendix A, explain precisely how the example prefixes are
> >> used: what makes them relevant? Are they normally announced by BGP
> >>   to all the IXP's BGP peers?  
> > 
> > They are the IXP LAN addresses, as explained above the examples.  
> 
> Yes, I realise that, but again you're assuming that the reader has
> a complete picture in her mind. Maybe there's actually a need for
> a scenario description in the Introduction, or at least a reminder
> that in normal operation, paths through the fabric in question may be
> known throughout the BGP realm, and the objective is to delete
> those paths before starting maintenance.

Again, that section is for IXP Caretakers so I don't think we need to
go into IXP operational details too much. Adding a brief scenario
paragraph should work, I'll write something up.

Thanks