Re: [GROW] AD Review of draft-ietf-grow-bgp-session-culling

[Job Snijders <[e-mail]>]

Dear Warren,

On Sun, Sep 10, 2017 at 06:55:00PM -0400, Warren Kumari wrote:
> I've just completed my AD review of draft-ietf-grow-bgp-session-culling.
> 
> I only had a few small nits:
> 
> Section 3:
> "Involuntary BGP Session Teardown: The Caretaker of the lower layer
>   network disrupts BGP control-plane traffic in the upper layer,
>   causing the BGP Hold Timers of the affected BGP session to expire,"
> -- it took me a few readings to parse this sentence -- I think that
> the "in the upper layer" is redundant and confuses the sentence.
> I think just removing it and
> 
> "Involuntary BGP Session Teardown:  The Caretaker of the lower layer
>   network disrupts (higher layer) BGP control-plane traffic,
>   causing the BGP Hold Timers of the affected BGP session to expire,..." ?

works for me!

> 2: Section 3.2. Involuntary BGP Session Teardown Recommendations
> "Such culling of control-plane traffic will pre-empt the" - s/pre-empt/preempt/

Thanks

> 3: I really like the fact that this has actual exmaple config. I think
> it would be nice it if also included some more vendors.

Even more?! We already have config for four vendors in the Internet-Draft itself. :-)

There also is a link to https://github.com/bgp/bgp-session-culling-config-examples which is a
more 'live' version which can be updated as we go. The github repo
currently has 7 platforms, and perhaps over time will grow based on
contributions.

The configuration example in the Internet-Draft itself mostly serves to
demonstrate the concept in the universal language other than English:
router configs. The example configs are not meant to be an exhaustive
overview.

> Anyway, I'm fine to start IETF LC like this, but it you are able to
> post a new version I think things might go smoother.
> 
> Please let me know either way.

Sure, I'll bump.

Kind regards,

Job