Re: [Hipsec] Fwd: New Version Notification for draft-ietf-hip-dex-12.txt

Robert Moskowitz <rgm@htt-consult.com> Wed, 12 February 2020 17:36 UTC

Return-Path: <rgm@htt-consult.com>
X-Original-To: hipsec@ietfa.amsl.com
Delivered-To: hipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B87E12098C for <hipsec@ietfa.amsl.com>; Wed, 12 Feb 2020 09:36:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q4-A_DCUXokC for <hipsec@ietfa.amsl.com>; Wed, 12 Feb 2020 09:36:44 -0800 (PST)
Received: from z9m9z.htt-consult.com (z9m9z.htt-consult.com [23.123.122.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 746EA12094B for <hipsec@ietf.org>; Wed, 12 Feb 2020 09:36:44 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by z9m9z.htt-consult.com (Postfix) with ESMTP id 384D562132; Wed, 12 Feb 2020 12:36:43 -0500 (EST)
X-Virus-Scanned: amavisd-new at htt-consult.com
Received: from z9m9z.htt-consult.com ([127.0.0.1]) by localhost (z9m9z.htt-consult.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 96yoPs89smMp; Wed, 12 Feb 2020 12:36:37 -0500 (EST)
Received: from lx140e.htt-consult.com (unknown [192.168.160.12]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by z9m9z.htt-consult.com (Postfix) with ESMTPSA id A2DF360029; Wed, 12 Feb 2020 12:36:37 -0500 (EST)
To: Jeff Ahrenholz <j.ahrenholz@tempered.io>, HIP <hipsec@ietf.org>
References: <158131871520.13534.9437394233256375155.idtracker@ietfa.amsl.com> <29372f3d-0a9e-949d-ce64-338be8561500@htt-consult.com> <66046762-C4F2-47AD-BE69-7CAA1AEB6F2A@tempered.io>
From: Robert Moskowitz <rgm@htt-consult.com>
Message-ID: <c3019aa3-128e-7d8a-34d0-f8c82a597135@htt-consult.com>
Date: Wed, 12 Feb 2020 12:36:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <66046762-C4F2-47AD-BE69-7CAA1AEB6F2A@tempered.io>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/hipsec/AldlnXZ9C839f6gGwIrQzId-g58>
Subject: Re: [Hipsec] Fwd: New Version Notification for draft-ietf-hip-dex-12.txt
X-BeenThere: hipsec@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is the official IETF Mailing List for the HIP Working Group." <hipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hipsec>, <mailto:hipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hipsec/>
List-Post: <mailto:hipsec@ietf.org>
List-Help: <mailto:hipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hipsec>, <mailto:hipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Feb 2020 17:36:52 -0000


On 2/12/20 12:20 PM, Jeff Ahrenholz wrote:
>> I believe this version answers all the IESG issues.
>>
>> Please review, there are some important additions.
>>
>> EKR had a number of security concerns.  Some I feel don't apply to HIP, like use an AEAD for HIP packet security.
>>
>> But there are a number of added sections, particularly in Security Considerations that are worth the group's review that I have things stated properly.
>>
>> Also there is a new parameter, I_NONCE to add Initiator randomness into the Master Key generation.  There is some cleanup in the KEYMAT section to reflect this.
>>
>> So please take a read through.
> I took a look at the new I_NONCE parameter...
>
> Regarding this statement (Section 5.2.6):
> "The I_NONCE parameter encapsulates a random value that is later used in the Master key creation process (see Section 6.3)."
>
> Looking at Section 6.3 HIP DEX KEYMAT Generation, it discusses using Diffie-Hellman derived key Kij, but I don't see anything about using I_NONCE. There is a random #I  provided by the Responder from the PUZZLE parameter, but nothing about a random I_NONCE supplied by the Initiator.

In 6.3:

        IKM       Input keying material
                    the Diffie-Hellman derived key, concatenated with the
                      random I_NONCE value for the Master Key SA
                    the Diffie-Hellman derived key, concatenated with the
                      random values of the ENCRYPTED_KEY parameters in
                      the same order as the HITs with sort(HIT-I | HIT-R)
                      for the Pair-wise Key SA


> minor nits:
> s/when key is smaller or equal to 128 bits/when the key is smaller or equal to 128 bits/
> In Section 4.1.1 HIP Puzzle Mechanism, the links (HTML version) to RFC 7401 sections 4.1.1 and 4.1.2 do not link to RFC 7401 but to the dex draft.

I will look at this one again.

Back later on it.