Re: [Hipsec] draft-ietf-hip-cert-04 review

Samu Varjonen <samu.varjonen@hiit.fi> Mon, 27 September 2010 10:00 UTC

Return-Path: <samu.varjonen@hiit.fi>
X-Original-To: hipsec@core3.amsl.com
Delivered-To: hipsec@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 7EA203A6CB2 for <hipsec@core3.amsl.com>; Mon, 27 Sep 2010 03:00:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S2yOuA2PiCyX for <hipsec@core3.amsl.com>; Mon, 27 Sep 2010 03:00:41 -0700 (PDT)
Received: from argo.otaverkko.fi (argo.otaverkko.fi [212.68.0.2]) by core3.amsl.com (Postfix) with ESMTP id 4E5703A6CE7 for <hipsec@ietf.org>; Mon, 27 Sep 2010 03:00:41 -0700 (PDT)
Received: from [128.214.114.246] (wel-36.pc.hiit.fi [128.214.114.246]) by argo.otaverkko.fi (Postfix) with ESMTP id 9B1BB25ED17; Mon, 27 Sep 2010 13:01:18 +0300 (EEST)
Message-ID: <4CA06B6E.3060308@hiit.fi>
Date: Mon, 27 Sep 2010 13:01:18 +0300
From: Samu Varjonen <samu.varjonen@hiit.fi>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8
MIME-Version: 1.0
To: Ari Keranen <ari.keranen@nomadiclab.com>
References: <20100923104502.A5CA73A6951@core3.amsl.com> <4C9B337D.4000904@hiit.fi> <4C9B580A.4080808@nomadiclab.com>
In-Reply-To: <4C9B580A.4080808@nomadiclab.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: hipsec@ietf.org
Subject: Re: [Hipsec] draft-ietf-hip-cert-04 review
X-BeenThere: hipsec@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: "This is the official IETF Mailing List for the HIP Working Group." <hipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/hipsec>, <mailto:hipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hipsec>
List-Post: <mailto:hipsec@ietf.org>
List-Help: <mailto:hipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hipsec>, <mailto:hipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Sep 2010 10:00:43 -0000

On 23/09/10 16:37, Ari Keranen wrote:
> Hi,
>
> I had a quick look at this and here's some comments. Overall, I like the
> draft and hope to see it LC'd soon.
>
>
> 3. X.509.v3 Certificate Object and Host Identities
>
> If only HIP information is presented as either
> the issuer or the subject the HIT is also placed into the respective
> entity's DNs Common Name (CN) section in a colon delimited
> presentation format.
>
> Could be more explicit on the presentation format, e.g. RECOMMEND (or
> MUST) RFC5952 canonical style.

OK.

>
>
> Format:
> Issuer: CN=hit-of-host
> Subject: CN=hit-of-host
>
> X509v3 extensions:
> X509v3 Issuer Alternative Name:
> IP Address:HIT-OF-HOST
> X509v3 Subject Alternative Name:
> IP Address:HIT-OF-HOST
>
>  From here (and especially from the example) one gets the idea that the
> exact same information would be there 4 times. The issuer and subject
> can be (and often are?) different, right?
>

The answer is above the example.

"
    If only HIP information is presented as either
    the issuer or the subject the HIT is also placed into the respective
    entity's DNs Common Name (CN) section in a colon delimited
    presentation format.  *Inclusion of CN is not necessary if DN contains
    any other information.*  It is RECOMMENDED to use the FQDN/NAI from
    the hosts HOST_ID parameter in the DN if one exists.
"

Do you think that this needs clarification?

>
> 6. Error signaling
>
> INVALID_CERTIFICATE 50
>
> Sent in response to a failed verification of a certificate.
> Notification Data contains 4 octets, in order Cert group,
> Cert count, Cert ID, and Cert type of the certificate
> parameter that caused the failure.
>
> How does the verifier determine which certificate (if there are more
> than one) caused the failure? Isn't it rather always so that none of the
> given certificates were valid (for this particular use)?
>

In most cases I would say that one failed verification fails the verification of 
the whole chain. But in a case where you send two certificates/chains for 
different services and the other one fails you might want to know which failed. 
Registration extensions the REG_FAILED would reveal the failed chain. I would 
like to leave the possibility to tell the specific failed certificate for 
HIP-aware applications. So, maybe it should say that the Notification Data MAY 
contain 4 octets...

>
> Some nits:
>
> Expand "HIP" in the title and abstract.
>

OK.

> The place of the "Requirements Language" section is a bit strange
> (compared to any other draft/RFC). Or is this some new formatting rule?
>

Looks a bit odd to me too. I'll check this out.

>
> 2. CERT Parameter
>
> Cert Type Describes the type of the certificate
>
> s/Describes/Indicates
>

OK.

>
> Hash and URL encodings (3 to 4) are used as defined in [RFC4306]
>
> s/to/and/
> since there are now only two instead of 4 options (and to be consistent
> with the others)
>

OK.

>
> 3. X.509.v3 Certificate Object and Host Identities
>
> In this scenario, it is recommended that the HIP peers have and use
>
> RFC2119-capitalize "recommended" (also later in the draft)
>

OK.

>
> 6. Error signaling
>
> If the Initiator does not send the certificate that the Responder
> requires the Responder may take actions (e.g. blocking the
> connection).
>
> "reject" instead of "blocking" might be more appropriate word here.
>

OK.

>
> 8. Security Considerations
>
> It is not recommended to use grouping or hash and URL encodings when
>
> RFC2119-capitalize "not recommended"
>

OK.

>
> Cheers,
> Ari
>
> On 09/23/2010 02:01 PM, Samu Varjonen wrote:
>> Hi,
>>
>> This is the updated version of the cert draft.
>>
>> Changes from version 03 to 04:
>>
>> o Added the non-HIP aware use case to the Section 3.
>>
>> o Clarified that the HITs are not always required in the
>> certificates.
>>
>> o Rewrote the signaling section.
>>
>> o LDAP URL to LDAP DN in Section 2 last paragraph.
>>
>> o CERT is always covered by a signature as it's type number requires
>>
>> o New example certificates
>>
>> o Style and language clean-ups
>>
>> o Changed IANA considerations
>>
>> o Revised the type numbers
>>
>> o RFC 2119 keywords
>>
>> o Updated the IANA considerations section
>>
>> o Rewrote the abstract
>>
>> Comments are appreciated.
>>
>> BR,
>> Samu
>>
>> On 09/23/2010 01:45 PM, Internet-Drafts@ietf.org wrote:
>>> A New Internet-Draft is available from the on-line Internet-Drafts
>>> directories.
>>> This draft is a work item of the Host Identity Protocol Working Group
>>> of the IETF.
>>>
>>>
>>> Title : HIP Certificates
>>> Author(s) : T. Heer, S. Varjonen
>>> Filename : draft-ietf-hip-cert-04.txt
>>> Pages : 13
>>> Date : 2010-09-23
>>>
>>> The CERT parameter is a container for X.509.v3 certificates and
>>> Simple Public Key Infrastructure (SPKI) certificates. It is used for
>>> carrying these certificates in HIP control packets. This document
>>> only specifies the certificate parameter and the error signaling in
>>> case of a failed verification. The use of certificates including how
>>> certificates are obtained, requested, and which actions are taken
>>> upon successful or failed verification are to be defined in the
>>> documents that use the certificate parameter. Additionally, this
>>> document specifies the representations of Host Identity Tags in
>>> X.509.v3 and SPKI certificates.
>>>
>>> A URL for this Internet-Draft is:
>>> http://www.ietf.org/internet-drafts/draft-ietf-hip-cert-04.txt
>>>
>>> Internet-Drafts are also available by anonymous FTP at:
>>> ftp://ftp.ietf.org/internet-drafts/
>>>
>>> Below is the data which will enable a MIME compliant mail reader
>>> implementation to automatically retrieve the ASCII version of the
>>> Internet-Draft.
>>>
>>>
>>>
>>> _______________________________________________
>>> Hipsec mailing list
>>> Hipsec@ietf.org
>>> https://www.ietf.org/mailman/listinfo/hipsec
>>
>> _______________________________________________
>> Hipsec mailing list
>> Hipsec@ietf.org
>> https://www.ietf.org/mailman/listinfo/hipsec
>