Re: [http-state] test data question

Vasiliy Baranov <vasiliy.baranov@oracle.com> Wed, 23 November 2011 10:10 UTC

Return-Path: <vasiliy.baranov@oracle.com>
X-Original-To: http-state@ietfa.amsl.com
Delivered-To: http-state@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0809B21F8C1C for <http-state@ietfa.amsl.com>; Wed, 23 Nov 2011 02:10:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.565
X-Spam-Level:
X-Spam-Status: No, score=-6.565 tagged_above=-999 required=5 tests=[AWL=0.034, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e7y0HbyIXQzt for <http-state@ietfa.amsl.com>; Wed, 23 Nov 2011 02:10:25 -0800 (PST)
Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by ietfa.amsl.com (Postfix) with ESMTP id 02D2E21F8C18 for <http-state@ietf.org>; Wed, 23 Nov 2011 02:10:24 -0800 (PST)
Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id pANAAMvt027205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 23 Nov 2011 10:10:23 GMT
Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id pANAALA8015804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Nov 2011 10:10:22 GMT
Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id pANAAFHr030389; Wed, 23 Nov 2011 04:10:15 -0600
Received: from [10.162.83.149] (/10.162.83.149) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 23 Nov 2011 02:10:14 -0800
Message-ID: <4ECCC65D.1050105@oracle.com>
Date: Wed, 23 Nov 2011 14:09:33 +0400
From: Vasiliy Baranov <vasiliy.baranov@oracle.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.20) Gecko/20110804 Thunderbird/3.1.12
MIME-Version: 1.0
To: Adam Barth <ietf@adambarth.com>
References: <4ECBCA44.2020800@oracle.com> <CAJE5ia9ub1G7_BgsVW4J5kgayYc-6VBDAnijWq2=cPtGGh-M6Q@mail.gmail.com> <CAJE5ia92rUK1cfYiyo_rqqv8J9H-Lcc_y6e45kBnOf=3tX9G2A@mail.gmail.com>
In-Reply-To: <CAJE5ia92rUK1cfYiyo_rqqv8J9H-Lcc_y6e45kBnOf=3tX9G2A@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
X-Source-IP: acsinet22.oracle.com [141.146.126.238]
X-Auth-Type: Internal IP
X-CT-RefId: str=0001.0A090209.4ECCC68F.0101,ss=1,re=0.000,fgs=0
Cc: http-state@ietf.org
Subject: Re: [http-state] test data question
X-BeenThere: http-state@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discuss HTTP State Management Mechanism <http-state.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/http-state>, <mailto:http-state-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/http-state>
List-Post: <mailto:http-state@ietf.org>
List-Help: <mailto:http-state-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/http-state>, <mailto:http-state-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Nov 2011 10:10:26 -0000

Hi Adam,

Thank you for clarifying this and fixing the test.

Also, thank you and the group for the RFC and the test suite. They help 
so much.

Thank you,
-- Vasiliy

On 22.11.2011 22:39, Adam Barth wrote:
> On Tue, Nov 22, 2011 at 10:36 AM, Adam Barth<ietf@adambarth.com>  wrote:
>> Thanks for the report.  This is an error in the test suite, which I'll fix.
>
> Done.
>
>> The test is from an older version of the spec that allowed "valueless"
>> cookies.  The working group decided to remove the concept of valueless
>> cookies (we can look up the tracker number if you want to see exactly
>> why).
>>
>> Thanks again,
>> Adam
>>
>>
>> On Tue, Nov 22, 2011 at 8:13 AM, Vasiliy Baranov
>> <vasiliy.baranov@oracle.com>  wrote:
>>> Hello,
>>>
>>> I have a cookie implementation that attempts to follow RFC 6265. If I run it
>>> against the test data found in https://github.com/abarth/http-state, the
>>> following test fails:
>>>
>>>     tests/data/parser/name0032-test:
>>>
>>>         Set-Cookie: "foo\"bar;baz"=qux
>>>
>>>
>>>     tests/data/parser/name0032-expected:
>>>
>>>         Set-Cookie: "foo\"bar
>>>
>>>
>>> I am by no means an expert in this area but it seems to me this test goes
>>> against the spec, in particular, the following statement found in RFC 6265
>>> on page 17:
>>>
>>>    2.  If the name-value-pair string lacks a %x3D ("=") character,
>>>        ignore the set-cookie-string entirely.
>>>
>>>
>>> My understanding is, for the test in question the name-value-pair is
>>> '"foo\"bar'. This name-value-pair obviously lacks the "=" character, so my
>>> reading of the spec is the cookie should be rejected entirely. The test,
>>> however, expects the cookie to be accepted and sent back to the server on
>>> the subsequent request. Does that mean my reading of the spec is incorrect?
>>>
>>> I tried this test in Chrome 16.0.912.41 beta-m, Firefox 6.0.1, IE 8, and
>>> Safari 5.0.5. It passes everywhere except for Safari and my poor
>>> implementation.
>>>
>>> Thanks,
>>> -- Vasiliy
>>> _______________________________________________
>>> http-state mailing list
>>> http-state@ietf.org
>>> https://www.ietf.org/mailman/listinfo/http-state
>>>
>>