Resent-Date: Wed, 29 Jan 2020 19:29:22 +0000
Resent-Message-Id: <E1iwt1e-0003hr-S1@frink.w3.org>
MIME-Version: 1.0
References: <C295C393-9602-4D41-9071-30629605E349@apple.com>
In-Reply-To: <C295C393-9602-4D41-9071-30629605E349@apple.com>
From: Rob Sayre <sayrer@gmail.com>
Date: Wed, 29 Jan 2020 11:29:06 -0800
Message-ID: <CAChr6Sxvf8b+qviZoBbhD4CjFohswmGBx+AzXUvggck80-zeRg@mail.gmail.com>
To: Tommy Pauly <tpauly@apple.com>
Cc: HTTP Working Group <ietf-http-wg@w3.org>
Content-Type: multipart/alternative; boundary="000000000000478ea4059d4c5bc9"
Received-SPF: pass client-ip=2607:f8b0:4864:20::12d;
 envelope-from=sayrer@gmail.com; helo=mail-il1-x12d.google.com
Subject: Re: Working Group Last Call: Structured Headers for HTTP
Archived-At: <https://www.w3.org/mid/CAChr6Sxvf8b+qviZoBbhD4CjFohswmGBx+AzXUvggck80-zeRg@mail.gmail.com>
Resent-From: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list

--000000000000478ea4059d4c5bc9
Content-Type: text/plain; charset="UTF-8"

On Wed, Jan 29, 2020 at 9:14 AM Tommy Pauly <tpauly@apple.com> wrote:

> Hi all,
>
> The Structured Headers draft was updated yesterday, and Mark (as author)
> let me know that the authors believe this is ready for last call. The
> issues list is down to zero, so it's a good time for the working group to
> take a careful read-through the document, and get it progressed!
>

I think the technical aim of the document is fine, but it needs another
round just looking for editorial nits. I found small things like:

Duplicate parsing steps (#2 and #6):
https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-15#section-4.2

and duplicate references. I believe the document may also need a collected
ABNF grammar. There are references to things like "item_or_inner_list" that
indicate there probably is a grammar, but it's just not in the document. It
may also be worthwhile to add a PEG grammar to the test repository before
publication, so that it's clear that the specification is straightforward
to parse with a recursive descent parser (I would use Pest[0]).

thanks,
Rob

[0] https://github.com/pest-parser/pest

--000000000000478ea4059d4c5bc9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, Jan 29, 2020 at 9:14 AM Tommy Pau=
ly &lt;<a href=3D"mailto:tpauly@apple.com">tpauly@apple.com</a>&gt; wrote:<=
br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div style=3D"overflow-wrap: break-word;"><div>Hi all,</div><div=
><br></div><div>The Structured Headers draft was updated yesterday, and Mar=
k (as author) let me know that the authors believe this is ready for last c=
all. The issues list is down to zero, so it&#39;s a good time for the worki=
ng group to take a careful read-through the document, and get it progressed=
!</div></div></blockquote><div><br></div><div>I think the technical aim of =
the document is fine, but it needs another round just looking for editorial=
 nits. I found small things like:</div><div><br></div><div>Duplicate parsin=
g steps (#2 and #6):</div><div><a href=3D"https://tools.ietf.org/html/draft=
-ietf-httpbis-header-structure-15#section-4.2">https://tools.ietf.org/html/=
draft-ietf-httpbis-header-structure-15#section-4.2</a><br></div><div><br></=
div><div>and duplicate references. I believe the document may also need a c=
ollected ABNF grammar. There are references to things like &quot;item_or_in=
ner_list&quot; that indicate there probably is a grammar, but it&#39;s just=
 not in the document. It may also be worthwhile to add a PEG grammar to the=
 test repository before publication, so that it&#39;s clear that the specif=
ication is straightforward to parse with a recursive descent parser (I woul=
d use Pest[0]).</div><div><br></div><div>thanks,</div><div>Rob</div><div><b=
r></div><div>[0]=C2=A0<a href=3D"https://github.com/pest-parser/pest">https=
://github.com/pest-parser/pest</a></div><div><br></div></div></div>

--000000000000478ea4059d4c5bc9--