Éric Vyncke's No Objection on draft-ietf-httpbis-compression-dictionary-09: (with COMMENT)

Éric Vyncke via Datatracker <noreply@ietf.org> Mon, 12 August 2024 11:36 UTC

Received: by ietfa.amsl.com (Postfix) id A2C7BC14F749; Mon, 12 Aug 2024 04:36:29 -0700 (PDT)
Delivered-To: ietfarch-httpbisa-archive-bis2juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A203FC14F5F3 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Mon, 12 Aug 2024 04:36:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.758
X-Spam-Level:
X-Spam-Status: No, score=-2.758 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, MAILING_LIST_MULTI=-1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=w3.org header.b="Zy+wNhCw"; dkim=pass (2048-bit key) header.d=w3.org header.b="EVWCw9Ka"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z4ZQ9z0huYcG for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Mon, 12 Aug 2024 04:36:25 -0700 (PDT)
Received: from mab.w3.org (mab.w3.org [IPv6:2600:1f18:7d7a:2700:d091:4b25:8566:8113]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C1A5C14F707 for <httpbisa-archive-bis2Juki@ietf.org>; Mon, 12 Aug 2024 04:36:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=w3.org; s=s1; h=Subject:Date:Message-ID:Reply-To:Cc:To:From:Content-Type:MIME-Version :In-Reply-To:References; bh=dG3CQ4F7Gx0IHitKqHzv7S4miN1RWKpmMAp3H/lY3Cg=; b=Z y+wNhCw6txU3aAuKds9mAWaowoLKXvpNLkPByMAEpM3C/3tkID0plVt5UFqg+F9DSfXjnALH4QUgQ LTVH5J3Lkg3c2BAc5WLcTxQwuXDm5efklHLmgCLajkffeUng9IQPF8uSlaKLUjWAq+VbLxCLF/ei2 Kk8UA6JqQL0wop6zHW8oHaYlS4mD+1/j81Wo365Ztes57GmdO2lEiswVh4sl7ydaAlVHmHLLwtoMc VdHJipuH6rIIWPqIPX5bzAx6O/GsEi2q372aToDJpTenswP92NBY51PD/d/KQhDca30Mc+00T2OH0 M1fvhqPwRgWCQhxeuQJKks3BkiIlEXBzg==;
Received: from lists by mab.w3.org with local (Exim 4.96) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1sdTKd-00HUsM-1Q for ietf-http-wg-dist@listhub.w3.org; Mon, 12 Aug 2024 11:35:23 +0000
Resent-Date: Mon, 12 Aug 2024 11:35:23 +0000
Resent-Message-Id: <E1sdTKd-00HUsM-1Q@mab.w3.org>
Received: from ip-10-0-0-224.ec2.internal ([10.0.0.224] helo=puck.w3.org) by mab.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <noreply@ietf.org>) id 1sdTKb-00HUrQ-0J for ietf-http-wg@listhub.w3.internal; Mon, 12 Aug 2024 11:35:21 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=w3.org; s=s1; h=Date:Message-ID:Reply-To:Subject:Cc:To:From:Content-Type:MIME-Version :In-Reply-To:References; bh=dG3CQ4F7Gx0IHitKqHzv7S4miN1RWKpmMAp3H/lY3Cg=; t=1723462521; x=1724326521; b=EVWCw9KaFBqUCrJmx/O4JrNT1P47i/ciKTSeabRZkvGe9uc ahU0pyx4rBn8AFyAyinEOGVjH8Y52+feAhzwyRwd/1dkxPNw8urWBPrcK23c3Yn6DVQaJhjuCnPlp URo0b2zDbOWk8amP/RowEj/a1DIU7Xyyn+F5rCtOLf45VTVJFsXx94Zlbz8L3tspYmtGyIA1LAOpA rpliECN8uMDh/YpPHsQpbhbnAiHxYu1ZxXEtf6oAe9kvoOv14Inp3NdatrEvLkr3u0uDe4O+BKTS0 Skr9A6VeseHsj8flGTzwLMBcz2k0IAtbDJhzzybynvwjNTifsEH/Ua2sP1HFkTvg==;
Received-SPF: pass (puck.w3.org: domain of ietf.org designates 50.223.129.194 as permitted sender) client-ip=50.223.129.194; envelope-from=noreply@ietf.org; helo=mail.ietf.org;
Received: from mail.ietf.org ([50.223.129.194]) by puck.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <noreply@ietf.org>) id 1sdTKa-00Ah9C-19 for ietf-http-wg@w3.org; Mon, 12 Aug 2024 11:35:21 +0000
Received: from [10.244.2.52] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id 35564C151996; Mon, 12 Aug 2024 04:35:16 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Éric Vyncke via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-httpbis-compression-dictionary@ietf.org, httpbis-chairs@ietf.org, ietf-http-wg@w3.org, mnot@mnot.net, mnot@mnot.net
X-Test-IDTracker: no
X-IETF-IDTracker: 12.22.0
Auto-Submitted: auto-generated
Reply-To: Éric Vyncke <evyncke@cisco.com>
Message-ID: <172346251587.705582.14572748867968111953@dt-datatracker-6df4c9dcf5-t2x2k>
Date: Mon, 12 Aug 2024 04:35:15 -0700
X-W3C-Hub-Spam-Status: No, score=-3.9
X-W3C-Hub-Spam-Report: BAYES_00=-1.9, DMARC_PASS=-0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, W3C_AA=-1, W3C_WL=-1
X-W3C-Scan-Sig: puck.w3.org 1sdTKa-00Ah9C-19 e20a6e14d6ef50d0a373c9f5f98ec56a
X-Original-To: ietf-http-wg@w3.org
Subject: Éric Vyncke's No Objection on draft-ietf-httpbis-compression-dictionary-09: (with COMMENT)
Archived-At: <https://www.w3.org/mid/172346251587.705582.14572748867968111953@dt-datatracker-6df4c9dcf5-t2x2k>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/52196
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <https://www.w3.org/email/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

Éric Vyncke has entered the following ballot position for
draft-ietf-httpbis-compression-dictionary-09: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-httpbis-compression-dictionary/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------


# Éric Vyncke, INT AD, comments for draft-ietf-httpbis-compression-dictionary-09

Thank you for the work put into this document. Please note that I am outside my
area of expertise when reading this document.

Please find below some non-blocking COMMENT points (but replies would be
appreciated even if only for my own education), and some nits.

Special thanks to Mark Nottingham for the shepherd's detailed write-up
including the WG consensus and the justification of the intended status.

I hope that this review helps to improve the document,

Regards,

-éric

# COMMENTS (non-blocking)

## Introduction

Suggest adding some (graphical?) explanations on how the technique works. It
took me a while (admitting that I am not familiar with the domain) to
understand how the headers are used. In other words, it would be nice to
present the forest before describing the trees.

## Section 1

Is it "file" or "page/resource" in `Using a previous version of a file as a
dictionary for a newer version ` ?

## Section 2.1.3

It is unclear to me how `when the dictionary is advertised as being available`
can be verified by the client.

## Section 2.3

I have hard time to fit the example with `The "Dictionary-ID" request header
... MUST be identical to the server-provided "id".` as there is a prefix:
`/v1/main.js`. This is of course due to structured field, but it would be nice
to explain the structure of this field.

## Section 4

As draft-vandevenne-shared-brotli-format has expired for more than a year (and
not even WG adopted), I wonder whether this section is still useful ? I.e.,
just keep section 5 and remove section 4.

Is there a reason why the lengths of the magic number are different for the two
supported compressions ?

## Section 7.1

Suggest referring to the IANA registry by their URI (i.e.,
https://www.iana.org/assignments/http-parameters/http-parameters.xhtml#content-coding)
rather than by the RFC that has created them.

## Section 8

Should `middle-boxes` be more descriptive (e.g., web proxies, ...) ?

# NITS (non-blocking / cosmetic)

## Section 2.1.4

Suggest to use double quotes around raw in `and defaults to raw`.

## Section 4

s/fixed 4 byte sequence and a 32 byte hash/fixed 4-byte sequence and a 32-byte
hash/ ?

s/Bytes/bytes/ ?