Re: New Version Notification for draft-vkrasnov-h2-compression-dictionaries-01.txt

Martin Thomson <martin.thomson@gmail.com> Wed, 02 November 2016 03:19 UTC

Return-Path: <ietf-http-wg-request+bounce-httpbisa-archive-bis2juki=lists.ie@listhub.w3.org>
X-Original-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Delivered-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 98A4A1294F9 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 1 Nov 2016 20:19:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.998
X-Spam-Level:
X-Spam-Status: No, score=-7.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_SORBS_SPAM=0.5, RP_MATCHES_RCVD=-1.497, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dHg6Xe7btumE for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 1 Nov 2016 20:18:58 -0700 (PDT)
Received: from frink.w3.org (frink.w3.org [128.30.52.56]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B07561294FB for <httpbisa-archive-bis2Juki@lists.ietf.org>; Tue, 1 Nov 2016 20:18:58 -0700 (PDT)
Received: from lists by frink.w3.org with local (Exim 4.80) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1c1m0t-0003BW-Ky for ietf-http-wg-dist@listhub.w3.org; Wed, 02 Nov 2016 03:14:55 +0000
Resent-Date: Wed, 02 Nov 2016 03:14:55 +0000
Resent-Message-Id: <E1c1m0t-0003BW-Ky@frink.w3.org>
Received: from mimas.w3.org ([128.30.52.79]) by frink.w3.org with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <martin.thomson@gmail.com>) id 1c1m0o-0003Af-KS for ietf-http-wg@listhub.w3.org; Wed, 02 Nov 2016 03:14:50 +0000
Received: from mail-qt0-f176.google.com ([209.85.216.176]) by mimas.w3.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <martin.thomson@gmail.com>) id 1c1m0i-0006qj-8Z for ietf-http-wg@w3.org; Wed, 02 Nov 2016 03:14:45 +0000
Received: by mail-qt0-f176.google.com with SMTP id n6so1865430qtd.1 for <ietf-http-wg@w3.org>; Tue, 01 Nov 2016 20:14:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z2yIYMgw61AFuDk5iht6nur9sAinHdBije0e1hclVW8=; b=FwfLar9Wcemb29RjMUa8HOwEP8sq70K9y+ZUN3ek5EYJRXnywpDkxPJiVJG4UMSawm JcjgcCaq0ml61jSgBvzcxR0OsgRoSUsIDx8Ii7PlJXIBlFh03dVyZxZO3xDZjymnt07x M30FfspeVojLnXETS5nByglozwF7oavUM8KPPtWkiFYOBsExR4AGLqOG5VMnIgOdc6In sDaJqtSlMHWEmqLcHlfzvsd+IrkdPR3pe8cPxR1Zbk+HYZXAPB76uJqvmIUxfeijLOyn N3lqx2EoAsBL8Y2v7nltLQdXX3wW5W1d8V2ZKD0wGmYIZYvJHIkOM3g+RMK365Z3fCjI f/xg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z2yIYMgw61AFuDk5iht6nur9sAinHdBije0e1hclVW8=; b=ji9N42OFESb5wfW/kWt3J7CwrHSgMfcF1YzZP87SfTuDHDoYtQTD3RmsqfHi+ZjUDY DZWAy4vQ+gKyHgoPsiC9kMV1q/AuwtLn1GL8taEAZxSu/meDr6YvVZBupXqCdB7mMcXB 9EjfMQeMzf4i/wgEqRyMGkX0ps7B9dp3raiiJeoGueqOlC1NJA392RifvuNwoGuBeLrU GVGeoNoyAk2FuwVRXeHHjSG7ay/YMYuwKS2y4UvrOYR48L7ezxouAU4ozKrPWCyHI9JG mweZm7UxWdddwP+vmPnP5DSLWrvuctyZbL5NOnEui17C6tYR0XCiH0tvQ+ldaFibw1bg WmhA==
X-Gm-Message-State: ABUngvfLzrSve9auY/YU1cj0iQ2jhF6gkXIkt7FX96WWaNkF6ETbkVSCHaiaY4pboAxP4oqCcJAMeT04///9UA==
X-Received: by 10.200.36.125 with SMTP id d58mr1122116qtd.126.1478056458210; Tue, 01 Nov 2016 20:14:18 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.140.85.7 with HTTP; Tue, 1 Nov 2016 20:14:17 -0700 (PDT)
In-Reply-To: <3669167D-26AC-4B78-8175-99B0028B6891@cloudflare.com>
References: <147793576451.32369.14134057573457350871.idtracker@ietfa.amsl.com> <3669167D-26AC-4B78-8175-99B0028B6891@cloudflare.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Wed, 2 Nov 2016 14:14:17 +1100
Message-ID: <CABkgnnXqHP6RNpHBcFStO5TWz8Sq6Uqs7KMWFof88RjxhoW-Qg@mail.gmail.com>
To: Vlad Krasnov <vlad@cloudflare.com>
Cc: HTTP Working Group <ietf-http-wg@w3.org>
Content-Type: text/plain; charset=UTF-8
Received-SPF: pass client-ip=209.85.216.176; envelope-from=martin.thomson@gmail.com; helo=mail-qt0-f176.google.com
X-W3C-Hub-Spam-Status: No, score=-6.1
X-W3C-Hub-Spam-Report: AWL=0.097, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, W3C_AA=-1, W3C_DB=-1, W3C_IRA=-1, W3C_WL=-1
X-W3C-Scan-Sig: mimas.w3.org 1c1m0i-0006qj-8Z 9dbde8aa75c391354b4b095ca13a3e73
X-Original-To: ietf-http-wg@w3.org
Subject: Re: New Version Notification for draft-vkrasnov-h2-compression-dictionaries-01.txt
Archived-At: <http://www.w3.org/mid/CABkgnnXqHP6RNpHBcFStO5TWz8Sq6Uqs7KMWFof88RjxhoW-Qg@mail.gmail.com>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/32802
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <http://www.w3.org/Mail/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

I look forward to discussing this, particularly in comparison to SDCH.

A few comments from a brief skim:

MAJOR:

The document is really light on details regarding how to use a
dictionary.  I realize that this might /seem/ obvious, but it really
needs to explain how better (up front preferably) how it is intended
to work.  In particular, how do I tell what compression algorithm to
feed the dictionary into?  HTTP/2 doesn't know about compression, in
particular, HTTP/2 really *can't* use content-encoding.

minor stuff:

I see that you have settings for the number of dictionaries, and the
size of those dictionaries, this is good, but I think that you need to
set an overall limit instead of a per-dictionary limit
SETTINGS_MAX_DICTIONARY_SIZE (you get better efficiency that way).

I like the idea of static dictionaries, but your structure would force
an implementation to support ALL static dictionaries if they wanted to
support ANY dynamic dictionaries.  That might be inadvisable.  A
separate setting would be better I think.  (Static dictionaries could
start from the top of the numbering space, perhaps, so that you can
have many static dictionaries.)

The security considerations need a lot more detail about when it is
safe to use a compression dictionary, etc.

On 2 November 2016 at 07:34, Vlad Krasnov <vlad@cloudflare.com> wrote:
> Hi,
>
> Yesterday I posted a new version of my proposal that allows for cross-stream
> compression in HTTP/2.
>
> This allows for significant improvement in compression ratio for a variety
> of use cases, including server->client and origin->server, and works with
> both deflate and brotli.
>
> The main changes from the previous version include the option to concatenate
> dictionaries, and the use of static dictionaries, that improve compression
> ratio even for connections that serve only a single resource.
>
> Feedback is appreciated.
>
> Cheers,
> Vlad
>
> Begin forwarded message:
>
> From: internet-drafts@ietf.org
> Subject: New Version Notification for
> draft-vkrasnov-h2-compression-dictionaries-01.txt
> Date: 31 October 2016 at 10:42:44 GMT-7
> To: "Vlad Krasnov" <vlad@cloudflare.com>
>
>
> A new version of I-D, draft-vkrasnov-h2-compression-dictionaries-01.txt
> has been successfully submitted by Vlad Krasnov and posted to the
> IETF repository.
>
> Name: draft-vkrasnov-h2-compression-dictionaries
> Revision: 01
> Title: Compression Dictionaries for HTTP/2
> Document date: 2016-10-31
> Group: Individual Submission
> Pages: 7
> URL:
> https://www.ietf.org/internet-drafts/draft-vkrasnov-h2-compression-dictionaries-01.txt
> Status:
> https://datatracker.ietf.org/doc/draft-vkrasnov-h2-compression-dictionaries/
> Htmlized:
> https://tools.ietf.org/html/draft-vkrasnov-h2-compression-dictionaries-01
> Diff:
> https://www.ietf.org/rfcdiff?url2=draft-vkrasnov-h2-compression-dictionaries-01
>
> Abstract:
>   This document specifies a new HTTP/2 frame type and new HTTP/2
>   settings values that would enable the use of previously transferred
>   data as compression dictionaries, significantly improving overall
>   compression ratio for a given connection.
>
>   In addition, this document proposes to define a set of industry
>   standard, static, dictionaries to be used with any Lempel-Ziv based
>   compression for the common textual MIME types prevalent on the web.
>
>
>
>
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> The IETF Secretariat
>
>