Genart last call review of draft-ietf-httpbis-compression-dictionary-08
Reese Enghardt via Datatracker <noreply@ietf.org> Mon, 05 August 2024 16:25 UTC
Received: by ietfa.amsl.com (Postfix) id 05CCCC18DB89; Mon, 5 Aug 2024 09:25:00 -0700 (PDT)
Delivered-To: ietfarch-httpbisa-archive-bis2juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 03D2AC18DBBA for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Mon, 5 Aug 2024 09:25:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.757
X-Spam-Level:
X-Spam-Status: No, score=-2.757 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, MAILING_LIST_MULTI=-1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=w3.org header.b="UWjanIaA"; dkim=pass (2048-bit key) header.d=w3.org header.b="DDr8SnvW"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fi0t9VDxhyYM for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Mon, 5 Aug 2024 09:24:56 -0700 (PDT)
Received: from mab.w3.org (mab.w3.org [IPv6:2600:1f18:7d7a:2700:d091:4b25:8566:8113]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C3F1C18DB89 for <httpbisa-archive-bis2Juki@ietf.org>; Mon, 5 Aug 2024 09:24:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=w3.org; s=s1; h=Subject:Date:Reply-To:Message-ID:Cc:To:From:Content-Type:MIME-Version :In-Reply-To:References; bh=zdsHo6HWPV6WisIHRKffMnfEgHw7CO2jfKSz3NcFeIw=; b=U WjanIaAAEn4V2DDWsLDcSN6vxdgzQs/R82PCGiY3Ypg0+nhMir0g1/GUXs9O09LRdT0m5iUT9Aex2 ENDZ0bYzCTU3jLxLLBko4PsO2HeYcpQce2PovPuQblcMDFt5TyZx0GgUex1MaGRFeUuxLYp2r2l35 vH/eySXsx5g0z1LdM76zERiH0H2pI7Y+vQ/NolfxSFJMmIDba58wa/HW6BgdtwAuHsQ/bxU2liZDb 8xuhH7nD3x2fFuBOfFSqNPv7RSUSrs1jfTrEKYqANaQqzHuWwAhv4GXiwO3pA+CsXYTTLROGAQPDa kdqUUOxKFU2kPm+T1zfhHVADNIQbELyuQ==;
Received: from lists by mab.w3.org with local (Exim 4.96) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1sb0V0-000KXH-2d for ietf-http-wg-dist@listhub.w3.org; Mon, 05 Aug 2024 16:23:54 +0000
Resent-Date: Mon, 05 Aug 2024 16:23:54 +0000
Resent-Message-Id: <E1sb0V0-000KXH-2d@mab.w3.org>
Received: from ip-10-0-0-224.ec2.internal ([10.0.0.224] helo=puck.w3.org) by mab.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <noreply@ietf.org>) id 1sb0Uz-000KWM-1Q for ietf-http-wg@listhub.w3.internal; Mon, 05 Aug 2024 16:23:53 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=w3.org; s=s1; h=Date:Reply-To:Message-ID:Subject:Cc:To:From:Content-Type:MIME-Version :In-Reply-To:References; bh=zdsHo6HWPV6WisIHRKffMnfEgHw7CO2jfKSz3NcFeIw=; t=1722875033; x=1723739033; b=DDr8SnvWaJWdE12L9o5N8Us5XsCinIpo/3BcXA837qhTlLg bhnr6X3iklsuHkg8TjceJrK2rw//vIfCjMyBFQClHZInWw/7bRpnNXGF1hf9hc8atoX9ui+uIJ4qP 1FB7+iEGQRrrX8WqDBhrfLuqtZ/O4VlGlPF25lqfZ+7lT2Ic9C4l0KaUTVKWkGHJMf319tDRng+nZ 4a+qjjiIL2zfvbeoH+jadE+d70aq1PIIZOMvKYiQE4+azCrW40gZdy7fpR2w/LxczahPhsp8SHbZ2 +tK2H5MBaE7qhstVmv1JcQLC+4hjtLsb8ZgXsHMbU5EqsCISmcmb26R1sgC7/cgg==;
Received-SPF: pass (puck.w3.org: domain of ietf.org designates 50.223.129.194 as permitted sender) client-ip=50.223.129.194; envelope-from=noreply@ietf.org; helo=mail.ietf.org;
Received: from mail.ietf.org ([50.223.129.194]) by puck.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <noreply@ietf.org>) id 1sb0Uy-008Lnh-1t for ietf-http-wg@w3.org; Mon, 05 Aug 2024 16:23:53 +0000
Received: from [10.244.2.66] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id 6FCF6C18DBBF; Mon, 5 Aug 2024 09:23:48 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Reese Enghardt via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-httpbis-compression-dictionary.all@ietf.org, ietf-http-wg@w3.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.21.0
Auto-Submitted: auto-generated
Message-ID: <172287502811.658486.5801714086488550365@dt-datatracker-6dd76c4557-2mkrj>
Reply-To: Reese Enghardt <ietf@tenghardt.net>
Date: Mon, 05 Aug 2024 09:23:48 -0700
X-W3C-Hub-Spam-Status: No, score=-3.9
X-W3C-Hub-Spam-Report: BAYES_00=-1.9, DMARC_PASS=-0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, W3C_AA=-1, W3C_WL=-1
X-W3C-Scan-Sig: puck.w3.org 1sb0Uy-008Lnh-1t 9a699720e0e4b8523b76be48e47795cc
X-Original-To: ietf-http-wg@w3.org
Subject: Genart last call review of draft-ietf-httpbis-compression-dictionary-08
Archived-At: <https://www.w3.org/mid/172287502811.658486.5801714086488550365@dt-datatracker-6dd76c4557-2mkrj>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/52189
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <https://www.w3.org/email/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>
Reviewer: Reese Enghardt Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-httpbis-compression-dictionary-08 Reviewer: Reese Enghardt Review Date: 2024-08-05 IETF LC End Date: 2024-08-06 IESG Telechat date: Not scheduled for a telechat Summary: The document is concise and to the point. I just have a few suggestions for clarifications. Major issues: None. Minor issues: Section 1: What is the motivation for this work? Increased efficiency relative to other compression schemas, or is there more to it? Please consider adding a sentence or two. What versions of HTTP does this document apply to? I might have missed something that makes it so that a statement of versioning is not needed. But otherwise, please consider adding a statement about this. Section 2.1.1: "The following algorithm will return TRUE for a valid match pattern and FALSE for an invalid pattern that MUST NOT be used" Please consider adding one sentence of motivation or clarification for the algorithm - IIUC it enforces the Same Origin Policy. I think explaining this motivation briefly here would make the algorithm easier to follow. Section 2.1.5.2: "Would match main.js in any directory under /app/ and expiring as a dictionary in one year." This is the first time the document mentions expiration as a concept. How is expiration specified in this example - I don't see it specified explicitly, so is one year the default? Please consider adding a clarification. Nits/editorial comments: None.
- Re: Genart last call review of draft-ietf-httpbis… Patrick Meenan
- Genart last call review of draft-ietf-httpbis-com… Reese Enghardt via Datatracker