Re: Design Issue: Merge RST_STREAM and GOAWAY into a single ERROR frame type

Roberto Peon <grmocg@gmail.com> Fri, 03 May 2013 21:27 UTC

Return-Path: <ietf-http-wg-request@listhub.w3.org>
X-Original-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Delivered-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E408321F8AF8 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Fri, 3 May 2013 14:27:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.773
X-Spam-Level:
X-Spam-Status: No, score=-9.773 tagged_above=-999 required=5 tests=[AWL=0.525, BAYES_00=-2.599, HTML_MESSAGE=0.001, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r5MzipCYReZ1 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Fri, 3 May 2013 14:27:10 -0700 (PDT)
Received: from frink.w3.org (frink.w3.org [128.30.52.56]) by ietfa.amsl.com (Postfix) with ESMTP id 7AE1121F8763 for <httpbisa-archive-bis2Juki@lists.ietf.org>; Fri, 3 May 2013 14:27:10 -0700 (PDT)
Received: from lists by frink.w3.org with local (Exim 4.72) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1UYNUx-0000MF-AB for ietf-http-wg-dist@listhub.w3.org; Fri, 03 May 2013 21:26:35 +0000
Resent-Date: Fri, 03 May 2013 21:26:35 +0000
Resent-Message-Id: <E1UYNUx-0000MF-AB@frink.w3.org>
Received: from maggie.w3.org ([128.30.52.39]) by frink.w3.org with esmtp (Exim 4.72) (envelope-from <grmocg@gmail.com>) id 1UYNUn-0000Kp-F8 for ietf-http-wg@listhub.w3.org; Fri, 03 May 2013 21:26:25 +0000
Received: from mail-ob0-f175.google.com ([209.85.214.175]) by maggie.w3.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.72) (envelope-from <grmocg@gmail.com>) id 1UYNUm-0003Ba-I3 for ietf-http-wg@w3.org; Fri, 03 May 2013 21:26:25 +0000
Received: by mail-ob0-f175.google.com with SMTP id wd20so664239obb.6 for <ietf-http-wg@w3.org>; Fri, 03 May 2013 14:25:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=MIYjr2bLMiyuwelxjOTlBYEJXGYo/gzwpX+95DIoV/o=; b=CYQYcyTZhUnxDB4XuTSRk76lJjDkDTUto83EQk717eC+23uDGfDvLodse5qIMYXf2k mDhVl/mcerH4e4/qMvLmFeVoKDbqRLT7n6YemdyJolAzVPKe9Q4H9VOqZSAiCcXQWsli JwRJTQC2lQrjHqcZ2FC0wcZsbkGgjvB8rJMDFaCUzxXjBTfdGQBBiCGM0pu31KPfMX7V NmP5A3j9F4sxUOpu6XC9GF/QbUj9NqxJK9lsQk+SXc5yuX4FWEzgG5xntfrZ81MTb583 y3F2uUN4DUP8RF4Mm2somdtUmhKBpifqSFOK4UhSCbC/pMmQ5ZnxqOorOjqbVfcWee3e AXgQ==
MIME-Version: 1.0
X-Received: by 10.182.105.7 with SMTP id gi7mr3451839obb.10.1367616358601; Fri, 03 May 2013 14:25:58 -0700 (PDT)
Received: by 10.76.130.139 with HTTP; Fri, 3 May 2013 14:25:58 -0700 (PDT)
In-Reply-To: <CAA4WUYgYQbD1PmNMqPiQqR++0M7_vf4cWECNxk_i+s9S_kpQKw@mail.gmail.com>
References: <CABP7RbeJm-AKxU3qGxt2tCGrb0xCQL8njNyEToA7Ln9gS8hnTQ@mail.gmail.com> <CA+pLO_gWErCMv+j3pcmy+cTkt-hh2v6a7neeyDtg7HRN3x=Sgw@mail.gmail.com> <CABP7RbfJEwkMVum0HXei_mqvJ=pHd2G=jx_wz=sZzboi4ZMwzQ@mail.gmail.com> <CAA4WUYhfup_PM8s7P0PO_EcB8R-O6L32wX-zk73thwBHYHHtgA@mail.gmail.com> <CABP7RbcTbFxNj-qax1An0Qp7okWqvbt5MTXyHZTMn_fBKgx9Fw@mail.gmail.com> <CAA4WUYgYQbD1PmNMqPiQqR++0M7_vf4cWECNxk_i+s9S_kpQKw@mail.gmail.com>
Date: Fri, 3 May 2013 14:25:58 -0700
Message-ID: <CAP+FsNcN4OyqP=WkmsYUG+m9EHrTuELHx40n7S6wRb6F7L73FQ@mail.gmail.com>
From: Roberto Peon <grmocg@gmail.com>
To: =?UTF-8?B?V2lsbGlhbSBDaGFuICjpmYjmmbrmmIwp?= <willchan@chromium.org>
Cc: James M Snell <jasnell@gmail.com>, Jeff Pinner <jpinner@twitter.com>, "ietf-http-wg@w3.org" <ietf-http-wg@w3.org>
Content-Type: multipart/alternative; boundary=e89a8ff1cdee3e5c0104dbd6ff49
Received-SPF: pass client-ip=209.85.214.175; envelope-from=grmocg@gmail.com; helo=mail-ob0-f175.google.com
X-W3C-Hub-Spam-Status: No, score=-3.5
X-W3C-Hub-Spam-Report: AWL=-2.674, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001
X-W3C-Scan-Sig: maggie.w3.org 1UYNUm-0003Ba-I3 42e4d45d8dc8c0fb431577e194403abd
X-Original-To: ietf-http-wg@w3.org
Subject: Re: Design Issue: Merge RST_STREAM and GOAWAY into a single ERROR frame type
Archived-At: <http://www.w3.org/mid/CAP+FsNcN4OyqP=WkmsYUG+m9EHrTuELHx40n7S6wRb6F7L73FQ@mail.gmail.com>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/17819
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <http://www.w3.org/Mail/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

I also find the current way more obvious-- in wireshark and similar traces,
it is far easier to pick out the different opcode type (which is typically
rendered as the textual name of the opcode) as opposed to the numeric value
in some field.

-=R


On Fri, May 3, 2013 at 2:12 PM, William Chan (陈智昌) <willchan@chromium.org>wrote:

> Sorry, my implication is that I don't see any objective determination of
> what's simpler here, just subjective views of which many people can have an
> opinion. But if there's consensus on doing this, then by all means, let's
> do it. I for one disagree and find the current way simpler :)
>
>
> On Fri, May 3, 2013 at 6:08 PM, James M Snell <jasnell@gmail.com>; wrote:
>
>> There is no bikeshedding going on at all. I made the motivation for
>> this clear up front: it's a simplification that addresses three
>> specific items. Note: there is an existing editorial note in the
>> existing draft that calls out the fact that we have no non-terminal
>> method of communicating non-stream related errors. If we can address
>> that item while also simplifying things a bit, then fantastic.
>>
>> On Fri, May 3, 2013 at 2:01 PM, William Chan (陈智昌)
>> <willchan@chromium.org>; wrote:
>> > This is a thread ripe for bikeshedding. Is there any major issue worth
>> > solving?
>> >
>> > If we're going to paint our bike sheds, my take is keep whatever color
>> the
>> > bike shed already has unless it really offends a number of people.
>> >
>> >
>> > On Fri, May 3, 2013 at 5:53 PM, James M Snell <jasnell@gmail.com>;
>> wrote:
>> >>
>> >> Speaking candidly, if we find ourselves requiring more than 8 boolean
>> >> flags on an error frame we should all just quit and go home.
>> >>
>> >> On Fri, May 3, 2013 at 1:34 PM, Jeff Pinner <jpinner@twitter.com>;
>> wrote:
>> >> > IIRC, when this was brought up at the last F2F the rational for NOT
>> >> > doing
>> >> > this was that frame types were cheaper than flags (256 frame types, 8
>> >> > flags).
>> >> >
>> >> > That being said I think we should consider combining them :)
>> >> >
>> >> >
>> >> > On Fri, May 3, 2013 at 1:04 PM, James M Snell <jasnell@gmail.com>;
>> wrote:
>> >> >>
>> >> >> As a simplification, I'd like to suggest that we merge the
>> RST_STREAM
>> >> >> and GOAWAY frames into a single ERROR frame with the following
>> >> >> definition:
>> >> >>
>> >> >>  0                   1                   2                   3
>> >> >>  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>> >> >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>> >> >> |                      Error Code (32)                          |
>> >> >> +---------------------------------------------------------------+
>> >> >> |X|                  Last-Stream-ID (31)                        |
>> >> >> +-+-------------------------------------------------------------+
>> >> >>
>> >> >> (note that this flips the field order from the GOAWAY frame)
>> >> >>
>> >> >> A frame-specific GOAWAY flag bit (0x2) would be defined for the
>> frame,
>> >> >> and the Last-Stream-ID field would only be included in the frame
>> data
>> >> >> if this flag was set.
>> >> >>
>> >> >> This does a couple of things for us:
>> >> >>
>> >> >> 1. It simplifies the error handling and reduces the number of core
>> >> >> frame
>> >> >> types.
>> >> >> 2. It allows us to terminate a stream and terminate the session in a
>> >> >> single frame if necessary
>> >> >> 3. It gives us a way of reporting non-terminal session errors
>> >> >> (currently RST_STREAM is forbidden to use stream id #0 and GOAWAY is
>> >> >> always terminal).
>> >> >>
>> >> >
>> >>
>> >
>>
>
>