Re: AD review of draft-ietf-httpbis-zstd-window-size-01

Nidhi Jaju <nidhijaju@google.com> Tue, 23 July 2024 08:09 UTC

Received: by ietfa.amsl.com (Postfix) id 86AF0C1EBF54; Tue, 23 Jul 2024 01:09:05 -0700 (PDT)
Delivered-To: ietfarch-httpbisa-archive-bis2juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 85E46C207966 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 23 Jul 2024 01:09:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.357
X-Spam-Level:
X-Spam-Status: No, score=-10.357 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=w3.org header.b="WItdE2VF"; dkim=pass (2048-bit key) header.d=w3.org header.b="Gykuiu37"; dkim=pass (2048-bit key) header.d=google.com header.b="kAJrs58g"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D6VU5yKhVDrK for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 23 Jul 2024 01:09:01 -0700 (PDT)
Received: from mab.w3.org (mab.w3.org [IPv6:2600:1f18:7d7a:2700:d091:4b25:8566:8113]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6CEA7C1F7D97 for <httpbisa-archive-bis2Juki@ietf.org>; Tue, 23 Jul 2024 01:09:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=w3.org; s=s1; h=Subject:Content-Type:Cc:To:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To; bh=w84f3XojS9G/QtxYbWJZxXuIs82cvL1vWm8TMyWSjSE=; b=WItdE2VF4JzoTJyTbIV+PDKNqv TStmr6InxpS8U48O1liuNhMyOW4pEnIvEkAtVScJjV9GH1B3Ub7YDCpifFdJQ29hPFskC8IsjCHeg sILTdYcWnaac9eB2+slU1fDtXjmXKBmm/1shN9Z3L354/qmaHEV1Xo+9M76SNcu8Fph8qfF2D+Pka 0WUDKpkCpfeGv/T2xPE8wBhrUuMY29/d89Wuhi2m5qMFMuyLpE+0UtiDiIJ7XOERZ4racWseit1yU S03kpzcZEwN6lGemJvJQjPZL6uPtTaboAOvQbqcLoB+SkYIgTV2Nyd+h2sHqs0rmSBV4sEuDy6DSZ aVv3CJIA==;
Received: from lists by mab.w3.org with local (Exim 4.96) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1sWAZH-0011aM-2v for ietf-http-wg-dist@listhub.w3.org; Tue, 23 Jul 2024 08:08:19 +0000
Resent-Date: Tue, 23 Jul 2024 08:08:19 +0000
Resent-Message-Id: <E1sWAZH-0011aM-2v@mab.w3.org>
Received: from ip-10-0-0-144.ec2.internal ([10.0.0.144] helo=pan.w3.org) by mab.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <nidhijaju@google.com>) id 1sWAZG-0011ZT-22 for ietf-http-wg@listhub.w3.internal; Tue, 23 Jul 2024 08:08:18 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=w3.org; s=s1; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To; bh=w84f3XojS9G/QtxYbWJZxXuIs82cvL1vWm8TMyWSjSE=; t=1721722098; x=1722586098; b=Gykuiu37lCJZ3m/hXDJN2384SbIgPTV/gvjLDc94z5z/tfY62YRrFVCDgA3HgIG9e7h7bA4Fi0k vjdBnl/nwRCQ9/bmfA9hZtHJI5bJkkyzI3gvRQ9tGPxbc3b1JxFQECbPRTbt+/TgiM0vKdFzIbsqP HU6SjHkLLlkvBW46wxiW5rCicYOoum93gCX1KpOBr19KFlAXteQNFEotyOQnwcjEN92x7uhFKtHB9 Q0ja4haR76NGzy5JzLX+8V/k4mjpEV2bu6je3KB4DyCroErAeX4o2T4QP+YuGI6EEOUSn7I8F0lGK Ajv6WPjeer11Ep1CG9dmNTqZJlDKK1aqhHIg==;
Received-SPF: pass (pan.w3.org: domain of google.com designates 2a00:1450:4864:20::529 as permitted sender) client-ip=2a00:1450:4864:20::529; envelope-from=nidhijaju@google.com; helo=mail-ed1-x529.google.com;
Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by pan.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from <nidhijaju@google.com>) id 1sWAZF-00BsOk-2t for ietf-http-wg@w3.org; Tue, 23 Jul 2024 08:08:18 +0000
Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5a18a5dbb23so9001a12.1 for <ietf-http-wg@w3.org>; Tue, 23 Jul 2024 01:08:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721722094; x=1722326894; darn=w3.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=w84f3XojS9G/QtxYbWJZxXuIs82cvL1vWm8TMyWSjSE=; b=kAJrs58gT1aPw4UcoalukR2vnmqKtR3KBQHQ4uRXRycyRktnjxeqS8V4Vl6U6+K4/S ouOEMLj0x27/+j6m0Mh7lgKV37HLF+kl5KJofrYKNLY/xoZLrTJqrybPON/GnFg/LHDW r4TmB/AxHwW7Ogvpe9ik+sJuNP/91x36aZX+J8tz8cJfif2iIv8Taw4WetrS1nGmqBpV y0lPkGDDsmQXheJP2k9FC7sPKFJcqPPUekxmg8bjyydzgsTlEBv4H2gXj/ilP8F84qJu 2unOmT+ADGiqBb92v/qrLWzJiWa1Wbwd9ecbHTxDH/sBYr3ZLkJJtTJnZRDcpyuITiBs k3Yw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721722094; x=1722326894; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w84f3XojS9G/QtxYbWJZxXuIs82cvL1vWm8TMyWSjSE=; b=MGoRc/D1RWj/8XPE3n2DCJt5rKFjp64zlSacM4AM8pcjvFRwIPrA/HGXzbiZ+9k3Oc UBDhKx6eCr4ZZmMQQuyS5QzaE7gafbU82P67sOsMmDYOByLAXnv7+bx9cvS8JQT5sQRg tV3b379DdYn22e4vB2e3pzqgMkXrM57ICgFrp/CGddsfTbRsWHC1Y50Ro5ViF/ScUKvj zEdVRqBqJ13wysJBnHSET4cxBHu2K7SwBKSBphgjsbArnw9GgiE9nxQ0AzOwMHW34sbi 7HcPda3IrscmIHCdgDJv+Ty5yig4OOjJPkIMBH6SqNKnVErcs91WH4/ehPqJeoF2ZStj 39yg==
X-Forwarded-Encrypted: i=1; AJvYcCWqo9m6KBjwH5wYaafEKve55cq8tOCtLhTRS/4zYi1+CjSf0cSRlnCe0wUfbRfF5gXyYsPP+XtyPSjooqXC+VakcNo1
X-Gm-Message-State: AOJu0YzByTwwTCGSydxtMX3UBpDMmxVolSdXXlkhreoIHxrGJHgc90DI mYW/B8G4umwZBKLKPYNBIZ8g8391dvveJMsi3iRynTw7i6u4rTPe7kEToYXq+z9Ry1A8o7YaqzQ hVCVNrEhbC2g2Lkiq4nJTpBAL2KDoJkIUrM1B
X-Google-Smtp-Source: AGHT+IFiVcQOihFZ9F3gDtgDtYHEquUDc6E3Dk4zQyCBiQ9Jhomi217OoatQcNpPkN00haZ6FaPMx/7BFPxTLRGp5cE=
X-Received: by 2002:a05:6402:5246:b0:5a0:d4ce:59a6 with SMTP id 4fb4d7f45d1cf-5a4538c2a40mr543579a12.2.1721722093471; Tue, 23 Jul 2024 01:08:13 -0700 (PDT)
MIME-Version: 1.0
References: <PAXPR07MB7838A1DFCA7D57389A0B714498A82@PAXPR07MB7838.eurprd07.prod.outlook.com>
In-Reply-To: <PAXPR07MB7838A1DFCA7D57389A0B714498A82@PAXPR07MB7838.eurprd07.prod.outlook.com>
From: Nidhi Jaju <nidhijaju@google.com>
Date: Tue, 23 Jul 2024 17:08:01 +0900
Message-ID: <CAHARgnKYMkV-63wyN93q9ikvbYYK2jhyf4qbRXrp_4WwbBqjdA@mail.gmail.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>
Cc: "draft-ietf-httpbis-zstd-window-size@ietf.org" <draft-ietf-httpbis-zstd-window-size@ietf.org>, HTTP Working Group <ietf-http-wg@w3.org>
Content-Type: multipart/alternative; boundary="000000000000c97fc7061de5a997"
X-W3C-Hub-DKIM-Status: validation passed: (address=nidhijaju@google.com domain=google.com), signature is good
X-W3C-Hub-Spam-Status: No, score=-21.6
X-W3C-Hub-Spam-Report: BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, DMARC_PASS=-0.001, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5, W3C_AA=-1, W3C_DB=-1, W3C_IRA=-1, W3C_WL=-1
X-W3C-Scan-Sig: pan.w3.org 1sWAZF-00BsOk-2t 97d4f156fe84d267409b8827725e8137
X-Original-To: ietf-http-wg@w3.org
Subject: Re: AD review of draft-ietf-httpbis-zstd-window-size-01
Archived-At: <https://www.w3.org/mid/CAHARgnKYMkV-63wyN93q9ikvbYYK2jhyf4qbRXrp_4WwbBqjdA@mail.gmail.com>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/52101
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <https://www.w3.org/email/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

Thank you for the quick review!

I filed an issue with your feedback at
https://github.com/httpwg/http-extensions/issues/2838 and replied with the
following:

> I see that this document updates the IANA “HTTP Content Coding Registry”
> registration to reference this doc instead of 8878. I think it should
> actually reference both.


Although I'm open to adding a reference to RFC 8878 as well, I'm just
wondering if referencing both docs would confuse people since we want to
make sure that they see the size restriction before using the token.

Additionally, has the wg considered updating the media type registration
> made in
> https://www.rfc-editor.org/rfc/rfc8878#name-the-application-zstd-media-
> for consistency? I am ok with not updating it, as the link is also done via
> the document, but just checking for consistency.


This doc is specifically for HTTP Content Coding use cases so IIUC we don't
really want to restrict the media type itself. Applications are free to
transfer zstd archives that used any window size around as files, but we
just don't want to require HTTP clients/servers to (de)compress with window
sizes above 8 MB.

Thanks,
Nidhi

On Tue, Jul 23, 2024 at 7:30 AM Francesca Palombini <
francesca.palombini@ericsson.com> wrote:

> # AD Review of draft-ietf-httpbis-zstd-window-size-01
>
>
>
> cc @fpalombini
>
>
>
> Thank you for this document, short and to the point. I only have one
> comment/question, before initiating the IETF last call.
>
>
>
> Francesca
>
>
>
> ## Comments
>
>
>
> ### Reference in IANA registries
>
>
>
> I see that this document updates the IANA “HTTP Content Coding Registry”
> registration to reference this doc instead of 8878. I think it should
> actually reference both.
>
>
>
> Additionally, has the wg considered updating the media type registration
> made in
> https://www.rfc-editor.org/rfc/rfc8878#name-the-application-zstd-media-
> for consistency? I am ok with not updating it, as the link is also done via
> the document, but just checking for consistency.
>
>
>
> ## Notes
>
>
>
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use
> the
>
> [`ietf-comments` tool][ICT] to automatically convert this review into
>
> individual GitHub issues.
>
>
>
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
>
> [ICT]: https://github.com/mnot/ietf-comments
>