Re: AD Review of draft-ietf-httpbis-binary-message-03

Martin Thomson <mt@lowentropy.net> Mon, 23 May 2022 01:28 UTC

Return-Path: <ietf-http-wg-request+bounce-httpbisa-archive-bis2juki=lists.ie@listhub.w3.org>
X-Original-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Delivered-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1A796C074AD2 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Sun, 22 May 2022 18:28:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.751
X-Spam-Level:
X-Spam-Status: No, score=-2.751 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b=TRfRbfcM; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=mwt80Y/r
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U7qAkUuBMEhL for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Sun, 22 May 2022 18:28:25 -0700 (PDT)
Received: from lyra.w3.org (lyra.w3.org [128.30.52.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B3F01C074AD7 for <httpbisa-archive-bis2Juki@lists.ietf.org>; Sun, 22 May 2022 18:28:25 -0700 (PDT)
Received: from lists by lyra.w3.org with local (Exim 4.92) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1nswph-0006bq-7O for ietf-http-wg-dist@listhub.w3.org; Mon, 23 May 2022 01:26:05 +0000
Resent-Date: Mon, 23 May 2022 01:26:05 +0000
Resent-Message-Id: <E1nswph-0006bq-7O@lyra.w3.org>
Received: from mimas.w3.org ([128.30.52.79]) by lyra.w3.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <mt@lowentropy.net>) id 1nswnl-0006Zl-7a for ietf-http-wg@listhub.w3.org; Mon, 23 May 2022 01:24:05 +0000
Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by mimas.w3.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <mt@lowentropy.net>) id 1nswnj-0002RM-S3 for ietf-http-wg@w3.org; Mon, 23 May 2022 01:24:05 +0000
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3A87B5C00AD; Sun, 22 May 2022 21:23:53 -0400 (EDT)
Received: from imap41 ([10.202.2.91]) by compute3.internal (MEProxy); Sun, 22 May 2022 21:23:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1653269033; x=1653355433; bh=cGiUx5yspt LlpS2z5ZYdJyf07n5qDxYwK590w72AAIY=; b=TRfRbfcMREH9kCYe5+1ueS0gWq UZb1P3R7YgcttAojeFCDF+YEQk43PwUg/sVROl9ZcQhfcS1VI+o/BUMpubw/JJTr 6KdE3nOcUYcSnAJElgpeomrDWd6HUIW2bDkAMpmqQ5fllgHMxiEY3siz8Qf+9OZP TCk3+CeU1rz6uvoV+ei2jwpaeIDKMA25aXFe4kkXNJL8FRMRMaWpu0eRhYMg62/E 8KrOZ64JP0ZpAEhHc6bVc+Jg3pAbICG1BYLDlqrhfktfuWZ+sciQyp7dyYJFdmZ5 nAOFdSilsgEL1IdVpLN/N/dWRh/ztMUPd4+rONUVY9Lh+sTA1T3rDoQdEmhQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653269033; x=1653355433; bh=cGiUx5ysptLlpS2z5ZYdJyf07n5q DxYwK590w72AAIY=; b=mwt80Y/rZk8pBDgij7nKhJG7OmB0IckjD2IOrlF2iT0V wj2QpyMKEDqc4QGzdUv3fds5w1asEKa23BAAkpxah8MyQQLrzfTayKCLhWsIQHVb LN+O89WWs17k1AdanBt4/r10/GxDFj8MdufhpqgLY+eT6lToQwkM0G8Ojt8XUltc R/2liGjJuqLDdGBoCLkkAZv69ZrjTfulIzO6irGrRWMMmOPmiB9ocb9W6+FpA4fE K3sTrJkrD7H5sGoGILGzLJ1hX5CeviSs9clpK55WoSLjxu3MujLxRjqGOb/A8/hC gUraBkfpP8co8Aj7bP6S5HtXQLenOimyRtOQUImZZg==
X-ME-Sender: <xms:KOKKYseXlgA9JlPi8OxEmzspMU9ihdE_8KkuCgXuO9QKFpHHo3qVRQ> <xme:KOKKYuOF5VF_E1RbTFxqtgtU761zm54Df80nye2CpvxCZqm9MElcTXSIjferiCOPj QOUG23slSPYYDX7l3o>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieelgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfofgrrhht ihhnucfvhhhomhhsohhnfdcuoehmtheslhhofigvnhhtrhhophihrdhnvghtqeenucggtf frrghtthgvrhhnpefggfefhedtteekuddutedtuddvleeftddugfejleekteelueeuudeu ueejjeeigfenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhfohhrmhgrthdrmhgune cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhtsehl ohifvghnthhrohhphidrnhgvth
X-ME-Proxy: <xmx:KeKKYthLqFPB4qiswO_2vR7yd-ID8Co8GSFKn2jwF6mZVkX5lSbyHg> <xmx:KeKKYh_Hz1Kea2fWxK0fRiCxcnFXGruCH6gMkzvNOMslfBDJ-sLi3w> <xmx:KeKKYotmNZ6IiAZy9Nfew445hAU-KQZ1R1KxnpgaMp6VrT5pMZN8Fw> <xmx:KeKKYu0LUpYTWlhXVQw5_2ss0DnobbJ4pnjo5Zc02S6PkFtngXPtpg>
Feedback-ID: ic129442d:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501) id E891F2340073; Sun, 22 May 2022 21:23:52 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.7.0-alpha0-591-gfe6c3a2700-fm-20220427.001-gfe6c3a27
Mime-Version: 1.0
Message-Id: <556ef672-99d1-483e-948f-a1fcf5ece1c9@beta.fastmail.com>
In-Reply-To: <AS1PR07MB8616B881EBBD2E5DFCC414BA98D39@AS1PR07MB8616.eurprd07.prod.outlook.com>
References: <AS1PR07MB8616B881EBBD2E5DFCC414BA98D39@AS1PR07MB8616.eurprd07.prod.outlook.com>
Date: Mon, 23 May 2022 11:23:34 +1000
From: Martin Thomson <mt@lowentropy.net>
To: Francesca Palombini <francesca.palombini@ericsson.com>, "draft-ietf-httpbis-binary-message@ietf.org" <draft-ietf-httpbis-binary-message@ietf.org>, HTTP Working Group <ietf-http-wg@w3.org>
Content-Type: text/plain
Received-SPF: pass client-ip=66.111.4.26; envelope-from=mt@lowentropy.net; helo=out2-smtp.messagingengine.com
X-W3C-Hub-DKIM-Status: validation passed: (address=mt@lowentropy.net domain=lowentropy.net), signature is good
X-W3C-Hub-DKIM-Status: validation passed: (address=mt@lowentropy.net domain=messagingengine.com), signature is good
X-W3C-Hub-Spam-Status: No, score=-6.8
X-W3C-Hub-Spam-Report: BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, W3C_AA=-1, W3C_DB=-1, W3C_IRA=-1, W3C_WL=-1
X-W3C-Scan-Sig: mimas.w3.org 1nswnj-0002RM-S3 b57965da3fc428b595a5ad3bf3281836
X-Original-To: ietf-http-wg@w3.org
Subject: Re: AD Review of draft-ietf-httpbis-binary-message-03
Archived-At: <https://www.w3.org/mid/556ef672-99d1-483e-948f-a1fcf5ece1c9@beta.fastmail.com>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/40033
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <https://www.w3.org/Mail/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

Thanks for the review Francesca.

Mark helpfully generated issues for this, but most of these are so trivial (and easy to act upon, which is very much appreciated) that I just fixed them in a single pull request:

https://github.com/httpwg/http-extensions/pull/2124

I've separated out the question about final and information responses into a separate pull request as that required writing a sentence:

https://github.com/httpwg/http-extensions/pull/2125

On Sat, May 21, 2022, at 00:44, Francesca Palombini wrote:
> ## Notes
> 
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues.
> 
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments