Artart last call review of draft-ietf-httpbis-origin-h3-03

Henry Thompson via Datatracker <noreply@ietf.org> Tue, 28 February 2023 16:40 UTC

Return-Path: <ietf-http-wg-request+bounce-httpbisa-archive-bis2juki=lists.ie@listhub.w3.org>
X-Original-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Delivered-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C71C2C14CF0C for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 28 Feb 2023 08:40:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.949
X-Spam-Level:
X-Spam-Status: No, score=-4.949 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2_JI5yuwJ7Al for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 28 Feb 2023 08:40:53 -0800 (PST)
Received: from lyra.w3.org (lyra.w3.org [128.30.52.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 70D3DC14CE2E for <httpbisa-archive-bis2Juki@lists.ietf.org>; Tue, 28 Feb 2023 08:40:51 -0800 (PST)
Received: from lists by lyra.w3.org with local (Exim 4.94.2) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1pX30O-0046bn-7M for ietf-http-wg-dist@listhub.w3.org; Tue, 28 Feb 2023 16:39:08 +0000
Resent-Date: Tue, 28 Feb 2023 16:39:08 +0000
Resent-Message-Id: <E1pX30O-0046bn-7M@lyra.w3.org>
Received: from mimas.w3.org ([128.30.52.79]) by lyra.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <noreply@ietf.org>) id 1pX30M-0046a2-3h for ietf-http-wg@listhub.w3.org; Tue, 28 Feb 2023 16:39:06 +0000
Received: from mail.ietf.org ([50.223.129.194]) by mimas.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <noreply@ietf.org>) id 1pX30L-00EcQk-6h for ietf-http-wg@w3.org; Tue, 28 Feb 2023 16:39:06 +0000
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B56DBC15257C; Tue, 28 Feb 2023 08:38:53 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Henry Thompson via Datatracker <noreply@ietf.org>
To: art@ietf.org
Cc: draft-ietf-httpbis-origin-h3.all@ietf.org, ietf-http-wg@w3.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 9.12.0
Auto-Submitted: auto-generated
Message-ID: <167760233373.37748.2541961884518801633@ietfa.amsl.com>
Reply-To: Henry Thompson <ht@inf.ed.ac.uk>
Date: Tue, 28 Feb 2023 08:38:53 -0800
Received-SPF: pass client-ip=50.223.129.194; envelope-from=noreply@ietf.org; helo=mail.ietf.org
X-W3C-Hub-Spam-Status: No, score=-6.2
X-W3C-Hub-Spam-Report: BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, W3C_AA=-1, W3C_WL=-1
X-W3C-Scan-Sig: mimas.w3.org 1pX30L-00EcQk-6h d754f8f40a305450d10fbe68f03731e1
X-Original-To: ietf-http-wg@w3.org
Subject: Artart last call review of draft-ietf-httpbis-origin-h3-03
Archived-At: <https://www.w3.org/mid/167760233373.37748.2541961884518801633@ietfa.amsl.com>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/50786
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <https://www.w3.org/Mail/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

Reviewer: Henry Thompson
Review result: Ready with Nits

I'm the designated ArtArt last call reviewer for this draft.

This is essentially a _pro forma_ update of the corresponding HTTP/2 document. 
It's substantially ready to go.

Three nits:

1) The readability of the main paragraph of section 2 could, I think, be
improved.

Instead of

   "Where [ORIGIN] indicates that the ORIGIN frame should be sent on Stream 0,
    this should be interpreted to mean the HTTP/3 control stream.
    The ORIGIN frame is sent from servers to clients on the server's control
    stream."

this should (unless I misunderstand it), be a new paragraph, something a bit
more explicit, e.g.:

   Where [ORIGIN] indicates that the ORIGIN frame should be sent on Stream 0,
   this should be interpreted to mean the appropriate HTTP/3 control stream:
   that is, the ORIGIN frame is sent from servers to clients on the server's
   (unidirectional) control stream.

2) To match the HTTP/2 and IANA registry entries, the table in section 4 should
read

    ORIGIN      0x0c    Section 2

3) Again in section 4, it took me rather a long time to chase down the actually
relevant bit of the '[IANA] "HTTP/3 Frame Type" registry [HTTP3]', which is not
in the referenced document at all.  Wouldn't a reference to the think itself,
https://www.iana.org/assignments/http2-parameters/http2-parameters.xhtml#frame-type,
be better here?

ht