Re: Lars Eggert's No Objection on draft-ietf-httpbis-digest-headers-12: (with COMMENT)

Lucas Pardue <lucaspardue.24.7@gmail.com> Wed, 31 May 2023 22:15 UTC

Return-Path: <ietf-http-wg-request+bounce-httpbisa-archive-bis2juki=lists.ie@listhub.w3.org>
X-Original-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Delivered-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 56F3AC151B09 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Wed, 31 May 2023 15:15:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.743
X-Spam-Level:
X-Spam-Status: No, score=-2.743 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SAhN0XC2c1aH for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Wed, 31 May 2023 15:15:33 -0700 (PDT)
Received: from lyra.w3.org (lyra.w3.org [128.30.52.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7816CC14CE51 for <httpbisa-archive-bis2Juki@lists.ietf.org>; Wed, 31 May 2023 15:15:32 -0700 (PDT)
Received: from lists by lyra.w3.org with local (Exim 4.94.2) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1q4U4P-004hPq-FJ for ietf-http-wg-dist@listhub.w3.org; Wed, 31 May 2023 22:13:29 +0000
Resent-Date: Wed, 31 May 2023 22:13:29 +0000
Resent-Message-Id: <E1q4U4P-004hPq-FJ@lyra.w3.org>
Received: from titan.w3.org ([128.30.52.76]) by lyra.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <lucaspardue.24.7@gmail.com>) id 1q4U4N-004hOs-Tq for ietf-http-wg@listhub.w3.org; Wed, 31 May 2023 22:13:27 +0000
Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]) by titan.w3.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from <lucaspardue.24.7@gmail.com>) id 1q4U4L-00BFLd-6Q for ietf-http-wg@w3.org; Wed, 31 May 2023 22:13:27 +0000
Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-19eb96bffd4so304797fac.3 for <ietf-http-wg@w3.org>; Wed, 31 May 2023 15:13:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685571201; x=1688163201; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TSSMr3cQLQ7dQETbK27C5TWOE6Cuk5hfPSdZ2nQBSi0=; b=FFgY9Wj+H/a1uPPZUNTUZPCs1t2H+oy/b3bsyv4Oz41O81hWMlka47pgpaV2JrKaAs L/PXDL0lVJA2hIG+DWR7hY/gZwrIAMtB3Dqw2wJiBrrCSg5A2WxCfWet3MxjKkCqkr6c kNJCsutA8E9o14RA6XszrDNQJ8A2lPHsWAeaBgea0F6c+Lqf8PNZXdYxX/fCEFYJB9Ej mBVMTZkF9JA8o20h/d1rmTetdnrfX6C8+EZ5geXkZ0gf3RJt6neNtfyXJ13i7XQGm/2Z /7Ed/biDN9LUQBaoRvj2jOsUqaEY2BLMGQr+C99KQ01+2wB7bQnv2TwbLWQtNoyfDOIl byhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685571201; x=1688163201; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TSSMr3cQLQ7dQETbK27C5TWOE6Cuk5hfPSdZ2nQBSi0=; b=fvrxxUrvEq0Tb/y024KuT/yp7re0ibZcIhe5lv+GTlcXV5f4HBqd4uIvHVkvRt8hfh e8VY3xED6MYoGDjhpMMZOm0QGbWoXgHMm2KB+Le1bZu0yLAl3u9c+Uq9hyR5Nfh8etaE Fh7qvHwJdWsjFUxdafyEkvAYMdF+UblIlkMNYnNlOSwEJOEi+cS4eyvJdVWbQtFd0g4t pBU3j1v3/YNxbv4So/C2ZvmJkpA1Bd+uTbb12R7xN7S+6Tk9h0vPyTz3O12g1nYKH1U+ HIzckuZdEtPmLDEPk8+c8k0dlKJ0leZdQeMAadXANGE0F1NGIVc6RyjfaLnu6+4M5vWP f1gg==
X-Gm-Message-State: AC+VfDxKfkXPpzgfNY9sYH6CfzkEdyY1e2lZHJVW7ICvkmtQ4xUUH7VH thhNVXMFkdF9SpjkcSiGnlNpNzFPXAFtZqhoNek=
X-Google-Smtp-Source: ACHHUZ5YZbA2lDP9AKDWaTXTLBnC4mtnE3+RiQwgMyWVjheSjIYDFPdG9vbvfMv1dhfQrjTFpDULqncu4gFcWpXuU4c=
X-Received: by 2002:a05:6870:c345:b0:19f:1b43:5840 with SMTP id e5-20020a056870c34500b0019f1b435840mr4763396oak.37.1685571201111; Wed, 31 May 2023 15:13:21 -0700 (PDT)
MIME-Version: 1.0
References: <168499389078.62429.7030198443117373680@ietfa.amsl.com>
In-Reply-To: <168499389078.62429.7030198443117373680@ietfa.amsl.com>
From: Lucas Pardue <lucaspardue.24.7@gmail.com>
Date: Wed, 31 May 2023 23:13:10 +0100
Message-ID: <CALGR9oYUNS_XJHUjmzqR9wJPC6pwHTWou3Jum74p5JELsfoZ5A@mail.gmail.com>
To: Lars Eggert <lars@eggert.org>
Cc: The IESG <iesg@ietf.org>, draft-ietf-httpbis-digest-headers@ietf.org, httpbis-chairs@ietf.org, ietf-http-wg@w3.org, mnot@mnot.net
Content-Type: multipart/alternative; boundary="000000000000af9a7305fd04a026"
Received-SPF: pass client-ip=2001:4860:4864:20::2e; envelope-from=lucaspardue.24.7@gmail.com; helo=mail-oa1-x2e.google.com
X-W3C-Hub-DKIM-Status: validation passed: (address=lucaspardue.24.7@gmail.com domain=gmail.com), signature is good
X-W3C-Hub-Spam-Status: No, score=-4.9
X-W3C-Hub-Spam-Report: BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, W3C_AA=-1, W3C_IRA=-1, W3C_WL=-1
X-W3C-Scan-Sig: titan.w3.org 1q4U4L-00BFLd-6Q 4cc9938c1f1e053ec7dfbccc70e75c25
X-Original-To: ietf-http-wg@w3.org
Subject: Re: Lars Eggert's No Objection on draft-ietf-httpbis-digest-headers-12: (with COMMENT)
Archived-At: <https://www.w3.org/mid/CALGR9oYUNS_XJHUjmzqR9wJPC6pwHTWou3Jum74p5JELsfoZ5A@mail.gmail.com>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/51133
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <https://www.w3.org/Mail/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

Hi Lars,

Thanks for the review. Responses in line.

On Thu, May 25, 2023 at 6:51 AM Lars Eggert via Datatracker <
noreply@ietf.org> wrote:

> Lars Eggert has entered the following ballot position for
> draft-ietf-httpbis-digest-headers-12: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to
> https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-httpbis-digest-headers/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> # GEN AD review of draft-ietf-httpbis-digest-headers-12
>
> CC @larseggert
>
> Thanks to Joel Halpern for the General Area Review Team (Gen-ART) review
> (https://mailarchive.ietf.org/arch/msg/gen-art/hOSKIuNLtGQoGLri4c1auAF9kP4
> ).
>
> ## Nits
>
> All comments below are about very minor potential issues that you may
> choose to
> address in some way - or ignore - as you see fit. Some were flagged by
> automated tools (via https://github.com/larseggert/ietf-reviewtool), so
> there
> will likely be some false positives. There is no need to let me know what
> you
> did with these suggestions.
>
> ### Outdated references
>
> Document references `draft-ietf-httpbis-message-signatures-16`, but `-17`
> is
> the latest available revision.
>

Signatures conceptually dovetails with digests. Assuming they both gain
IESG approval, I expect they'll both be submitted to the the RFC editor to
be published at the same time. The xrefxs can be resolved at that stage.


> ### Grammar/style
>
> #### Section 3.2, paragraph 1
> ```
> fication. How to deal with an ignored preferences is a scenario that
> should b
>                            ^^^^^^^^^^^^^^^^^^^^^^
> ```
> The plural noun "preferences" cannot be used with the article "an". Did you
> mean "an ignored preference" or "ignored preferences"?
>
> #### Section 6.1, paragraph 2
> ```
> es of Content-Type, Content-Encoding etc). A signature that protects
> Integri
>                                      ^^^
> ```
> A period is needed after the abbreviation "etc.".
>
> #### "B.6.", paragraph 7
> ```
> Repr-Digest is designed to be independent from the use of one or more
> transf
>                               ^^^^^^^^^^^^^^^^
> ```
> The usual collocation for "independent" is "of", not "from". Did you mean
> "independent of"?
>
> #### "B.11.", paragraph 6
> ```
> e Digest field. This resulted in a mixed of formats such as base64, hex or
> d
>                                    ^^^^^
> ```
> The phrase "a mixed of" is not correct. Use a noun, not an adjective,
> between
> "a" and "of".
>
> #### "Appendix E.", paragraph 1
> ```
> ncrypted content * Digest is independent from MESSAGING and HTTP/1.1 is not
>                              ^^^^^^^^^^^^^^^^
> ```
> The usual collocation for "independent" is "of", not "from". Did you mean
> "independent of"?
>

Applied in the Editor's copy. Thanks.

Cheers
Lucas