Re: [hybi] I-D ACTION:draft-ietf-hybi-thewebsocketprotocol-08.txt

Dirkjan Ochtman <dirkjan@ochtman.nl> Thu, 09 June 2011 08:09 UTC

Return-Path: <djc.ochtman@gmail.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 40D7F11E807D for <hybi@ietfa.amsl.com>; Thu, 9 Jun 2011 01:09:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.677
X-Spam-Level:
X-Spam-Status: No, score=-2.677 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8O1p82NcUOjN for <hybi@ietfa.amsl.com>; Thu, 9 Jun 2011 01:09:02 -0700 (PDT)
Received: from mail-qw0-f44.google.com (mail-qw0-f44.google.com [209.85.216.44]) by ietfa.amsl.com (Postfix) with ESMTP id 8224A11E8071 for <hybi@ietf.org>; Thu, 9 Jun 2011 01:09:02 -0700 (PDT)
Received: by qwc23 with SMTP id 23so833297qwc.31 for <hybi@ietf.org>; Thu, 09 Jun 2011 01:09:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=t99KkWAM/Wifd4NrcNHe9GzeKlx/fvprVoUZlxA83Fk=; b=qVYg4k49xAwtyKoPNrH5vvo/FghvZXM6gi3JyvVhcvh/HMvLpAP6JAjHrvgTmG41ZW SUDYqhCV+CiO7AdMAjGd5wPDdHhK7cdSGN1BE5/L9Ee2p94HtqgbMX3G0WYdIIXShevf LkzEfCO3lWHCG3ukuaTzx7oHQFUk5ohK1u2V0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=GudkZciABrSWGbcUv0izb69AJYaXNnnUvtAl2qQWavJUI7YgjcoGLMprnZdsRW3BEd 2w3c4XbU1WBGcgYDHUMnukt4uxGyg2QK9CzGFgZ8nLlg4AXsaiIX8E4UaWE+DsFytRxy gXnGjorM3SUd7IvknO/y0skwBbOO3H/fuczes=
Received: by 10.229.7.2 with SMTP id b2mr263124qcb.179.1307606940128; Thu, 09 Jun 2011 01:09:00 -0700 (PDT)
MIME-Version: 1.0
Sender: djc.ochtman@gmail.com
Received: by 10.229.187.145 with HTTP; Thu, 9 Jun 2011 01:08:40 -0700 (PDT)
In-Reply-To: <4DF07883.4070609@warmcat.com>
References: <20110608173012.14596.50398.idtracker@ietfa.amsl.com> <4DF07883.4070609@warmcat.com>
From: Dirkjan Ochtman <dirkjan@ochtman.nl>
Date: Thu, 9 Jun 2011 10:08:40 +0200
X-Google-Sender-Auth: iHwLp_SpkTS5S6Z2YuDXsGkrXCA
Message-ID: <BANLkTimQn-6AbRrk_2FWOZ7WS1fSRu=9Ag@mail.gmail.com>
To: =?UTF-8?B?QW5keSBHcmVlbiAo5p6X5a6J5bu4KQ==?= <andy@warmcat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: hybi@ietf.org
Subject: Re: [hybi] I-D ACTION:draft-ietf-hybi-thewebsocketprotocol-08.txt
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hybi>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jun 2011 08:09:03 -0000

On Thu, Jun 9, 2011 at 09:38, "Andy Green (林安廸)" <andy@warmcat.com> wrote:
> Is there anything or we just crank the default version number up to 8?

It looks like there are at least some differences:

- The extended payload length may now use 64 bits (instead of just 63).
- Invalid client handshake results in HTTP error instead of connection abortion.
- Two new closure status codes (1005 and 1006).
- Specified handling of invalid UTF-8 on the client side.

I note that the remarks from my email (from May 30, [1]) seem to not
have had any impact on this draft. Did my message come to late to make
any changes to this draft, did my suggestions not make sense for
inclusion, or did I perhaps not follow the correct protocol for
suggesting improvements? (I noticed that the required server headers
*are* listed in the section on client acceptance of the server's
opening handshake, but not in the section on the server sending that
handshake.)

Two further questions on things that I feel could be clarified, in draft-08:

- This may be silly, but in the introduction text for the figure
(which is very useful!) in section 4.2, I wonder if it would be
helpful to state explicitly whether the bits are listed in big- or
little-endian order. For bytes, this is defined explicitly in the
descriptions, but I know that I was at least somewhat confused about
this (and got it wrong in my initial implementation). This might just
be my inexperience with diagrams/specs like this, so feel free to
ignore this.

- Section 4.5.1 (about status codes for Close frames) does not mention
anything about masking. I would presume that the status code bytes,
being part of the application data part of the frame, should be
masked, but perhaps it's worth pointing this out explicitly.

Cheers,

Dirkjan

[1] http://www.ietf.org/mail-archive/web/hybi/current/msg07461.html