Re: [hybi] WAMP RFC Draft Critique

Emile Cormier <emile.cormier.jr@gmail.com> Tue, 06 October 2015 02:38 UTC

Return-Path: <emile.cormier.jr@gmail.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5FBE41B360A for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 19:38:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LIMCm5ezAxon for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 19:38:07 -0700 (PDT)
Received: from mail-ob0-x233.google.com (mail-ob0-x233.google.com [IPv6:2607:f8b0:4003:c01::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9C2B1B3606 for <hybi@ietf.org>; Mon, 5 Oct 2015 19:38:07 -0700 (PDT)
Received: by obbda8 with SMTP id da8so144113261obb.1 for <hybi@ietf.org>; Mon, 05 Oct 2015 19:38:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=BeEzs/uxoUmgzFJNokPuWJT2RiyTFyJ0tql4ivdP4Uk=; b=wASVx3O7toqciTC8F+ENbX1tDFTAAoxcdP7LPzKTYDqkFiTS7rKX5mnrYP4AsUj9eO Oy8KBzGa4gU2xAHnGRpGSeFXhOgpohCOKfrt8fQKUtX5prSVjggGD/atkHVsfuxQb020 xog93N4oANdOzRcbA7tvHUJX8gaLDHr00n395+SJOb08P3jPUCWUa1dFedJaUl3XSIYI 1rh6tfaNRDYUvB6JB5qWjVqudHKlfIIjYIaq+gaD9UKJQONt9ZeHX5+Gv5ifsY3DnsUs EuRmk1XdLW5bzIfSnb1DKOlSGrwUOM7+MZgKL5U4KlJxZBd4tZ2xtB4Gmh2W1egLC0Cd AC9Q==
MIME-Version: 1.0
X-Received: by 10.60.63.148 with SMTP id g20mr18593290oes.38.1444099087131; Mon, 05 Oct 2015 19:38:07 -0700 (PDT)
Received: by 10.202.48.203 with HTTP; Mon, 5 Oct 2015 19:38:07 -0700 (PDT)
In-Reply-To: <914b526c-7ba9-41ad-9514-0aadbdb5aade@email.android.com>
References: <914b526c-7ba9-41ad-9514-0aadbdb5aade@email.android.com>
Date: Mon, 5 Oct 2015 23:38:07 -0300
Message-ID: <CAM70yxAFMo_OfkRZ9+N4g0mKCwxFgA8GZ_xNH4S7NeyZ41ToWA@mail.gmail.com>
From: Emile Cormier <emile.cormier.jr@gmail.com>
To: Tobias Oberstein <tobias.oberstein@tavendo.de>
Content-Type: multipart/alternative; boundary=001a11c24b8c1be8f40521668528
Archived-At: <http://mailarchive.ietf.org/arch/msg/hybi/EZlJNp1NobkY3jrE-PO_YTMElXc>
Cc: "hybi@ietf.org" <hybi@ietf.org>
Subject: Re: [hybi] WAMP RFC Draft Critique
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hybi/>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Oct 2015 02:38:09 -0000

Submitted PR #196: https://github.com/wamp-proto/wamp-proto/pull/196

I limited the scope to the Introduction section and I only cover English
spelling, grammar, and prose. I did not attempt to change the meaning of
anything.

On Mon, Oct 5, 2015 at 7:49 PM, Tobias Oberstein <
tobias.oberstein@tavendo.de> wrote:

> Emile, yes, one or more "regular" PRs would be perfect. Ideally each only
> touching one topic/ .. if possible, not one big PR, because that makes it
> harder to merge when some bits are still controversial while others are
> "want to merge right away" (yes, git gurus might cherrypick, but I am not
> the git superpro;) ... it also makes discussion easier.
> Am 06.10.2015 12:33 vorm. schrieb Emile Cormier <
> emile.cormier.jr@gmail.com>gt;:
>
> On Mon, Oct 5, 2015 at 5:19 AM, Tobias Oberstein <
> tobias.oberstein@tavendo.de> wrote:
>
> sorry, accidently hit send .. here is my full reply.
>
>
> This works quite well .. eg. one can review (and comment) on your
> changes easily:
>
>
> https://github.com/ecorm/wamp-proto/commit/7b6c3a75a031e113cdd81931866fce0ff7d6cabf
>
>
> Instead of using blockquotes for my comments, I can just use the GH
> comment system within my own PR/commit. That'll make it easier to merge
> things.
>
> I going to start over my review in a new branch within my fork.
>
>