Re: [hybi] WAMP RFC Draft Critique

[Tobias Oberstein <[e-mail]>]

Hi Emile,

 > I started reviewing the WAMP RFC draft. I wanted to be able to add
> comments to the text, annotate changes for fixing spelling/grammar, and
> annotate changes for improving the English prose. My proposed changes
> are too numerous to be done via email on a mailing list. I figured the
> best way to proceed was to simply annotate changes in my own GitHub fork
> of the WAMP RFC. If there is a better workflow for collaboration on the
> same Markdown document, please let me know.

I think what you touch here is a general, important question: workflow.

Historically, we've been using a GitHub based workflow for collaborating 
on the WAMP spec: GH issues and discussion there plus pull-requests to 
merge in changes.

This works quite well .. eg. I am able to review (and comment) on your 
changes easily:

>
> So far, I've only had the chance to review up to the Design Philosophy
> section. Please see
> https://github.com/ecorm/wamp-proto/blob/ecorm-rfc-critique-1/rfc/draft-oberstet-hybi-tavendo-wamp-00.md.
> I'll try to complete my review during the next few weeks.
>
> I used strikethrough wherever I made edits. I also used blockquotes as a
> way to insert my comments.
>
> If most of my proposed changes are acceptable, then I can submit a pull
> request that would be more easily mergeable. We can use the Review
> Comments feature of GitHub's pull request to discuss my proposed edits.
> While merging, Tobias/Alex can pick and choose which edits they want to
> keep and those they prefer to reject. We can post links to the pull
> requests on this mailing list to keep everyone informed.
>
> Please let me know if this way of proceeding is sensible, or if there is
> a better way.
>
> Cheers,
> Emile Cormier