Re: [hybi] WAMP RFC Draft Critique

Tobias Oberstein <tobias.oberstein@tavendo.de> Mon, 05 October 2015 08:14 UTC

Return-Path: <tobias.oberstein@tavendo.de>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 255BA1B4C38 for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 01:14:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DcXkAhWZrgo6 for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 01:14:49 -0700 (PDT)
Received: from EXHUB020-3.exch020.serverdata.net (exhub020-3.exch020.serverdata.net [206.225.164.30]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ABE501B4C37 for <hybi@ietf.org>; Mon, 5 Oct 2015 01:14:49 -0700 (PDT)
Received: from [192.168.1.140] (88.217.60.228) by smtpx20.serverdata.net (206.225.164.35) with Microsoft SMTP Server (TLS) id 8.3.377.0; Mon, 5 Oct 2015 01:14:47 -0700
To: Emile Cormier <emile.cormier.jr@gmail.com>, "hybi@ietf.org" <hybi@ietf.org>
References: <CAM70yxD9UQ5ZS6aotOqkq9Fz3Hj5LE8V+b=+hw4goZqY62fP9g@mail.gmail.com>
From: Tobias Oberstein <tobias.oberstein@tavendo.de>
Message-ID: <56123176.1030503@tavendo.de>
Date: Mon, 5 Oct 2015 10:14:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <CAM70yxD9UQ5ZS6aotOqkq9Fz3Hj5LE8V+b=+hw4goZqY62fP9g@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/hybi/MyIXiVhSS0oBL32FovkFMSfK_9U>
Subject: Re: [hybi] WAMP RFC Draft Critique
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hybi/>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2015 08:14:51 -0000

Hi Emile,

 > I started reviewing the WAMP RFC draft. I wanted to be able to add
> comments to the text, annotate changes for fixing spelling/grammar, and
> annotate changes for improving the English prose. My proposed changes
> are too numerous to be done via email on a mailing list. I figured the
> best way to proceed was to simply annotate changes in my own GitHub fork
> of the WAMP RFC. If there is a better workflow for collaboration on the
> same Markdown document, please let me know.

I think what you touch here is a general, important question: workflow.

Historically, we've been using a GitHub based workflow for collaborating 
on the WAMP spec: GH issues and discussion there plus pull-requests to 
merge in changes.

This works quite well .. eg. I am able to review (and comment) on your 
changes easily:

>
> So far, I've only had the chance to review up to the Design Philosophy
> section. Please see
> https://github.com/ecorm/wamp-proto/blob/ecorm-rfc-critique-1/rfc/draft-oberstet-hybi-tavendo-wamp-00.md.
> I'll try to complete my review during the next few weeks.
>
> I used strikethrough wherever I made edits. I also used blockquotes as a
> way to insert my comments.
>
> If most of my proposed changes are acceptable, then I can submit a pull
> request that would be more easily mergeable. We can use the Review
> Comments feature of GitHub's pull request to discuss my proposed edits.
> While merging, Tobias/Alex can pick and choose which edits they want to
> keep and those they prefer to reject. We can post links to the pull
> requests on this mailing list to keep everyone informed.
>
> Please let me know if this way of proceeding is sensible, or if there is
> a better way.
>
> Cheers,
> Emile Cormier