Re: [hybi] WAMP RFC Draft Critique

Tobias Oberstein <tobias.oberstein@tavendo.de> Mon, 05 October 2015 22:49 UTC

Return-Path: <tobias.oberstein@tavendo.de>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E498C1A6FE9 for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 15:49:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NDXJZG1voUNJ for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 15:49:23 -0700 (PDT)
Received: from EXHUB020-1.exch020.serverdata.net (exhub020-1.exch020.serverdata.net [206.225.164.28]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B8E41A6FEE for <hybi@ietf.org>; Mon, 5 Oct 2015 15:49:23 -0700 (PDT)
Received: from EXVMBX020-12.exch020.serverdata.net ([169.254.3.137]) by EXHUB020-1.exch020.serverdata.net ([206.225.164.28]) with mapi; Mon, 5 Oct 2015 15:49:21 -0700
From: Tobias Oberstein <tobias.oberstein@tavendo.de>
To: Emile Cormier <emile.cormier.jr@gmail.com>
Date: Mon, 5 Oct 2015 15:49:16 -0700
Thread-Topic: [hybi] WAMP RFC Draft Critique
Thread-Index: AdD/wBMoCvAP5T7US1ei5YDG5zckag==
Message-ID: <914b526c-7ba9-41ad-9514-0aadbdb5aade@email.android.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: de-DE, en-US
Content-Type: multipart/alternative; boundary="_000_914b526c7ba941ad95140aadbdb5aadeemailandroidcom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/hybi/NCkbw4yFljlKbU2Yo8DCW_ICwlY>
Cc: "hybi@ietf.org" <hybi@ietf.org>
Subject: Re: [hybi] WAMP RFC Draft Critique
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hybi/>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2015 22:49:25 -0000

Emile, yes, one or more "regular" PRs would be perfect. Ideally each only touching one topic/ .. if possible, not one big PR, because that makes it harder to merge when some bits are still controversial while others are "want to merge right away" (yes, git gurus might cherrypick, but I am not the git superpro;) ... it also makes discussion easier.

Am 06.10.2015 12:33 vorm. schrieb Emile Cormier <emile.cormier.jr@gmail.com>om>:
On Mon, Oct 5, 2015 at 5:19 AM, Tobias Oberstein <tobias.oberstein@tavendo.de<mailto:tobias.oberstein@tavendo.de>> wrote:
sorry, accidently hit send .. here is my full reply.


This works quite well .. eg. one can review (and comment) on your
changes easily:

https://github.com/ecorm/wamp-proto/commit/7b6c3a75a031e113cdd81931866fce0ff7d6cabf


Instead of using blockquotes for my comments, I can just use the GH comment system within my own PR/commit. That'll make it easier to merge things.

I going to start over my review in a new branch within my fork.