Re: [hybi] Fwd: New Version Notification for draft-mcmanus-httpbis-h2-websockets-01.txt

Andy Green <andy@warmcat.com> Fri, 27 October 2017 07:33 UTC

Return-Path: <andy@warmcat.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D7E0013F486 for <hybi@ietfa.amsl.com>; Fri, 27 Oct 2017 00:33:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 3.099
X-Spam-Level: ***
X-Spam-Status: No, score=3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, GB_SUMOF=5, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ab9NLVUyizgT for <hybi@ietfa.amsl.com>; Fri, 27 Oct 2017 00:33:15 -0700 (PDT)
Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 867BF139203 for <hybi@ietf.org>; Fri, 27 Oct 2017 00:33:15 -0700 (PDT)
To: Amos Jeffries <squid3@treenet.co.nz>, John Fallows <john.fallows@kaazing.com>, Patrick McManus <pmcmanus@mozilla.com>
Cc: hybi <hybi@ietf.org>, HTTP Working Group <ietf-http-wg@w3.org>
References: <150903901882.24232.14013636670744151147.idtracker@ietfa.amsl.com> <CAOdDvNrC1PgribOiDc93hfCDFSJbjodnU8=yeNWgzkq4Cm-2Cg@mail.gmail.com> <CACAJL3nEB5jGFXpqPZ2ErdkezCHpZE1CnqXy0yomBP-v7jcGRA@mail.gmail.com> <bf6aabaf-227b-fc3d-8142-57712a2e8935@warmcat.com> <1e9970aa-d0ef-6887-bd27-6ec344a80bc1@treenet.co.nz>
From: Andy Green <andy@warmcat.com>
Message-ID: <e3b54a9a-3f39-3f5e-cf9c-e0c20cff4c36@warmcat.com>
Date: Fri, 27 Oct 2017 15:32:05 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
In-Reply-To: <1e9970aa-d0ef-6887-bd27-6ec344a80bc1@treenet.co.nz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/hybi/Rg055DMaF82R5636I-2UzMzIbWk>
Subject: Re: [hybi] Fwd: New Version Notification for draft-mcmanus-httpbis-h2-websockets-01.txt
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hybi/>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Oct 2017 07:33:17 -0000


On 10/27/2017 02:59 PM, Amos Jeffries wrote:
> On 27/10/17 12:40, Andy Green wrote:>
>> The spec still needs to touch on the changes it is making to h2 DATA 
>> frames, it assumes it is inheriting generic bidirectional transport 
>> from h2, but it isn't.  H2 DATA kills the stream if it comes outside 
>> of whatever was told for content-length: on both sides, and eg h2spec 
>> requires you to enforce that.  So the spec requires changes in DATA 
>> handling implementation for upgraded streams and should note it.
> 
> AIUI, Content-Length remains optional in h2 as it was in 1.x. The h2 

h2spec tests for these

         8.1.2.6. Malformed Requests and Responses
           ✔ 1: Sends a HEADERS frame with the "content-length" header 
field which does not equal the DATA frame payload length
           ✔ 2: Sends a HEADERS frame with the "content-length" header 
field which does not equal the sum of the multiple DATA frames payload 
length

> equivalent of Transfer-Encoding:chunked is being used by wss. Just a 
> stream of DATA frames in both directions terminated by the END_STREAM 
> flag instead of a specific Content-Length value.

Well, that is banned in h2, but I guess you are right, if there is no 
content-length: it can just end on END_STREAM and there's no problem... 
it's my misunderstanding I guess.

-Andy

> Amos
>