Re: [hybi] Last Call: <draft-ietf-hybi-thewebsocketprotocol-10.txt> (The WebSocket protocol) to Proposed Standard

Mykyta Yevstifeyev <evnikita2@gmail.com> Tue, 12 July 2011 09:09 UTC

Return-Path: <evnikita2@gmail.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CFED921F8FDB; Tue, 12 Jul 2011 02:09:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.499
X-Spam-Level:
X-Spam-Status: No, score=-3.499 tagged_above=-999 required=5 tests=[AWL=0.100, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sHC-EwR-3u+J; Tue, 12 Jul 2011 02:09:13 -0700 (PDT)
Received: from mail-bw0-f44.google.com (mail-bw0-f44.google.com [209.85.214.44]) by ietfa.amsl.com (Postfix) with ESMTP id A66EA21F8F90; Tue, 12 Jul 2011 02:09:12 -0700 (PDT)
Received: by bwb17 with SMTP id 17so4535151bwb.31 for <multiple recipients>; Tue, 12 Jul 2011 02:09:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=C+lwESc0dmfbKS4TBD/fjZ1fyx464NK2YubP1AD1lkU=; b=dcL8ENHRYaX49yHmQWHoS8BY+tGdnOT0K+tSZiqEPzcJRBgZyHg/3e6+xJi6sulqNa r/X/60DKrOiinQ9CC1F5ZeUqbBA5mPP4Wl+qorR94j0WZZ/c3k+gy/CpvRfQf3WrV0nU Yy57PYjUi+174mojXVwoDKZDH38kcUg4TMZdQ=
Received: by 10.204.14.212 with SMTP id h20mr3012907bka.132.1310461751524; Tue, 12 Jul 2011 02:09:11 -0700 (PDT)
Received: from [127.0.0.1] ([195.191.104.224]) by mx.google.com with ESMTPS id n5sm783461bkw.11.2011.07.12.02.09.09 (version=SSLv3 cipher=OTHER); Tue, 12 Jul 2011 02:09:10 -0700 (PDT)
Message-ID: <4E1C0F63.8060206@gmail.com>
Date: Tue, 12 Jul 2011 12:09:55 +0300
From: Mykyta Yevstifeyev <evnikita2@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20110624 Thunderbird/5.0
MIME-Version: 1.0
To: Julian Reschke <julian.reschke@gmx.de>
References: <20110711140229.17432.23519.idtracker@ietfa.amsl.com> <4E1BD054.7010103@gmail.com> <4E1BF0D6.4090702@gmx.de>
In-Reply-To: <4E1BF0D6.4090702@gmx.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Tue, 12 Jul 2011 02:16:30 -0700
Cc: hybi@ietf.org, ietf@ietf.org, draft-ietf-hybi-thewebsocketprotocol@tools.ietf.org
Subject: Re: [hybi] Last Call: <draft-ietf-hybi-thewebsocketprotocol-10.txt> (The WebSocket protocol) to Proposed Standard
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hybi>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2011 09:09:13 -0000

12.07.2011 9:59, Julian Reschke wrote:
> On 2011-07-12 06:40, Mykyta Yevstifeyev wrote:
>
> [ . . . ]
>
>> Section 3. I propose to rewrite the first paragraph as follows:
>>
>>> This specification defines two URI schemes for WebSocket protocol -
>>> 'ws' and 'wss'. Their syntax is defined below using ABNF [RFC5234]
>>> in the<ws-uri> and<wss-uri>, respectively:
>>>
>>> ws-uri = "ws:" "//" host [ ":" port ] path-abempty [ "?" query ]
>>> wss-uri = "wss:" "//" host [ ":" port ] path-abempty [ "?" query ]
>>>
>>> where the<host>,<port>,<path-abempty> and<query> rules are
>>> defined in RFC 3986 [RFC3986].
>>
>> Rationale: (1) The first paragraph gets clearer. (2) ABNF is changed not
>> ot use pros-vals (RFC 5234) (3) s/path/path-abempty/ to directly import
>> it from RFC 3986 (4) Several editorial issues fixed.
>
> -10
>
> Granted, it doesn't use prose values anymore, but then it get's 
> incomplete. I believe putting references to ABNF productions from 
> other specs into prose values is absolutely the right thing to do (as 
> opposed to just mention them in prose).
I don't have any string position in the way of importing the productions 
from other documents.  However, what is above is what I like more.  
However, what we can see, eg. in 
http://tools.ietf.org/html/rfc5538#appendix-A can be fine as well.
>
>> Section 5.2.2, bullet 3, sub-bullet 4. When defining the ABNF for a
>> header, the header name should be included in it as well. So the first
>> line should be:
>> ...
>
> Why?
There is the following formulation:

> The 'Foo' headers takes the form of <foo-header> ABNF rules below:
>
> foo-header = *(APHA/DIGIT)

will result in the message headers like:

>          Upgrade: TLS/1.2
>          Connection: Upgrade
>          gfr134

and "gfr134" will be the 'Foo' header.  "foo-header = "Foo:" 
*(APHA/DIGIT)" will result in valid:

>          Upgrade: TLS/1.2
>          Connection: Upgrade
>          Foo: gfr134

See also eg. RFC 3282, RFC 2616.

>
> [ . . . ]
>
> That being said, it might be a good idea to revisit the choice of 
> syntax, or at least to clarify the LWS situation.
The document may reference the httpbis-p1 where the <n>#<m>rule 
extension will be described for valid ABNF.  See 
http://tools.ietf.org/html/draft-ietf-httpbis-p1-messaging-15#section-1.2.1
>
> [ . . . ]
>> Section 11.2: the same applies.
>>
>> Section 11.12:
>>
>>> Version Number | Reference
>>> -+----------------+-----------------------------------------+-
>>> | 0 + draft-ietf-hybi-thewebsocketprotocol-00 |
>>> -+----------------+-----------------------------------------+-
>>> [ . . . ]
>>> -+----------------+-----------------------------------------+-
>>> | 9 + draft-ietf-hybi-thewebsocketprotocol-09 |
>>> -+----------------+-----------------------------------------+-
>> ...
>
>
> This is indeed fishy and I would be really surprised if IESG and RFC 
> Editor let this pass.
>
> If 0..9 can't be reassigned then let's just state they are reserved.
I believe there is no problems to make the 0..9 spare, except 1, for 
this version of WS.

Mykyta Yevstifeyev
>
>> ...
>
> Best regards, Julian
>