Re: [hybi] change in 07: Payload only compression extension (was Re: With deflate-stream, Close frame doesn't work as an end of data marker)

Ian Fette (イアンフェッティ) <ifette@google.com> Thu, 10 March 2011 06:59 UTC

Return-Path: <ifette@google.com>
X-Original-To: hybi@core3.amsl.com
Delivered-To: hybi@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 297B93A68DA for <hybi@core3.amsl.com>; Wed, 9 Mar 2011 22:59:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -105.702
X-Spam-Level:
X-Spam-Status: No, score=-105.702 tagged_above=-999 required=5 tests=[AWL=-0.026, BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JyQZDdyLvjCw for <hybi@core3.amsl.com>; Wed, 9 Mar 2011 22:59:00 -0800 (PST)
Received: from smtp-out.google.com (smtp-out.google.com [216.239.44.51]) by core3.amsl.com (Postfix) with ESMTP id 0D2E73A68BF for <hybi@ietf.org>; Wed, 9 Mar 2011 22:58:56 -0800 (PST)
Received: from hpaq5.eem.corp.google.com (hpaq5.eem.corp.google.com [172.25.149.5]) by smtp-out.google.com with ESMTP id p2A70DL8031015 for <hybi@ietf.org>; Wed, 9 Mar 2011 23:00:13 -0800
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1299740413; bh=m/NBHXqyYDMr2NQS9h5SxzwAAiw=; h=MIME-Version:Reply-To:In-Reply-To:References:Date:Message-ID: Subject:From:To:Cc:Content-Type; b=TldP/vAkBGxFqQUJRmRQwqsWPPbZ7JIQT8RYczprx/cjOF2iDXWi8qa00U3TZSEnM LW6pFO2tVJLy5ZAMJSiGw==
Received: from iwn36 (iwn36.prod.google.com [10.241.68.100]) by hpaq5.eem.corp.google.com with ESMTP id p2A70ALa018541 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for <hybi@ietf.org>; Wed, 9 Mar 2011 23:00:11 -0800
Received: by iwn36 with SMTP id 36so1404046iwn.36 for <hybi@ietf.org>; Wed, 09 Mar 2011 23:00:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=32XMP+cHPc7jc3uAEbLBUqeKS/qbH6Pe+afgQKCtj9A=; b=idxIjdGwYOPxifzxi+Jw5zlxgIHqwl2OAbfYASWfb9UxGErKgRVdk5kkFXkmFAXLZN EL7kjACJj6cxzDWf4vsA==
DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=xyZrBcQ/FBeue2KEeYVKHiBkz1SRmcLn5SSvBvulRKTSufQgA6a4VuhnMg5RyokYMu y8v9eMkCBMHE20PeY5Ww==
MIME-Version: 1.0
Received: by 10.231.146.18 with SMTP id f18mr5591605ibv.185.1299740410466; Wed, 09 Mar 2011 23:00:10 -0800 (PST)
Received: by 10.231.34.131 with HTTP; Wed, 9 Mar 2011 23:00:10 -0800 (PST)
In-Reply-To: <4D7876B8.1010905@ericsson.com>
References: <OF4821AA00.120197B4-ON8825784E.0076F791-8825784E.00781253@playstation.sony.com> <4D77FB84.9010104@warmcat.com> <AANLkTin+JizCJ-tgr1bxTygaT_2ueT910JByq9BYGncS@mail.gmail.com> <4D7876B8.1010905@ericsson.com>
Date: Wed, 09 Mar 2011 23:00:10 -0800
Message-ID: <AANLkTikDDYrFAPmk_Lgftf=DzUotmL8EqWMWM2op3nFz@mail.gmail.com>
From: "Ian Fette (イアンフェッティ)" <ifette@google.com>
To: Salvatore Loreto <salvatore.loreto@ericsson.com>
Content-Type: multipart/alternative; boundary="0016e64afdc6775460049e1b65e2"
X-System-Of-Record: true
Cc: "hybi@ietf.org" <hybi@ietf.org>, "Yutaka_Takeda@playstation.sony.com" <Yutaka_Takeda@playstation.sony.com>
Subject: Re: [hybi] change in 07: Payload only compression extension (was Re: With deflate-stream, Close frame doesn't work as an end of data marker)
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: ifette@google.com
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hybi>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2011 06:59:08 -0000

seems straight forward enough.

-ian

On Wed, Mar 9, 2011 at 10:59 PM, Salvatore Loreto <
salvatore.loreto@ericsson.com> wrote:

>  (as co-chair I want to bring your attention to this)
>
>
> Hi there,
>
>
> the following changes (proposed by Takeshi Yoshino in [1])
> has been largely discussed (for the technical reasons follow the
> discussions thread [1] and [2]):
> the discussion has highlighted that the proposal brings some benefit and no
> side effects.
>
>
>
> [1] http://www.ietf.org/mail-archive/web/hybi/current/msg06642.html
> [2] http://www.ietf.org/mail-archive/web/hybi/current/msg06801.html
> [3] http://www.ietf.org/mail-archive/web/hybi/current/msg06674.html
>
>
> so unless anyone object strongly -07 will include the "yoshino-san's
> proposal" [3]
>
>
> cheers
> /Sal
>
>
> --
> Salvatore Loretowww.sloreto.com
>
>
>
> On 3/10/11 7:22 AM, Ian Fette (イアンフェッティ) wrote:
>
> I'm going over the threads trying to figure out what i need to do, and I
> will admit that this one has me a bit stumped. If we adopt yoshino-san's
> proposal [1] to only compress the payload of the frame, does that put this
> issue to rest?
>
>  [1] http://www.ietf.org/mail-archive/web/hybi/current/msg06674.html
>
> On Wed, Mar 9, 2011 at 2:13 PM, Andy Green <andy@warmcat.com> wrote:
>
>> On 03/09/2011 09:51 PM, Somebody in the thread at some point said:
>>
>> Hi -
>>
>>    > Are there other circumstances that can actually cause this I'm
>>>  > overlooking too easily?
>>>
>>> Yes. Since your receive buffer passed in recv(2) has a predetermined
>>> finite size and you may not be reading all data in the kernel space
>>> (TCP) buffer. Depending on how it is implemented and timing, the
>>> receiver may successfully extract Close frame out of data you have just
>>> read from TCP socket, and then close the socket without bothering to
>>> read the outstanding data in the kernel.
>>>
>>
>>  It's a good point.  I can see how that's effectively fragmenting the
>> thing entirely in userland at the receiver.
>>
>> However that seems simple to solve since the extra junk data is already
>> received in kernel.  Just before socket close time we just need to use a
>> little poll() POLLIN loop with no timeout to drain it while there's stuff
>> immediately pending, right?  Nothing more will come and close is always
>> happy.
>>
>>
>> -Andy
>> _______________________________________________
>> hybi mailing list
>> hybi@ietf.org
>> https://www.ietf.org/mailman/listinfo/hybi
>>
>
>
>
>