Re: [hybi] With deflate-stream, Close frame doesn't work as an end of data marker

Andy Green <andy@warmcat.com> Thu, 10 March 2011 08:54 UTC

Return-Path: <andy.warmcat.com@googlemail.com>
X-Original-To: hybi@core3.amsl.com
Delivered-To: hybi@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 777183A687E for <hybi@core3.amsl.com>; Thu, 10 Mar 2011 00:54:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.626
X-Spam-Level:
X-Spam-Status: No, score=-3.626 tagged_above=-999 required=5 tests=[AWL=-0.027, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GrEUcxsa0OpO for <hybi@core3.amsl.com>; Thu, 10 Mar 2011 00:54:51 -0800 (PST)
Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by core3.amsl.com (Postfix) with ESMTP id 493303A68BA for <hybi@ietf.org>; Thu, 10 Mar 2011 00:54:51 -0800 (PST)
Received: by wwi17 with SMTP id 17so1172807wwi.1 for <hybi@ietf.org>; Thu, 10 Mar 2011 00:56:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=sSa5xqMdf9IJDI0RreKK/6Wp4VVZZk12r8HHSe5BLdc=; b=Q55wUa1RFatVWNt4355mAyfDhIHkDc8RrrCGjKsAttkkYsyCnjG7P0d2+XoZztdn3U T0duFAyg7TpqTQ6gpslPUFbp14y0GtpijHqyx39JyQF2jNfpkBArXneqCaHUHRERzDDM zS2gHUHGudQm1NcBfoVfIBGL9RKZXX4SfbTZ4=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=eQ/MXEEuzK2GWr3i+qZERbofMwg5/0eQknr1Ukw210oxxELU5JQ//JXpyE75wEQvC5 YLu71CVQkiYVX9gpDbC7K6FVma/wGAy+/pscZLa0sbnhRIRpC6UPKk+ykRvhk6BC96TR XJeseV+iaRlT8jrin41OemMYHEZRMzDD6m198=
Received: by 10.227.195.76 with SMTP id eb12mr760888wbb.160.1299747366322; Thu, 10 Mar 2011 00:56:06 -0800 (PST)
Received: from otae.warmcat.com (cpc1-nrte21-2-0-cust677.8-4.cable.virginmedia.com [81.111.78.166]) by mx.google.com with ESMTPS id x1sm543770wbh.2.2011.03.10.00.56.04 (version=SSLv3 cipher=OTHER); Thu, 10 Mar 2011 00:56:04 -0800 (PST)
Sender: Andy Green <andy.warmcat.com@googlemail.com>
Message-ID: <4D789223.8010208@warmcat.com>
Date: Thu, 10 Mar 2011 08:56:03 +0000
From: Andy Green <andy@warmcat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110302 Fedora/3.1.8-3.fc16 Thunderbird/3.1.8
MIME-Version: 1.0
To: ifette@google.com
References: <OF4821AA00.120197B4-ON8825784E.0076F791-8825784E.00781253@playstation.sony.com> <4D77FB84.9010104@warmcat.com> <AANLkTin+JizCJ-tgr1bxTygaT_2ueT910JByq9BYGncS@mail.gmail.com>
In-Reply-To: <AANLkTin+JizCJ-tgr1bxTygaT_2ueT910JByq9BYGncS@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: hybi@ietf.org, Yutaka_Takeda@playstation.sony.com
Subject: Re: [hybi] With deflate-stream, Close frame doesn't work as an end of data marker
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hybi>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2011 08:54:52 -0000

On 03/10/2011 05:22 AM, Somebody in the thread at some point said:

Hi -

> I'm going over the threads trying to figure out what i need to do, and I
> will admit that this one has me a bit stumped. If we adopt yoshino-san's
> proposal [1] to only compress the payload of the frame, does that put
> this issue to rest?
>
> [1] http://www.ietf.org/mail-archive/web/hybi/current/msg06674.html

Payload only compression would be nice.

However this "dribbling compression codes after close" thing is not a 
problem in the real world that I can see and at most maybe needs a note 
that before closing a socket compressed like this, you may need to drain 
it in a loop polling it with no timeout and POLLIN until nothing is left 
before calling close().

Also one note on Yoshino's language to describe the compression actions 
it mixes Z_ nomenclature that zlib uses and hex packets on the wire, if 
this hex trailer that he mentions is a byproduct of Z_FINISH or whatever 
it might be clearer to an implementer that he can generate it like that 
and forget mentioning magic hex.

-Andy