Re: [hybi] WAMP RFC Draft Critique

Emile Cormier <emile.cormier.jr@gmail.com> Mon, 05 October 2015 22:33 UTC

Return-Path: <emile.cormier.jr@gmail.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 422611A6F7D for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 15:33:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JjQs6pesC3nZ for <hybi@ietfa.amsl.com>; Mon, 5 Oct 2015 15:33:32 -0700 (PDT)
Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AD4B51A6F7C for <hybi@ietf.org>; Mon, 5 Oct 2015 15:33:32 -0700 (PDT)
Received: by oiev17 with SMTP id v17so99168742oie.1 for <hybi@ietf.org>; Mon, 05 Oct 2015 15:33:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=qnmrY+mlMcEwU+qpVl+V5g02ndmIcSkgJUY+VI/vo0A=; b=MINSExL5ie/2Ucv7co968DjcbT1rf9op5bLmM7xhz41b5jW65PuMUzVh0XRUIPBoj5 o9UOkiW20PnkfintkKFF6Aq6B++1IUWoWbDYVierHPZIN4RcHTsxyRFKNq3ZeCmfJuzV 2jKEiRVGkUCG1Dx6goNONI9NtQCGCwi/HtqSfNQlvpE87iocd8CD02SkGO5tj+qkyVn9 D2AFML2vNF/Ul7j8hnItRTrol/uh5VlyO3T6ggld2XLBnW5M1w9MvO1zWqx1pBpkll0T pwHSX42fLamDhR3cIRTeQrcrj2yQzRPDl2Y2J4rsW8y0IYUvldbn+hafWS0ivOUV00Lo daCw==
MIME-Version: 1.0
X-Received: by 10.202.97.196 with SMTP id v187mr18118815oib.91.1444084412167; Mon, 05 Oct 2015 15:33:32 -0700 (PDT)
Received: by 10.202.48.203 with HTTP; Mon, 5 Oct 2015 15:33:32 -0700 (PDT)
In-Reply-To: <5612328C.7030401@tavendo.de>
References: <CAM70yxD9UQ5ZS6aotOqkq9Fz3Hj5LE8V+b=+hw4goZqY62fP9g@mail.gmail.com> <5612328C.7030401@tavendo.de>
Date: Mon, 5 Oct 2015 19:33:32 -0300
Message-ID: <CAM70yxAQ5No-9SFE3y+E2KvFgJ+PnuBuQK95dPopGqLdFEORbA@mail.gmail.com>
From: Emile Cormier <emile.cormier.jr@gmail.com>
To: Tobias Oberstein <tobias.oberstein@tavendo.de>
Content-Type: multipart/alternative; boundary=001a113d393869bc630521631a86
Archived-At: <http://mailarchive.ietf.org/arch/msg/hybi/vDXCyC9cudd95iboeVhww2YeKuY>
Cc: "hybi@ietf.org" <hybi@ietf.org>
Subject: Re: [hybi] WAMP RFC Draft Critique
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hybi/>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2015 22:33:34 -0000

On Mon, Oct 5, 2015 at 5:19 AM, Tobias Oberstein <
tobias.oberstein@tavendo.de> wrote:

> sorry, accidently hit send .. here is my full reply.
>
>
> This works quite well .. eg. one can review (and comment) on your
> changes easily:
>
>
> https://github.com/ecorm/wamp-proto/commit/7b6c3a75a031e113cdd81931866fce0ff7d6cabf
>
>
Instead of using blockquotes for my comments, I can just use the GH comment
system within my own PR/commit. That'll make it easier to merge things.

I going to start over my review in a new branch within my fork.