Re: [I2nsf] [yang-doctors] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04
"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Wed, 27 November 2019 13:43 UTC
Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5EA0B1200A1; Wed, 27 Nov 2019 05:43:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.988
X-Spam-Level:
X-Spam-Status: No, score=-1.988 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HK_NAME_FM_MR_MRS=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id upPKrraxOGTf; Wed, 27 Nov 2019 05:43:20 -0800 (PST)
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7344F12004E; Wed, 27 Nov 2019 05:43:20 -0800 (PST)
Received: by mail-wr1-x42c.google.com with SMTP id w9so26795554wrr.0; Wed, 27 Nov 2019 05:43:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J0+N9R/435J/dtK4+bIFa7tpRVKp5B28xHXQIhKGU84=; b=dQbTx1rehZkc1I+bishHXsAtgGXTvg/hAGLV78dpG99VpS9ltwo963gFLPAnLTnrLB 54Ya/7YBWRa0M72IafBGJlefC6pzeRgm3KhyiiAZ7cwpS3i5DHKUG0n/Z7PAFRoFHUve Ef2570uGiF65qKPnj2Q1syBhCYh9Qaw6SCYt1vaBJZsDCCPLotxZEfHBmGD63uvDutXz ssf9OvMQhx95zpnlg2b7q9zMoarhKgFHkKvhPB9fZStKi36VDOmtioW3isG1SulZk0sn b9jfyx/XecR5GKAkTbn1Q5/xxq2zg13E/vNY06nkxvDl1PyeRV6RcGEh7pd2PAT9ZdcX HWgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J0+N9R/435J/dtK4+bIFa7tpRVKp5B28xHXQIhKGU84=; b=nT46s3jBzxY8s2rmBkJAw7lIsDkZyCO1yIXumq5LL+OKcfcxUU30PtFS3U6okKsZTZ CExSZqSklTnfNC1Su6GD+MsJLF6dNRuDUW3nm3MvzeHvMqBIgums3Zrw0QSkCSOE3aw9 35aSew+UT+T20SXzstZCYey88EPO41K07oAkeUBVOzB8wH/dzfvn+Qfp86VWRkzmd/aQ 7wh09iNaXvOldG9LtnABFs8MjXTGcPj377kx7WaJ6UgV0PFX/rPE2PHOnZGAtPn0yPcu z+1z/pJMZx83LJ2eD1BSKtolbSZMsm7MZ8JC/0gjfQ5gC5+lv8ZZXCWthBEQE0RhAxrI CGVQ==
X-Gm-Message-State: APjAAAUNM26tfZGpr5BS0xnsvwz5HKRk/yW2tXDT/4832NfXaXwnJ2UM 6+lyEXPT+emj1Eb4bKxG1hV1DZjdpi1tzvraepk=
X-Google-Smtp-Source: APXvYqwcPwQPyB28BRmPUZw36XX8E9VJU0+nZD89imhmjt6go4Jnq3YEL1cuPtvxazugTPnro4uCGyY7WONylE3/1DA=
X-Received: by 2002:adf:8b09:: with SMTP id n9mr40791045wra.95.1574862198738; Wed, 27 Nov 2019 05:43:18 -0800 (PST)
MIME-Version: 1.0
References: <156323104862.27197.7523333169738579602@ietfa.amsl.com> <CAPK2DexfAtNCx5SfG6tjgVjbWc0Bo5z_uviYD58exUxRa08h=A@mail.gmail.com> <CAPK2Deym+xgmjPBgUiiJydWT2ETmXpQ-0OU--L4qQcDYvoh+xg@mail.gmail.com> <CAPK2Dey_kMTYouwFxkyBSpNhmnCQNwdJrUBYR9yw7Vhz5A_OXA@mail.gmail.com> <33AC564A-5DEA-42CD-9039-12BCB09BD046@tail-f.com>
In-Reply-To: <33AC564A-5DEA-42CD-9039-12BCB09BD046@tail-f.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Wed, 27 Nov 2019 22:42:41 +0900
Message-ID: <CAPK2DezZDPicLQfUMyNPKjriUVNeiNxPu6AtCsJwYSJAFFWEJQ@mail.gmail.com>
To: Carl Moberg <calle@tail-f.com>
Cc: "i2nsf@ietf.org" <i2nsf@ietf.org>, YANG Doctors <yang-doctors@ietf.org>, draft-ietf-i2nsf-capability-data-model.all@ietf.org, skku-iotlab-members <skku-iotlab-members@googlegroups.com>
Content-Type: multipart/alternative; boundary="000000000000ed145f0598542dee"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/2eZ95OorXT9S8wg9ch3DV3wTu40>
Subject: Re: [I2nsf] [yang-doctors] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Nov 2019 13:43:24 -0000
Hi Carl, Thanks a lot. Best Regards, Paul On Wed, Nov 27, 2019 at 10:37 PM Carl Moberg <calle@tail-f.com> wrote: > Paul, > > Yes! Updated and done. > > > > On 26 Nov 2019, at 13:52, Mr. Jaehoon Paul Jeong <jaehoon.paul@gmail.com> > wrote: > > > > Hi Carl, > > Did you have a change to check our revision for I2NSF Capability Draft? > > > > Thanks. > > > > Best Regards, > > Paul > > > > On Wed, Nov 6, 2019 at 10:56 AM Mr. Jaehoon Paul Jeong < > jaehoon.paul@gmail.com> wrote: > > Hi Carl, > > I believe that I have addressed your comments on I2NSF Capability Data > Model: > > https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05 > > > > If you are satisfied with the revision, could you update the Review > result in the following page? > > > https://datatracker.ietf.org/doc/review-ietf-i2nsf-capability-data-model-04-yangdoctors-lc-moberg-2019-07-15/ > > > > Thanks. > > > > Best Regards, > > Paul > > > > On Thu, Jul 25, 2019 at 11:29 PM Mr. Jaehoon Paul Jeong < > jaehoon.paul@gmail.com> wrote: > > Hi Carl, > > Here is the revision letter for the revised draft, reflecting your > comments along with the revised draft: > > https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05 > > > > This revision letter first addresses the comments from Acee and then > > addresses your comments from page 6. > > > > If you have further comments and questions, please let me know. > > > > Thanks. > > > > Best Regards, > > Paul > > > > On Mon, Jul 15, 2019 at 6:50 PM Carl Moberg via Datatracker < > noreply@ietf.org> wrote: > > Reviewer: Carl Moberg > > Review result: Almost Ready > > > > This is my review of the ietf-i2nsf-capability@2019-03-28.yang module > as part > > of draft-ietf-i2nsf-capability-data-model-04. > > > > The module cleanly passes validation (i.e. 'pyang --ietf') and I have > been able > > to load it into a NETCONF server and done basic operations on it (add, > query > > for and remove capabilties). > > > > I have one high-level concern and a couple of nits. > > > > This document defines "a YANG data model for capabilities of various > Network > > Security Functions (NSFs)". After my in initial reading of the draft and > I2RS > > background material I found it hard to understand which of the > components in > > the I2RS reference architecture that would implement the YANG module > (i.e. > > provide NETCONF or RESTCONF protocol implementations). The draft says the > > following: > > > > """ > > This document provides a data model using YANG [RFC6020][RFC7950] > > that defines the capabilities of NSFs to centrally manage > > capabilities of those security devices. The security devices can > > register their own capabilities into Network Operator Management > > (Mgmt) Systems (i.e., Security Controllers) with this YANG data model > > through the registration interface [RFC8329]. > > """ > > > > This seems to point in the direction of the 'Network Operator Managemen > (Mgmt) > > Systems' as the location of the YANG datastore, i.e. where this module > would be > > implemented. > > > > My main question then becomes; given the fact that the top-level element > of the > > data model is a container ('nsf') with a set of leaf-lists and > containers under > > it, this model seems to only allow for the registration of one (1) > single NSF. > > This seems to be also supported by the language of the description > clauses > > referencing "network service function" in singular. > > > > I would intuitively expect such a registry to be able to store the > capabilities > > of a multitude of NSFs. I would appreciate if the authors could clarify > the > > intent and expected usage of the model based on this question. > > > > Given my initial struggles I would suggest adding clearer upfront > language on > > the location of the module and the addition of usage examples of e.g. > NSFs > > registering capability instances to registry. (See > > https://tools.ietf.org/html/rfc8407#section-3.12). I believe that would > provide > > additional and helpful context to the usage of the model. > > > > The following drafts are referenced in 'reference' and 'description' > fields in > > the YANG module, but are missing from the Informative References section > of the > > draft. (See https://tools.ietf.org/html/rfc8407#appendix-A.) - > > draft-hong-i2nsf-nsf-monitoring-data-model-06 - > draft-ietf-i2nsf-capability-04 > > - draft-dong-i2nsf-asf-config-01 > > > > The modules consistently seem to spell out 'capabilities', but shorten > > 'capability' to 'capa', e.g.: > > > > +--rw condition-capabilities > > | +--rw generic-nsf-capabilities > > | | +--rw ipv4-capa* identityref > > > > I would suggest following > https://tools.ietf.org/html/rfc8407#section-4.3.1 and > > spell out 'capability' unless the authors are of the opinion that 'capa' > is a > > well known abbreviation. > > > > Remove the following references (they're not used): > > > > [RFC6087] Bierman, A., "Guidelines for Authors and Reviewers of YANG > > Data Model Documents", RFC 6087, DOI 10.17487/RFC6087, > > January 2011, <https://www.rfc-editor.org/info/rfc6087>. > > > > [RFC6991] Schoenwaelder, J., Ed., "Common YANG Data Types", > > RFC 6991, DOI 10.17487/RFC6991, July 2013, > > <https://www.rfc-editor.org/info/rfc6991>. > > > > The format used to reference drafts vary in format, some use the > 'ietf-draft' > > prefix in the reference (e.g. > '[draft-ietf-i2nsf-sdn-ipsec-flow-protection]') > > and some don't (e.g. '[i2nsf-advanced-nsf-dm]') > > > > Oh. and it looks like the email address of the WG Chair (no less! :-) is > > spelled incorrectly: > > > > OLD: > > WG Chair: Linda Dunbar > > <mailto:Linda.duhbar@huawei.com> > > > > NEW: > > WG Chair: Linda Dunbar > > <mailto:Linda.dunbar@huawei.com> > > > > _______________________________________________ > > I2nsf mailing list > > I2nsf@ietf.org > > https://www.ietf.org/mailman/listinfo/i2nsf > > > > > > -- > > =========================== > > Mr. Jaehoon (Paul) Jeong, Ph.D. > > Associate Professor > > Department of Software > > Sungkyunkwan University > > Office: +82-31-299-4957 > > Email: jaehoon.paul@gmail.com, pauljeong@skku.edu > > Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php > > > > > > -- > > =========================== > > Mr. Jaehoon (Paul) Jeong, Ph.D. > > Associate Professor > > Department of Software > > Sungkyunkwan University > > Office: +82-31-299-4957 > > Email: jaehoon.paul@gmail.com, pauljeong@skku.edu > > Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php > > > > > > -- > > =========================== > > Mr. Jaehoon (Paul) Jeong, Ph.D. > > Associate Professor > > Department of Software > > Sungkyunkwan University > > Office: +82-31-299-4957 > > Email: jaehoon.paul@gmail.com, pauljeong@skku.edu > > Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php > > _______________________________________________ > > yang-doctors mailing list > > yang-doctors@ietf.org > > https://www.ietf.org/mailman/listinfo/yang-doctors > > -- =========================== Mr. Jaehoon (Paul) Jeong, Ph.D. Associate Professor Department of Software Sungkyunkwan University Office: +82-31-299-4957 Email: jaehoon.paul@gmail.com, pauljeong@skku.edu Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php <http://cpslab.skku.edu/people-jaehoon-jeong.php>
- [I2nsf] Yangdoctors last call review of draft-iet… Carl Moberg via Datatracker
- Re: [I2nsf] [yang-doctors] Yangdoctors last call … Mahesh Jethanandani
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [yang-doctors] Yangdoctors last call … Carl Moberg
- Re: [I2nsf] [yang-doctors] Yangdoctors last call … Mr. Jaehoon Paul Jeong