Re: [I2nsf] [yang-doctors] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04

Carl Moberg <calle@tail-f.com> Wed, 27 November 2019 13:37 UTC

Return-Path: <calle@tail-f.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C17D91208C2; Wed, 27 Nov 2019 05:37:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P64QDYVajr1P; Wed, 27 Nov 2019 05:37:12 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id EE1511200A1; Wed, 27 Nov 2019 05:37:11 -0800 (PST)
Received: from [10.147.40.85] (unknown [173.38.220.33]) by mail.tail-f.com (Postfix) with ESMTPSA id 340D71AE0290; Wed, 27 Nov 2019 14:37:10 +0100 (CET)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
From: Carl Moberg <calle@tail-f.com>
In-Reply-To: <CAPK2Dey_kMTYouwFxkyBSpNhmnCQNwdJrUBYR9yw7Vhz5A_OXA@mail.gmail.com>
Date: Wed, 27 Nov 2019 14:37:09 +0100
Cc: "i2nsf@ietf.org" <i2nsf@ietf.org>, YANG Doctors <yang-doctors@ietf.org>, draft-ietf-i2nsf-capability-data-model.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <33AC564A-5DEA-42CD-9039-12BCB09BD046@tail-f.com>
References: <156323104862.27197.7523333169738579602@ietfa.amsl.com> <CAPK2DexfAtNCx5SfG6tjgVjbWc0Bo5z_uviYD58exUxRa08h=A@mail.gmail.com> <CAPK2Deym+xgmjPBgUiiJydWT2ETmXpQ-0OU--L4qQcDYvoh+xg@mail.gmail.com> <CAPK2Dey_kMTYouwFxkyBSpNhmnCQNwdJrUBYR9yw7Vhz5A_OXA@mail.gmail.com>
To: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
X-Mailer: Apple Mail (2.3601.0.10)
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/AvjeoJdLPKoBf_0vam5gQ0qYGuE>
Subject: Re: [I2nsf] [yang-doctors] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Nov 2019 13:37:14 -0000

Paul,

 Yes! Updated and done.


> On 26 Nov 2019, at 13:52, Mr. Jaehoon Paul Jeong <jaehoon.paul@gmail.com> wrote:
> 
> Hi Carl,
> Did you have a change to check our revision for I2NSF Capability Draft?
> 
> Thanks.
> 
> Best Regards,
> Paul
> 
> On Wed, Nov 6, 2019 at 10:56 AM Mr. Jaehoon Paul Jeong <jaehoon.paul@gmail.com> wrote:
> Hi Carl,
> I believe that I have addressed your comments on I2NSF Capability Data Model:
> https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05 
> 
> If you are satisfied with the revision, could you update the Review result in the following page?
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-capability-data-model-04-yangdoctors-lc-moberg-2019-07-15/ 
>  
> Thanks.
> 
> Best Regards,
> Paul 
> 
> On Thu, Jul 25, 2019 at 11:29 PM Mr. Jaehoon Paul Jeong <jaehoon.paul@gmail.com> wrote:
> Hi Carl,
> Here is the revision letter for the revised draft, reflecting your comments along with the revised draft:
> https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05 
> 
> This revision letter first addresses the comments from Acee and then
> addresses your comments from page 6.
>  
> If you have further comments and questions, please let me know.
> 
> Thanks.
> 
> Best Regards,
> Paul
> 
> On Mon, Jul 15, 2019 at 6:50 PM Carl Moberg via Datatracker <noreply@ietf.org> wrote:
> Reviewer: Carl Moberg
> Review result: Almost Ready
> 
> This is my review of the ietf-i2nsf-capability@2019-03-28.yang module as part
> of draft-ietf-i2nsf-capability-data-model-04.
> 
> The module cleanly passes validation (i.e. 'pyang --ietf') and I have been able
> to load it into a NETCONF server and done basic operations on it (add, query
> for and remove capabilties).
> 
> I have one high-level concern and a couple of nits.
> 
> This document defines "a YANG data model for capabilities of various Network
> Security Functions (NSFs)". After my in initial reading of the draft and I2RS
> background material I found it hard to understand which of the components in
> the I2RS reference architecture that would implement the YANG module (i.e.
> provide NETCONF or RESTCONF protocol implementations). The draft says the
> following:
> 
> """
>    This document provides a data model using YANG [RFC6020][RFC7950]
>    that defines the capabilities of NSFs to centrally manage
>    capabilities of those security devices.  The security devices can
>    register their own capabilities into Network Operator Management
>    (Mgmt) Systems (i.e., Security Controllers) with this YANG data model
>    through the registration interface [RFC8329].
> """
> 
> This seems to point in the direction of the 'Network Operator Managemen (Mgmt)
> Systems' as the location of the YANG datastore, i.e. where this module would be
> implemented.
> 
> My main question then becomes; given the fact that the top-level element of the
> data model is a container ('nsf') with a set of leaf-lists and containers under
> it, this model seems to only allow for the registration of one (1) single NSF.
> This seems to be also supported by the language of the description clauses
> referencing "network service function" in singular.
> 
> I would intuitively expect such a registry to be able to store the capabilities
> of a multitude of NSFs. I would appreciate if the authors could clarify the
> intent and expected usage of the model based on this question.
> 
> Given my initial struggles I would suggest adding clearer upfront language on
> the location of the module and the addition of usage examples of e.g. NSFs
> registering capability instances to registry. (See
> https://tools.ietf.org/html/rfc8407#section-3.12). I believe that would provide
> additional and helpful context to the usage of the model.
> 
> The following drafts are referenced in 'reference' and 'description' fields in
> the YANG module, but are missing from the Informative References section of the
> draft. (See https://tools.ietf.org/html/rfc8407#appendix-A.) -
> draft-hong-i2nsf-nsf-monitoring-data-model-06 - draft-ietf-i2nsf-capability-04
> - draft-dong-i2nsf-asf-config-01
> 
> The modules consistently seem to spell out 'capabilities', but shorten
> 'capability' to 'capa', e.g.:
> 
>      +--rw condition-capabilities
>      |  +--rw generic-nsf-capabilities
>      |  |  +--rw ipv4-capa*   identityref
> 
> I would suggest following https://tools.ietf.org/html/rfc8407#section-4.3.1 and
> spell out 'capability' unless the authors are of the opinion that 'capa' is a
> well known abbreviation.
> 
> Remove the following references (they're not used):
> 
>    [RFC6087]  Bierman, A., "Guidelines for Authors and Reviewers of YANG
>               Data Model Documents", RFC 6087, DOI 10.17487/RFC6087,
>               January 2011, <https://www.rfc-editor.org/info/rfc6087>.
> 
>    [RFC6991]  Schoenwaelder, J., Ed., "Common YANG Data Types",
>               RFC 6991, DOI 10.17487/RFC6991, July 2013,
>               <https://www.rfc-editor.org/info/rfc6991>.
> 
> The format used to reference drafts vary in format, some use the 'ietf-draft'
> prefix in the reference (e.g. '[draft-ietf-i2nsf-sdn-ipsec-flow-protection]')
> and some don't (e.g. '[i2nsf-advanced-nsf-dm]')
> 
> Oh. and it looks like the email address of the WG Chair (no less! :-) is
> spelled incorrectly:
> 
> OLD:
>      WG Chair: Linda Dunbar
>      <mailto:Linda.duhbar@huawei.com>
> 
> NEW:
>      WG Chair: Linda Dunbar
>      <mailto:Linda.dunbar@huawei.com>
> 
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org
> https://www.ietf.org/mailman/listinfo/i2nsf
> 
> 
> -- 
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> 
> 
> -- 
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> 
> 
> -- 
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> _______________________________________________
> yang-doctors mailing list
> yang-doctors@ietf.org
> https://www.ietf.org/mailman/listinfo/yang-doctors