[I2nsf] YANG Doctors Working Group Last Call Review of draft-ietf-i2nsf-capability-data-model-04.txt
"Acee Lindem (acee)" <acee@cisco.com> Tue, 18 June 2019 18:53 UTC
Return-Path: <acee@cisco.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F26B71201CA; Tue, 18 Jun 2019 11:53:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.941
X-Spam-Level:
X-Spam-Status: No, score=-10.941 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, HTML_TAG_BALANCE_BODY=1.157, MANY_SPAN_IN_TEXT=1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=BgSndnY3; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=NGVyNr/G
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a9uHcjZcOP66; Tue, 18 Jun 2019 11:53:29 -0700 (PDT)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C92B120048; Tue, 18 Jun 2019 11:53:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=454778; q=dns/txt; s=iport; t=1560884008; x=1562093608; h=from:to:cc:subject:date:message-id:mime-version; bh=l5Zg8Iu0oyotiBPU++9P5XytW84PkQNuIjEbshcRODE=; b=BgSndnY3rOb71ekT9L3mmazIRXCLYZeBr+gGZ9iNJh+Ujd7CduJuWqvG FeEg6grQg/KGUX/hfb7rl4O9HCyBEnMiaJlBZsvp0V7tS0SdPRTrXtC93 4uw40U7sXWZlJKxDekeYvlkcUki59lMPXE1crmn/5X9Upef/MVjDZlCGL Q=;
X-Files: Diff_ draft-ietf-i2nsf-capability-data-model-04.txt.orig - draft-ietf-i2nsf-capability-data-model-04.txt.html : 329291
IronPort-PHdr: 9a23:pnTSuRaWJiAharUpf/35JvD/LSx94ef9IxIV55w7irlHbqWk+dH4MVfC4el20QKbRp3VvvRDjeee87vtX2AN+96giDgDa9QNHwQAld1QmgUhBMCfDkiuJfXnYgQxHd9JUxlu+HToeUU=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DQBADAMQld/5JdJa2GbQSWeKYCDwSBCguGETq9B48xg3U
X-IronPort-AV: E=Sophos;i="5.63,390,1557187200"; d="html'217?scan'217,208,217";a="564579567"
Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 18 Jun 2019 18:53:27 +0000
Received: from XCH-ALN-011.cisco.com (xch-aln-011.cisco.com [173.36.7.21]) by rcdn-core-10.cisco.com (8.15.2/8.15.2) with ESMTPS id x5IIrRG0026963 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 18 Jun 2019 18:53:27 GMT
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by XCH-ALN-011.cisco.com (173.36.7.21) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Jun 2019 13:53:26 -0500
Received: from xhs-aln-002.cisco.com (173.37.135.119) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Jun 2019 13:53:25 -0500
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 18 Jun 2019 13:53:25 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1bJrU/a+hai5FDeztyj3DHPJ57joR3+ayTADnXD1gWU=; b=NGVyNr/Gq15v2xvqfUzQIWnppVUwlKdtCfdEwf6F0mlSWCZ8/QO7bg5/AjaI1NgtbSRrRgAvPbBqPNZKiC50E4UP059AmIBiXOlUBPMry7158+yNQeGFMJchRVzZVV+YJGgcCz8GjQoN/TddVqAZKuDWepw0/hTxq26n84DuKlg=
Received: from MWHPR11MB1902.namprd11.prod.outlook.com (10.175.53.139) by MWHPR11MB1663.namprd11.prod.outlook.com (10.172.54.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.11; Tue, 18 Jun 2019 18:53:24 +0000
Received: from MWHPR11MB1902.namprd11.prod.outlook.com ([fe80::f1d4:41cf:84d6:ff73]) by MWHPR11MB1902.namprd11.prod.outlook.com ([fe80::f1d4:41cf:84d6:ff73%2]) with mapi id 15.20.1987.014; Tue, 18 Jun 2019 18:53:24 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: "draft-ietf-i2nsf-capability-data-model@ietf.org" <draft-ietf-i2nsf-capability-data-model@ietf.org>
CC: yang-doctors <yang-doctors-bounces@ietf.org>, "i2nsf-ads@ietf.org" <i2nsf-ads@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>
Thread-Topic: YANG Doctors Working Group Last Call Review of draft-ietf-i2nsf-capability-data-model-04.txt
Thread-Index: AQHVJgcbwf2F7ELP4k2dUEadu6w7Mw==
Date: Tue, 18 Jun 2019 18:53:24 +0000
Message-ID: <449F9B8C-235F-4E65-9FE3-4D34AB063FC4@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c8:1003::c6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8670de0f-acf8-4bd2-517c-08d6f41e3dec
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(49563074)(7193020); SRVR:MWHPR11MB1663;
x-ms-traffictypediagnostic: MWHPR11MB1663:
x-ms-exchange-purlcount: 12
x-microsoft-antispam-prvs: <MWHPR11MB1663480DDCC2D579CDB27697C2EA0@MWHPR11MB1663.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 007271867D
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(39860400002)(396003)(366004)(346002)(199004)(189003)(6436002)(8936002)(66616009)(5640700003)(71190400001)(76116006)(71200400001)(91956017)(2351001)(186003)(6486002)(6916009)(6512007)(2906002)(478600001)(99286004)(54906003)(36756003)(6306002)(53936002)(6116002)(6506007)(14454004)(102836004)(4326008)(86362001)(7736002)(966005)(66574012)(476003)(486006)(305945005)(99936001)(14444005)(2616005)(66946007)(33656002)(256004)(73956011)(46003)(5024004)(2501003)(66446008)(66556008)(64756008)(450100002)(5660300002)(66476007)(81166006)(8676002)(81156014)(25786009)(316002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB1663; H:MWHPR11MB1902.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: +Jnk2Uf+RmX6rs+z5zlDMO014u6yPw0E1uucE2obvDB2eALSGOxWUqfFpxuZGQ5mtlFki543okN5MPakh5EckQ9ll8DwmhLgM357lbxu3BdpNynMNp/fpYbzS8B2Ngf3msXymDPkj+TjcHbhLlZDPDnC25ye42QN5xEARc6lEtaXiUP3HisUis1P1Pq78kNZAu1Z+VmrxdZvCIx2LnoC+5VReSFWAuDhpFvuzq91jkzOrAaRNg75V8ZM13uBSGhey62GrUZUdCDk/dSYQ2AA+R+CW1K2nQN38x3cqAKsYn90gEFqJNTrPKv9cMURRaNwsHPFr8EKufQ5C8PTXSZRod0NVQQHZT2t+Bzu3EAZo+rYR2aUt23RHGEhLduU/O8U1UXAtooDmjVEaPv/AfBCCeMb5NJMEYcsgqmvSOhpOkA=
Content-Type: multipart/mixed; boundary="_002_449F9B8C235F4E659FE34D34AB063FC4ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8670de0f-acf8-4bd2-517c-08d6f41e3dec
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2019 18:53:24.1815 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: acee@cisco.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1663
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.21, xch-aln-011.cisco.com
X-Outbound-Node: rcdn-core-10.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/eUo7M6MpumW4MIQRgPbe5Lshr1o>
Subject: [I2nsf] YANG Doctors Working Group Last Call Review of draft-ietf-i2nsf-capability-data-model-04.txt
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jun 2019 18:53:40 -0000
Document: draft-ietf-i2nsf-capability-data-model-04.txt Reviewer: Acee Lindem Review Date: June 18, 2019 Review Type: Working Group Last Call Intended Status: Standards Track Summary: Not ready for publication Modules: "ietf-i2nsf-capability@2019-03-28.yang" Tech Summary: The model is logically structured and seems to fulfill its intended purpose. The "Overview" section defines the usage, context, and usage of the model, i.e., it is limited to the NSF capability registration interface. However, the draft/model is very rough and not ready for working group last call. It seems that it has not gotten adequate review by the chairs and other members of the I2NSF Working Group. Major Comments: 1. The "Security Considerations" in section 8 do not conform to the recommended template in https://trac.ietf.org/trac/ops/wiki/yang-security- guidelines> 2. The document is missing XML or JSON examples. Minor Comments: 1. Section 3.1 should reference RFC8340 rather than attempting to include tree diagram formatting semantics. 2. Much of the text is very hard to read and awkwardly worded. There are some instances of sentence fragments. I starting trying to remedy this but found I was rewriting the entire draft and, in many cases, I wasn't sure my edits matched the original intent. See the attached diff with suggested edits. 3. "iicapa" is a poor choice for default model prefix - I suggest "nsfcap". It is just as concise but actually expands to something meaningful. 4. Similar to the text in the narrative sections of the draft, the text in the YANG model description statements is very awkwardly worded. 5. What are the references for the ipv4-sameip and ipv4-geoip conditions? 6. Add reference for egress-action-capa. 7. RFC 2460 is obsoleted by RFC 8200. 8. Suggest hyphenation of identifiers ipv4-same-ip, ipv4-geo-ip, and ipv6-ip-opts. 9. Suggest hyphenation of anti-virus and anti-ddos both in identifiers and in the text. 10. Suggest providing a definitions for absolute and periodic time. 11. The References do not include all the RFCs referenced by YANG model reference statements. Thanks, Acee
- [I2nsf] YANG Doctors Working Group Last Call Revi… Acee Lindem (acee)
- Re: [I2nsf] YANG Doctors Working Group Last Call … Mr. Jaehoon Paul Jeong