Re: [I2nsf] YANG Doctors Working Group Last Call Review for draft-ietf-i2nsf-nsf-facing-interface-dm-06
"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Wed, 06 November 2019 02:09 UTC
Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57DEA1202DD; Tue, 5 Nov 2019 18:09:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.988
X-Spam-Level:
X-Spam-Status: No, score=-1.988 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HK_NAME_FM_MR_MRS=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uUfhwpoGHyvM; Tue, 5 Nov 2019 18:09:15 -0800 (PST)
Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7167F120274; Tue, 5 Nov 2019 18:09:14 -0800 (PST)
Received: by mail-lj1-x230.google.com with SMTP id l20so5513813lje.4; Tue, 05 Nov 2019 18:09:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=noOKCltMYtl7DiUaN44LN8Sa2Pgsh2Cvm25G9YD7DY0=; b=bG7tyL97v+5zaxARxI21CcP6aaI7TRuZ/xi9LVjytC0L30euxCUaWL645kROtrdEIy vcMS3W+ckrxJUB19j3FilXV/jywoX21SGMwpwTh2feRfatFNtvxLjbT4D0VyZ0U60Wfe cSGUxT3lAKHk2eH0Uq6Ge+P5W8/0vCAm6mucZqYcqqB4zF8Dqq8qDoYAivBqMIS9gji0 Bs2vefWhg2LilIw5qHld1VQLHfTTNkpSMTrHewz69h11hwJW5b5KGxvYxyTqX0h9XiIY RqxxA47pSshNlZfn9m/Cet67U7pll21KBJuPVP5Yl/tdnn5skkG2KoceCeJP5HHyQc1L ZciQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=noOKCltMYtl7DiUaN44LN8Sa2Pgsh2Cvm25G9YD7DY0=; b=Bx6HEy8e/4rtmH3AScTw0L9UtXD8gJ5ZOi+S5BaIGe00KuuDBd7swJ7OcbVVqG56NL ZRDaQu830P+I80dJGtwWOtDqkok85UYogafdUwm4qs7/zQI5ZvqHFXpwqUb+z4b/zDKX w0XV8rr+s8GL+lsRnj81Y01lPoOSDvJ/nESnsfhkiNelt0ln59hNDtkT9INeYcG/lylg E4okShRcWkf0eYoXsdJF0EUtYn6GZZsm1KKdPk5zj1VyuBC2xRUSiQWzQFfEOfdqTk0T j0suVCV9E96re0zsRuBNPd+0ON58eCqN43W0yIKsWDYpBgMaEwoJzrw6EDDeKlt35NZ/ elDw==
X-Gm-Message-State: APjAAAWbf5scFW8vcpOeHwJQPm85b//bztGH9Yxa91KbR2y+s7sqgcno PPQuehQIxCC59Gjrokf6hzggOYlR5zfsnpgl4lY=
X-Google-Smtp-Source: APXvYqxrdh6HoOjISNdR+wMw26MdnxXq3bBArL9Uk4URCq1Z3tTPgILjOl0crajcnjjaAwN+/aMI1sg7J5t05cQSCPI=
X-Received: by 2002:a2e:854b:: with SMTP id u11mr22378066ljj.85.1573006152357; Tue, 05 Nov 2019 18:09:12 -0800 (PST)
MIME-Version: 1.0
References: <E650398F-D50C-486D-9717-90BA617BA0A1@cisco.com> <CAPK2Dez5b4pL9+_UPxf77jcPQMygVG-=eaMEd+nMJoJ9Dg92vg@mail.gmail.com>
In-Reply-To: <CAPK2Dez5b4pL9+_UPxf77jcPQMygVG-=eaMEd+nMJoJ9Dg92vg@mail.gmail.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Wed, 06 Nov 2019 11:08:36 +0900
Message-ID: <CAPK2Dey1_c48jqoG+vqUZOSBBEkfBCxo4R5iUbtaZR96Hi_dQg@mail.gmail.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
Cc: "draft-ietf-i2nsf-nsf-facing-interface-dm@ietf.org" <draft-ietf-i2nsf-nsf-facing-interface-dm@ietf.org>, "i2nsf-ads@ietf.org" <i2nsf-ads@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, YANG Doctors <yang-doctors@ietf.org>, skku-iotlab-members@googlegroups.com, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000f0da6c0596a408bf"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/g4iVrRT6w_z8fJQTKUQu4QrorVk>
Subject: Re: [I2nsf] YANG Doctors Working Group Last Call Review for draft-ietf-i2nsf-nsf-facing-interface-dm-06
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 02:09:17 -0000
Hi Acee, I believe that I have addressed your comments on I2NSF NSF-Facing Interface Data Model: https://tools.ietf.org/html/draft-ietf-i2nsf-nsf-facing-interface-dm-08 If you are satisfied with the revision, could you update the Review result in the following page? https://datatracker.ietf.org/doc/review-ietf-i2nsf-nsf-facing-interface-dm-06-yangdoctors-lc-lindem-2019-06-22/ Thanks. Best Regards, Paul On Mon, Nov 4, 2019 at 9:37 PM Mr. Jaehoon Paul Jeong < jaehoon.paul@gmail.com> wrote: > Hi Acee, > I have reflected all your comments in the revised I-D of NSF-Facing > Interface YANG Data Model: > https://tools.ietf.org/html/draft-ietf-i2nsf-nsf-facing-interface-dm-08 > > I attach the revision letter to explain how I reflected your comments on > each of your comments. > > If you have questions, please let me know. > > Best Regards, > Paul > > On Sun, Jun 23, 2019 at 3:03 AM Acee Lindem (acee) <acee@cisco.com> wrote: > >> I have reviewed this document as part of the YANG doctors directorate's >> >> ongoing effort to review all IETF documents being processed by the IESG. >> These >> >> comments were written with the intent of improving the operational >> aspects of the >> >> IETF drafts. Comments that are not addressed in last call may be included >> in AD reviews >> >> during the IESG review. Document editors and WG chairs should treat >> these comments >> >> just like any other early review comments. >> >> >> >> >> >> Document: draft-ietf-i2nsf-nsf-facing-interface-dm-06 >> >> Reviewer: Acee Lindem >> >> Review Date: June 22, 2019 >> >> Review Type: Working Group Last Call >> >> Intended Status: Standards Track >> >> Summary: Needs to go back to Working Group for rework and another WGLC >> >> >> >> Modules: "ietf-i2nsf-policy-rule-for-nsf@2019-06-12.yang" >> >> >> >> Tech Summary: The model defines different types of I2NSF security policy. >> Each >> >> is comprised of an event, a condition, and >> an action. There is >> >> significant overlap with other IETF models. >> Within I2NSF, there >> >> is repetition of definitions which needs to >> go into a common >> >> I2NSF types module. Additionally, the data >> descriptions were >> >> were done quickly and never reviewed or >> edited. I believe >> >> it needs to go back to the working group for >> another revision and >> >> working group last call. >> >> . >> >> >> >> Major Comments: >> >> >> >> 1. Why don't you leverage the definitions in RFC 8519 for packet >> matching? >> >> We don't need all this defined again. >> >> >> >> 2. Date and time are defined in RFC 6991. Why don't those suffice? >> >> >> >> 3. Refer to the intervals as "time-intervals" rather than "time-zones". >> >> The term "time-zone" has a completely different connotation. >> >> >> >> 4. What the "acl-number"? Also, ACLs are named (RFC 8519). Also, why >> >> define all the packet matching and then reference an ACL. >> >> >> >> 5. The descriptions are very awkwardly worded and in many cases simply >> >> repeat the data node or identify description without hyphens. I >> >> started trying to fix this but it was too much. I'll pass for on >> >> for some examples. There are enough co-authors and contributors that >> >> one would expect much better. >> >> >> >> 6. There is overlap of definitions with the I2NSF capabilities draft. >> >> The common types and identities should be factored into a common >> >> I2NSF types module. >> >> >> >> 7. The "Security Considerations" in section 8 do not conform to the >> >> recommended template in >> https://trac.ietf.org/trac/ops/wiki/yang-security- >> >> guidelines> >> >> >> >> >> >> Minor Comments: >> >> >> >> 1. Section 3.1 should reference RFC8340 rather than attempting to >> >> include tree diagram formatting semantics. >> >> >> >> 2. "iiprfn" is a poor choice for default model prefix - I suggest >> >> "nsfintf". It is only one character longer and actually is expands >> >> to something meaningful. >> >> >> >> 3. RFC 2460 is obsoleted by RFC 8200. >> >> >> >> 4. RFC 791 is the wrong reference for IPv4 TOS. It should be RFC 1394. >> >> >> >> 5. What is the IGRP protocol? I'm familiar with EIGRP but not IGRP. >> >> >> >> 6. What is the skip protocol? Is this about skipping the check? If so, >> >> why is it needed. >> >> >> >> 7. Reference for IPv6 ICMP should be RFC 2463. >> >> >> >> 8. Why do you include Photuris definitions? Nobody uses this. >> >> >> >> 9. Note that all the keys for all 'config true' lists must be >> >> unique so your specification in the description as well as >> >> 'mandatory true' are redundant for the 'rules' list. This >> >> mistake is in other lists as well. >> >> >> >> 10. What is 'during' time? >> >> >> >> 11. What is a "security-grp"? Is this a security-group? >> >> >> >> 12. The module prologue doesn't match the example in Appendix B of >> >> RFC 8407. >> >> >> >> 13. There needs to be a good definition of absolute and periodic >> >> time in the descriptions. >> >> >> >> 14. The References do not include all the RFCs referenced by YANG >> >> model reference statements. >> >> >> >> Nits: Will send diff to authors and i2nsf chairs as example of review >> that should be done on YANG documents prior to sending to YANG doctors. >> >> >> >> Thanks, >> Acee >> >> >> _______________________________________________ >> I2nsf mailing list >> I2nsf@ietf.org >> https://www.ietf.org/mailman/listinfo/i2nsf >> > > > -- > =========================== > Mr. Jaehoon (Paul) Jeong, Ph.D. > Associate Professor > Department of Software > Sungkyunkwan University > Office: +82-31-299-4957 > Email: jaehoon.paul@gmail.com, pauljeong@skku.edu > Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php > <http://cpslab.skku.edu/people-jaehoon-jeong.php> > -- =========================== Mr. Jaehoon (Paul) Jeong, Ph.D. Associate Professor Department of Software Sungkyunkwan University Office: +82-31-299-4957 Email: jaehoon.paul@gmail.com, pauljeong@skku.edu Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php <http://cpslab.skku.edu/people-jaehoon-jeong.php>
- [I2nsf] YANG Doctors Working Group Last Call Revi… Acee Lindem (acee)
- Re: [I2nsf] YANG Doctors Working Group Last Call … Mr. Jaehoon Paul Jeong
- Re: [I2nsf] YANG Doctors Working Group Last Call … Mr. Jaehoon Paul Jeong
- Re: [I2nsf] YANG Doctors Working Group Last Call … Acee Lindem (acee)
- Re: [I2nsf] YANG Doctors Working Group Last Call … Mr. Jaehoon Paul Jeong
- Re: [I2nsf] YANG Doctors Working Group Last Call … Acee Lindem (acee)
- Re: [I2nsf] YANG Doctors Working Group Last Call … Mr. Jaehoon Paul Jeong
- Re: [I2nsf] YANG Doctors Working Group Last Call … Mr. Jaehoon Paul Jeong
- Re: [I2nsf] YANG Doctors Working Group Last Call … Acee Lindem (acee)
- Re: [I2nsf] YANG Doctors Working Group Last Call … Mr. Jaehoon Paul Jeong