IETF Logo Mail Archive

Re: [I2nsf] YANG Doctors Working Group Last Call Review of draft-ietf-i2nsf-capability-data-model-04.txt

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Thu, 25 July 2019 14:05 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5BCB1200C1; Thu, 25 Jul 2019 07:05:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.488
X-Spam-Level:
X-Spam-Status: No, score=-0.488 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HK_NAME_FM_MR_MRS=1.499, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vo82DI40Wi2Q; Thu, 25 Jul 2019 07:05:26 -0700 (PDT)
Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1354D12019C; Thu, 25 Jul 2019 07:05:05 -0700 (PDT)
Received: by mail-wr1-x429.google.com with SMTP id n9so25858565wrr.4; Thu, 25 Jul 2019 07:05:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qmO8kqXyZvYEzKYsmPUnZPRYp44APpdJrVE1ymX8J1E=; b=O3OMNgrQ01iyt7Uh8n96ZLAfXWBv251lqN1F8QXATFRM2Y9P+VHC3m9DiQc0+kNjy3 KpAFroSRUumF3kgfXhqQRzQ+CoDhw5n88WvuyPw7geTOvSUu/YPg6kDB5ZWeAOyOplpZ Y/gC/yRf0g9I7FRFCbNOeOdZopUj2DYRWMeirxSdtSnJGifxcCu+Ne37f/ief72YTOYR yERIWDa/W+I7BbVJ+EJ6lS9bks8xOR6LI6BvCjulry3sxLrlHYwGe3nfp2gtLWJ2dWSm gGn23mAwjQCWdj2co7+uhuGDNa17w1iVfOG4tgZnWX+tJv/4yZAWplipsATPdf7Lx0Wc EypQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qmO8kqXyZvYEzKYsmPUnZPRYp44APpdJrVE1ymX8J1E=; b=Nz4fUriFx3CHBS/YC1p1kUOcUPuk4p43zU1PSXXMp3Ayh2pz687iVz9ckpGet/k9eX hXAl7KadRmXxIZZFQe2+GRRep3dZJD5gazbO53Q5bqlTLUstYPtFPCTzo4Np8Nv1FRIA 1URA0kw2KhC49NN+MsPaQhxCVTfHHuDEYpxGfrttHNia/yu/s+0V9ZXFzQEFmO7/GGvq dsmI2dR2uw9Poy1hr9O9WamxzAJX1CQLeEZ7skJUfwlXYYzn2V8OH+6CNZ1WqewiXElo k1rj9XFgw7J9CnTfrffC3q8/5V9+zFfmSpWzjlQSaYH+ahRzA1e/8t+xphZXVEfGALjp fc+Q==
X-Gm-Message-State: APjAAAXbMk038QjtUfNwJYILSpHVnPkknTveijjAtmTKrwvdNNecM9dr eW+9N9QDTp/VPgMgH3Gkg7eUCmExPOH2g16gSKRJc23zEPw=
X-Google-Smtp-Source: APXvYqys5NuWmc8wu7GDehWnfWHS+LE7fa1hS+0LKOdXuFL2yaSQb+cDmyT+X8tdsrVVBr/bAy6xzm5jm0582h4vaS4=
X-Received: by 2002:a5d:4a46:: with SMTP id v6mr94664012wrs.105.1564063502884; Thu, 25 Jul 2019 07:05:02 -0700 (PDT)
MIME-Version: 1.0
References: <AB210DB8-0137-41D6-9495-0B3FBE07343F@cisco.com>
In-Reply-To: <AB210DB8-0137-41D6-9495-0B3FBE07343F@cisco.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Thu, 25 Jul 2019 10:04:23 -0400
Message-ID: <CAPK2DezgBGPQW5jfLXcWTE8+S_4Hn+DDpWHzyRyw3tO2ygnEGQ@mail.gmail.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
Cc: "draft-ietf-i2nsf-capability-data-model@ietf.org" <draft-ietf-i2nsf-capability-data-model@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, yang-doctors <yang-doctors-bounces@ietf.org>, "i2nsf-ads@ietf.org" <i2nsf-ads@ietf.org>, skku_secu-brain_all@googlegroups.com
Content-Type: multipart/mixed; boundary="0000000000007f218f058e81e9fc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/n_mmd_rB2_KpFSD63E2n-24wwWo>
Subject: Re: [I2nsf] YANG Doctors Working Group Last Call Review of draft-ietf-i2nsf-capability-data-model-04.txt
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jul 2019 14:05:29 -0000

Hi Acee,
Here is the revision letter for the revised draft, reflecting your comments
along with the revised draft:
https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05

If you have further comments and questions, please let me know.

Thanks.

Best Regards,
Paul

On Tue, Jun 18, 2019 at 3:09 PM Acee Lindem (acee) <acee@cisco.com> wrote:

> Document: draft-ietf-i2nsf-capability-data-model-04.txt
> Reviewer: Acee Lindem
> Review Date: June 18, 2019
> Review Type: Working Group Last Call
> Intended Status: Standards Track
> Summary: Not ready for publication
>
> Modules: "ietf-i2nsf-capability@2019-03-28.yang"
>
> Tech Summary: The model is logically structured and seems to fulfill its
> intended purpose. The "Overview" section defines the usage, context, and
> usage of the model, i.e., it is limited to the NSF capability registration
> interface. However, the draft/model is very rough and not ready for
> working
> group last call. It seems that it has not gotten adequate review by the
> chairs
> and other members of the I2NSF Working Group.
>
> Major Comments:
>
>  1. The "Security Considerations" in section 8 do not conform to the
>     recommended template in
> https://trac.ietf.org/trac/ops/wiki/yang-security-
>     guidelines>
>
>  2. The document is missing XML or JSON examples.
>
>
> Minor Comments:
>
>  1. Section 3.1 should reference RFC8340 rather than attempting to
>     include tree diagram formatting semantics.
>
>  2. Much of the text is very hard to read and awkwardly worded. There
>     are some instances of sentence fragments. I starting trying to
>     remedy this but found I was rewriting the entire draft and, in
>     many cases, I wasn't sure my edits matched the original intent. I'll
>     send the attached diff with suggested edits to the authors - it was too
>     big to send to IETF lists.
>
>  3. "iicapa" is a poor choice for default model prefix - I suggest
>     "nsfcap". It is just as concise but actually expands to something
>      meaningful.
>
>  4. Similar to the text in the narrative sections of the draft, the text
> in the
>      YANG model description statements is very awkwardly worded.
>
>  5. What are the references for the ipv4-sameip and ipv4-geoip conditions?
>
>  6. Add reference for egress-action-capa.
>
>  7. RFC 2460 is obsoleted by RFC 8200.
>
>  8. Suggest hyphenation of identifiers ipv4-same-ip, ipv4-geo-ip, and
>     ipv6-ip-opts.
>
>  9. Suggest hyphenation of anti-virus and anti-ddos both in identifiers
>     and in the text.
>
> 10. Suggest providing a definitions for absolute and periodic time.
>
> 11. The References do not include all the RFCs referenced by YANG
>        model reference statements.
>
> Thanks,
> Acee
>
>
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org
> https://www.ietf.org/mailman/listinfo/i2nsf
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>

v2.23.0 | Report a Bug | By Email