Re: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Thu, 25 July 2019 14:30 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8A361201DB; Thu, 25 Jul 2019 07:30:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.488
X-Spam-Level:
X-Spam-Status: No, score=-0.488 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HK_NAME_FM_MR_MRS=1.499, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P70gh62CoBSM; Thu, 25 Jul 2019 07:30:32 -0700 (PDT)
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 690C11202B5; Thu, 25 Jul 2019 07:30:27 -0700 (PDT)
Received: by mail-wr1-x42a.google.com with SMTP id n9so51127645wru.0; Thu, 25 Jul 2019 07:30:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jvwHfIIN92qj+YOB65GjfYFjWxV5SyctW4FTE+zU2RA=; b=nEMEJsSWSQY9haRZl19xfgaDv3xvJ9O5MALh36FnjP9Ez2gJQqeBFirkgaraYSb8d+ caf/NETmBa8SwVRAyeYuiMmMy5yBe0lATRqrf96+MLyRKUbDYaf6hKuzzMVXVdQH0ezc s7DuI7XuFIfwt8bt5p4gaD7/NfzCcKC6Rp42GilXbQqf9Z3qlNXK5vLBKFd8ViGEVMdZ xUdtWY4ADN4zCELkXQU+WXy4EyKJX/5fOZjX5DbpUThG79cS+9evWeiOYBZqehqYBquV 7tAY+qiSh3QGQ3vnbnZarEQJ6XO0J5qdKLrBmeAhNVjyHyWPHJb+RBdYiSNzAD5OyMrr SzLQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jvwHfIIN92qj+YOB65GjfYFjWxV5SyctW4FTE+zU2RA=; b=CDfjhkLfPOqi7p8n146J7+7uzjhIQrOk9vehaCwjZOxq6tX4JKqGtMsiEWRj3PJTr/ DpNooF1Wq35xoccBG/f0ptk5jt6q147xCGOqC+3+UbQR41mrrKYqjjPmRE3WnT8ksagZ W2Ll8y8vtV3Q67/4TTDeU2cwnPj9boFRRl1OkyZMMFCVexEKn8V4si4ygu0UUSLyicbV nCJgpC4WCFw85o56G1gSRylYN4VceVv7mux5YANRG1AKY7VeQBgwfXWkXKkWszRu+EUB mL+t/xvxu4I0xQojZ9T1OyWdsroPk3T1Cc/sQwJdF07zox9lwe5wzZDD3Vmzv0Y3DS2u c7UA==
X-Gm-Message-State: APjAAAXvQ8UGQEcZpAvLUmLmLW5nSsA1gO4oyJ3ZM1wBYw5E3jYFsy3f eXq1W4yYLFXJyW9bT+xHItnOdKrVGXvBSdpYBBx/SSZ7
X-Google-Smtp-Source: APXvYqxEAI3eI14TVVchAxwM+tFbudzbLxQDwOeYx37geQA+C5/SQMYBWr65E9DCHqPj+a+boNKHKfaZxRc3s2TNy6Y=
X-Received: by 2002:adf:f281:: with SMTP id k1mr7423573wro.154.1564065025295; Thu, 25 Jul 2019 07:30:25 -0700 (PDT)
MIME-Version: 1.0
References: <156323104862.27197.7523333169738579602@ietfa.amsl.com>
In-Reply-To: <156323104862.27197.7523333169738579602@ietfa.amsl.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Thu, 25 Jul 2019 10:29:47 -0400
Message-ID: <CAPK2DexfAtNCx5SfG6tjgVjbWc0Bo5z_uviYD58exUxRa08h=A@mail.gmail.com>
To: Carl Moberg <calle@tail-f.com>
Cc: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, draft-ietf-i2nsf-capability-data-model.all@ietf.org, skku_secu-brain_all@googlegroups.com, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000003d3354058e8244a5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/pyAp5GMb8yjwOOC8Ql8_4ykkKj4>
Subject: Re: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jul 2019 14:30:35 -0000

Hi Carl,
Here is the revision letter for the revised draft, reflecting your comments
along with the revised draft:
https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05

This revision letter first addresses the comments from Acee and then
addresses your comments from page 6.

If you have further comments and questions, please let me know.

Thanks.

Best Regards,
Paul

On Mon, Jul 15, 2019 at 6:50 PM Carl Moberg via Datatracker <
noreply@ietf.org>; wrote:

> Reviewer: Carl Moberg
> Review result: Almost Ready
>
> This is my review of the ietf-i2nsf-capability@2019-03-28.yang module as
> part
> of draft-ietf-i2nsf-capability-data-model-04.
>
> The module cleanly passes validation (i.e. 'pyang --ietf') and I have been
> able
> to load it into a NETCONF server and done basic operations on it (add,
> query
> for and remove capabilties).
>
> I have one high-level concern and a couple of nits.
>
> This document defines "a YANG data model for capabilities of various
> Network
> Security Functions (NSFs)". After my in initial reading of the draft and
> I2RS
> background material I found it hard to understand which of the components
> in
> the I2RS reference architecture that would implement the YANG module (i.e.
> provide NETCONF or RESTCONF protocol implementations). The draft says the
> following:
>
> """
>    This document provides a data model using YANG [RFC6020][RFC7950]
>    that defines the capabilities of NSFs to centrally manage
>    capabilities of those security devices.  The security devices can
>    register their own capabilities into Network Operator Management
>    (Mgmt) Systems (i.e., Security Controllers) with this YANG data model
>    through the registration interface [RFC8329].
> """
>
> This seems to point in the direction of the 'Network Operator Managemen
> (Mgmt)
> Systems' as the location of the YANG datastore, i.e. where this module
> would be
> implemented.
>
> My main question then becomes; given the fact that the top-level element
> of the
> data model is a container ('nsf') with a set of leaf-lists and containers
> under
> it, this model seems to only allow for the registration of one (1) single
> NSF.
> This seems to be also supported by the language of the description clauses
> referencing "network service function" in singular.
>
> I would intuitively expect such a registry to be able to store the
> capabilities
> of a multitude of NSFs. I would appreciate if the authors could clarify the
> intent and expected usage of the model based on this question.
>
> Given my initial struggles I would suggest adding clearer upfront language
> on
> the location of the module and the addition of usage examples of e.g. NSFs
> registering capability instances to registry. (See
> https://tools.ietf.org/html/rfc8407#section-3.12). I believe that would
> provide
> additional and helpful context to the usage of the model.
>
> The following drafts are referenced in 'reference' and 'description'
> fields in
> the YANG module, but are missing from the Informative References section
> of the
> draft. (See https://tools.ietf.org/html/rfc8407#appendix-A.) -
> draft-hong-i2nsf-nsf-monitoring-data-model-06 -
> draft-ietf-i2nsf-capability-04
> - draft-dong-i2nsf-asf-config-01
>
> The modules consistently seem to spell out 'capabilities', but shorten
> 'capability' to 'capa', e.g.:
>
>      +--rw condition-capabilities
>      |  +--rw generic-nsf-capabilities
>      |  |  +--rw ipv4-capa*   identityref
>
> I would suggest following
> https://tools.ietf.org/html/rfc8407#section-4.3.1 and
> spell out 'capability' unless the authors are of the opinion that 'capa'
> is a
> well known abbreviation.
>
> Remove the following references (they're not used):
>
>    [RFC6087]  Bierman, A., "Guidelines for Authors and Reviewers of YANG
>               Data Model Documents", RFC 6087, DOI 10.17487/RFC6087,
>               January 2011, <https://www.rfc-editor.org/info/rfc6087>;.
>
>    [RFC6991]  Schoenwaelder, J., Ed., "Common YANG Data Types",
>               RFC 6991, DOI 10.17487/RFC6991, July 2013,
>               <https://www.rfc-editor.org/info/rfc6991>;.
>
> The format used to reference drafts vary in format, some use the
> 'ietf-draft'
> prefix in the reference (e.g.
> '[draft-ietf-i2nsf-sdn-ipsec-flow-protection]')
> and some don't (e.g. '[i2nsf-advanced-nsf-dm]')
>
> Oh. and it looks like the email address of the WG Chair (no less! :-) is
> spelled incorrectly:
>
> OLD:
>      WG Chair: Linda Dunbar
>      <mailto:Linda.duhbar@huawei.com>
>
> NEW:
>      WG Chair: Linda Dunbar
>      <mailto:Linda.dunbar@huawei.com>
>
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org
> https://www.ietf.org/mailman/listinfo/i2nsf
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>