Re: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Tue, 21 January 2020 11:09 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1C75120091; Tue, 21 Jan 2020 03:09:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.977
X-Spam-Level:
X-Spam-Status: No, score=-1.977 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01, T_HK_NAME_FM_MR_MRS=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qfrtkpClGN9W; Tue, 21 Jan 2020 03:09:11 -0800 (PST)
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EFF42120077; Tue, 21 Jan 2020 03:09:09 -0800 (PST)
Received: by mail-lj1-x233.google.com with SMTP id j1so2315964lja.2; Tue, 21 Jan 2020 03:09:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I276rhZQycVVPVdrig0r115RpZz6eYJDJNylz/rvO0I=; b=jI9hCAsVK7O1CR1+KMmmRcWVc49BCyOJt1JL470J+vnpdlOJKD+Jl9Ietd2P9mrtwQ vKcTLNTjE8XQk1vEcQAwPQU3yEicpPpWmr9l2jJ+vbDHSt0TBLYjB1vS2VcFNs7wrkNc N7vzXepfClof+p9P9bOT0ORene5wi2Iix3KMPFIAHwMGdXOZ0U/I4SfSreAzkvf96Qlw ZG7WwJtplmvkCyHQPtx7svikReI/rSJWNum19qLygJ0TTHMe2HD21+NdvnccDQipG7pD j4/OV1a3zWYochBxFaABIWTkEPMeXXWfKYSQh1I5hXNjQ6ebQ1FsaxibcE0zaznMZEOB vWeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I276rhZQycVVPVdrig0r115RpZz6eYJDJNylz/rvO0I=; b=oa3XAljRJdboCksdf1TnfMqR6kLMTvQM2douE6tgwaEC2gPITCW3sU0P3n3AsOFG12 Hj+mOwsvxw8qD3N5S65Rseo/9V7AKZl1P8UJInk3zKZi8CeDyRs5JPwaF1Vz6kXoMizq tpX2IGSZoduYh5wchDgaTNZ04w0k+cK0QaqCC+/phu/aTSi6GM3HIDmtpefkXP1bYFgK kkMWJEHO/YQpF8PHDvVOw4UTyFuS+CFjgP1waAXTTWW67YskqK0XPpWkGrByr+mRoyXX MwyhaeBAlwNo7RbgWrPJXYeuJUWgljDoV+4hpT4Yc/VQa8U6JhoBaORPdA4J+iEu7bd8 IDwQ==
X-Gm-Message-State: APjAAAV8R78zqcarHPXKQn9fp8OfUNI3YAxfolFJhiUs8H/X70yzDmDC 7mulnxowlC6xzALAMZZSH9D7y5xJos+9x0d90Uo=
X-Google-Smtp-Source: APXvYqwZ+a7pZdQpsXzAX3NlW8ecVakOOkdMAn/sng51LObkMdKc4G8a9SqQMzdFG/4GNnm+F5EhWp1gVfg56D9C++E=
X-Received: by 2002:a2e:95c4:: with SMTP id y4mr16415975ljh.38.1579604947151; Tue, 21 Jan 2020 03:09:07 -0800 (PST)
MIME-Version: 1.0
References: <156175664267.21931.10329030969352120108@ietfa.amsl.com> <CAPK2DezmXhBA39GFMrU6tYFte_rDK+DE=WyWpzSNFMvnNU+xGQ@mail.gmail.com> <CAPK2Deym5jVmi4JKekRVznpNCkO_x8PN7jz7DLXkgUNZ9V4uUw@mail.gmail.com> <47E6993E-1045-4B29-B814-E7185516B272@cisco.com>
In-Reply-To: <47E6993E-1045-4B29-B814-E7185516B272@cisco.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Tue, 21 Jan 2020 20:08:28 +0900
Message-ID: <CAPK2DexseZBxXZthOU3wjyDnXPGe3PYrNvbcC-JO8+8JjypM4w@mail.gmail.com>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
Cc: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, Sangwon Hyun <swhyun77@gmail.com>, skku-iotlab-members <skku-iotlab-members@googlegroups.com>, Patrick Lingga <patricklink888@gmail.com>, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000c2d5de059ca46f5a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/qZWm__IpqAFlP2Gc0f-GbBFnQSA>
Subject: Re: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jan 2020 11:09:16 -0000

Hi Reshad,
We authors have addressed your comments with the following revision:
https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-06

I attach the revision letter to show how to address your comments.

Could your check this revision and proceed with the YANG review update?

Thanks.

Best Regards,
Paul


On Tue, Nov 12, 2019 at 1:58 AM Reshad Rahman (rrahman) <rrahman@cisco.com>
wrote:

> Hi Paul,
>
>
>
> I have done another review (I don’t think an automated email got sent
> out).
>
>
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/
>
>
>
> YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-05 (by
> Reshad Rahman)
>
>
>
> Thank you for addressing comments from my earlier review @
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/
>
>
>
> Major comments/questions:
>
> - There is a YANG warning on the datatracker page:
>
> ietf-i2nsf-reg-interface@2019-07-24.yang:54: warning: RFC 8407: 3.1: The
> IETF Trust Copyright statement seems to be missing (see pyang --ietf-help
> for details).
>
> To fix this, in the YANG module remove the <> around 2019: Copyright (c)
> <2019>
>
>
>
> - For contact in YANG module, please remove WG chair info (see RFC8407
> appendix B for an example)
>
>
>
> - For the revision in YANg module, put "Initial version" (even though it's
> the 5th revision)
>
>
>
> - Why define a union of ipv4-address and ipv6-address in typedef
> nsf-address, why not reuse existing ip-address type from RFC6021?
>
>
>
> - For bandwidth, is there a reason why it's limited to uint16? Even though
> 65Tbps is a lot, I wouldn't limit it to uint16. And aren't there any
> use-cases for bandwidth smaller than 1 Gbps? If yes, use e.g Mbps as unit
> and use uint32 instead of uint16? Please use units statement.
>
> - It is not clear to me what’s the distinction between nsf-name and
> nsf-instance-name. In Examples 4 and 5, they have the same value, but not
> in Example 3.  Might be worth clarifying or giving the same name.
>
>
>
> - Having nsf or i2nsf in many node names is redundant, since NSF or I2NSF
> is in the higher level container name.  e.g, in NSF Capability Registration
> all nodes seem to have i2nsf or nsf in their name.
>
>
>
> - There seems to be some indentation issues in the YANG  module (e.g. P16)
>
>
>
> - Abide by order in RFC8407 Appendix B. e.g. RPC statements should be
> after groupings.
>
>
>
> Nits:
>
>
>
> - Appendix B: Managmenet -> Management
>
>
>
> - Section 6.2: capailities -> capabilities
>
>
>
> - Example 5: space in "http_and_h ttps_flood_mitigation_capability"
>
>
>
> Regards,
>
> Reshad.
>
>
>
>
>
> Regards,
>
> Reshad.
>
>
>
> *From: *"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
> *Date: *Tuesday, November 5, 2019 at 9:02 PM
> *To: *"Reshad Rahman (rrahman)" <rrahman@cisco.com>
> *Cc: *YANG Doctors <yang-doctors@ietf.org>rg>, "i2nsf@ietf.org" <
> i2nsf@ietf.org>gt;, "draft-ietf-i2nsf-registration-interface-dm.all@ietf.org"
> <draft-ietf-i2nsf-registration-interface-dm.all@ietf.org>rg>, Sangwon Hyun <
> swhyun77@gmail.com>gt;, "skku-iotlab-members@googlegroups.com" <
> skku-iotlab-members@googlegroups.com>gt;, "Mr. Jaehoon Paul Jeong" <
> jaehoon.paul@gmail.com>
> *Subject: *Re: [I2nsf] Yangdoctors last call review of
> draft-ietf-i2nsf-registration-interface-dm-04
>
>
>
> Hi Reshad,
> I believe that I have addressed your comments on I2NSF Registration
> Interface Data Model:
> https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05
>
> If you are satisfied with the revision, could you update the Review result
> in the following page?
>
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/
>
> Thanks.
>
> Best Regards,
> Paul
>
>
>
> On Thu, Jul 25, 2019 at 11:23 PM Mr. Jaehoon Paul Jeong <
> jaehoon.paul@gmail.com> wrote:
>
> Hi Reshad,
> Here is the revision letter for the revised draft, reflecting your
> comments along with the revised draft:
> https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05
>
>
>
> If you have further comments and questions, please let me know.
>
> Thanks.
>
> Best Regards,
> Paul
>
>
>
> On Fri, Jun 28, 2019 at 5:17 PM Reshad Rahman via Datatracker <
> noreply@ietf.org> wrote:
>
> Reviewer: Reshad Rahman
> Review result: On the Right Track
>
> YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-04 (by
> Reshad
> Rahman)
>
> Major comments:
> - Look at appendix B of RFC8407 for an example of how a YANG module should
> be
> structured. This document does not abide to that. - Poor descriptions e.g.
> "nsf-name" for leaf "nsf-name" etc - prefix "iiregi" doesn't seem right.
> What
> about "nsfreg"? Probably needs coordination with the other I2NSF YANG
> modules
> to have consistency between the prefixes. I see that YD Acee suggested
> "nsfintf" for draft-ietf-i2nsf-nsf-facing-interface-dm-06 - No unit
> specified
> for bandwidth, processing (performance) - nsf-address is IPv4 specific -
> Security considerations should list the nodes as per section 3.7 of
> RFC8407. -
> Should this document be informational since 8329 is informational? -
> Section 2
> should use RFC8174 also - Refer to RFC8407 instead of 6807 (YANG
> Guidelines) -
> Examples should use IPv6 as examples (use the range from RFC3849). Kudos
> for
> all the examples.
>
> Minor comments and questions:
> - The YANG trees such as Figure 6, 7 etc don't show the contents of the
> groupings. So they don't help much. - nsf-port-address should be nsf-port?
> -
> Section 4, last bullet. I am not an expert on I2NSF so not clear to me why
> this
> query is needed, is it because NSF may not re-register after their
> capabilities
> have been updated? Might be worth adding some explanation. - Have the
> examples
> been validated?
>
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org
> https://www.ietf.org/mailman/listinfo/i2nsf
>
>
>
>
> --
>
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>
>
>
>
> --
>
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>