Re: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Sat, 08 February 2020 02:32 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D6BA2120103; Fri, 7 Feb 2020 18:32:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.987
X-Spam-Level:
X-Spam-Status: No, score=-1.987 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HK_NAME_FM_MR_MRS=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7FViZVMZ5Mvr; Fri, 7 Feb 2020 18:32:48 -0800 (PST)
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 16EC612007C; Fri, 7 Feb 2020 18:32:48 -0800 (PST)
Received: by mail-lf1-x12e.google.com with SMTP id c23so623433lfi.7; Fri, 07 Feb 2020 18:32:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dx9j0EYtGJ78jL72SdgeFAHExANsgHrwDKc5rH9Hmj0=; b=oJhSc2LqRXST/1bxFTMJ5B6JVLm6z9G0C1YiY5zpk7NGpqes5H2gAtOm1Vi4IStyEd 0tlpTbaIQ1GGqJCzmK6EcxyahSYdHbxDV0jac4AYHzW1u9A0Ll8+YcEL31IIy4+uGN4E T3ONnKVV6OO3JrK4snGkGSJ0ustw//WAY3s/9Ll8DTcQPtXBykDHR/2hw00uttYTKkXe DZ1N256/v3NLAuzWzUudDVTygLD7wU938ZuDmf5fOPl5/H0GvIrMBiBouc98GERV2ibF DRXwpyqF3vsFdUpgilxnXCXkx4i1E412wFxEfygYOcMjPBailAEldSaVGQh+svpN0PnI wsaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dx9j0EYtGJ78jL72SdgeFAHExANsgHrwDKc5rH9Hmj0=; b=f04w77Qmv2wMvxHSzPM+K5Kp/nWDKuakMnEyFemV3zNAJpAhmZ5sTcFiTZrTws8Pbt DFfqvqAicNrFG/sDVkc440AsLt/yt0F5hll+6Cax2xiDqR3nMxUfmTCZ6DgP/5wx37tB dcegV4N8fONw8Cbd3lRti5JuweUp2Z0lucqoGVc1i+MqdWP4nz3BUb5jrHaom350vjYb kYmqc/MF+d2S+eZlAmP8YINbJRNhQqh6QAMSnFQMOW4GKdrsKs142geQZNx9Y1t/C9T8 JuwTzK1Ju0R2NULxC5O+0lAg1aN/1bor7K9WBb9CpqnauE//2kV53fFwadhL2/Jh2Yc+ YIrQ==
X-Gm-Message-State: APjAAAW+rfwwHP9AFSgANtnF/+l3nD+n7NyJReYiAxzMEh+fFsYXT0NX mJlsN+jCImKfou/BaJfxhtJX/ZZYm5IDrGV6Y1E=
X-Google-Smtp-Source: APXvYqxaJ4Z51xu81FU+8hosRJCxq9ZYbYJJMyfHecA2IHEgrHOzPqufrMh+OuOdMckdRuItsXYL7sBg5uUOl6SVYeY=
X-Received: by 2002:ac2:58c2:: with SMTP id u2mr874328lfo.206.1581129166243; Fri, 07 Feb 2020 18:32:46 -0800 (PST)
MIME-Version: 1.0
References: <156175664267.21931.10329030969352120108@ietfa.amsl.com> <CAPK2DezmXhBA39GFMrU6tYFte_rDK+DE=WyWpzSNFMvnNU+xGQ@mail.gmail.com> <CAPK2Deym5jVmi4JKekRVznpNCkO_x8PN7jz7DLXkgUNZ9V4uUw@mail.gmail.com> <47E6993E-1045-4B29-B814-E7185516B272@cisco.com> <CAPK2DexseZBxXZthOU3wjyDnXPGe3PYrNvbcC-JO8+8JjypM4w@mail.gmail.com> <CAPK2DeycWH3k1wsHKADhAQnHXsDsB6A0QNAf-2EkFyWoSppWOQ@mail.gmail.com> <9B0042BE-DF30-4EAD-9B7F-5E4FB196F980@cisco.com>
In-Reply-To: <9B0042BE-DF30-4EAD-9B7F-5E4FB196F980@cisco.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Sat, 8 Feb 2020 11:32:09 +0900
Message-ID: <CAPK2DezH6Mf=o_OX_tU6i-Jk3xdBaQx44Jk9XRaKX0xe0v3qMg@mail.gmail.com>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
Cc: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, Sangwon Hyun <swhyun77@gmail.com>, skku-iotlab-members <skku-iotlab-members@googlegroups.com>, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000004c4b91059e0752ec"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/qgKjJbxGTRPC6zQ1-xKoyXWl7KE>
Subject: Re: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Feb 2020 02:32:52 -0000

Hi Reshad,
Thanks for your valuable comments and help.

Best Regards,
Paul

On Sat, Feb 8, 2020 at 8:38 AM Reshad Rahman (rrahman) <rrahman@cisco.com>
wrote:

> Hi Paul,
>
>
>
> I have verified that you’ve addressed all comments which were provided on
> 05.
>
>
>
> Regards,
>
> Reshad.
>
>
>
> *From: *"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
> *Date: *Thursday, January 30, 2020 at 10:32 AM
> *To: *"Reshad Rahman (rrahman)" <rrahman@cisco.com>
> *Cc: *YANG Doctors <yang-doctors@ietf.org>rg>, "i2nsf@ietf.org" <
> i2nsf@ietf.org>gt;, Sangwon Hyun <swhyun77@gmail.com>om>, skku-iotlab-members <
> skku-iotlab-members@googlegroups.com>gt;, Patrick Lingga <
> patricklink888@gmail.com>gt;, "Mr. Jaehoon Paul Jeong" <
> jaehoon.paul@gmail.com>
> *Subject: *Re: [I2nsf] Yangdoctors last call review of
> draft-ietf-i2nsf-registration-interface-dm-04
>
>
>
> Reshad,
>
> Could you respond to my previous email about the latest revision of the
> I2NSF Registration Interface YANF Data Model draft?
>
> https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-06
>
>
>
> If you are satisfied with my revision, could you update the YANG Doctor's
> review result in the following link?
>
>
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/
>
>
>
> After getting your review update state, I can ask the I2NSF WG chairs to
> make the WG Last Call on
>
> our I2NSF Registration Interface draft.
>
>
>
> Thanks for your efforts and help.
>
>
>
> Best Regards,
>
> Paul
>
>
>
> On Tue, Jan 21, 2020 at 8:08 PM Mr. Jaehoon Paul Jeong <
> jaehoon.paul@gmail.com> wrote:
>
> Hi Reshad,
>
> We authors have addressed your comments with the following revision:
>
> https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-06
>
>
>
> I attach the revision letter to show how to address your comments.
>
>
>
> Could your check this revision and proceed with the YANG review update?
>
>
>
> Thanks.
>
>
>
> Best Regards,
>
> Paul
>
>
>
>
>
> On Tue, Nov 12, 2019 at 1:58 AM Reshad Rahman (rrahman) <rrahman@cisco.com>
> wrote:
>
> Hi Paul,
>
>
>
> I have done another review (I don’t think an automated email got sent
> out).
>
>
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/
>
>
>
> YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-05 (by
> Reshad Rahman)
>
>
>
> Thank you for addressing comments from my earlier review @
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/
>
>
>
> Major comments/questions:
>
> - There is a YANG warning on the datatracker page:
>
> ietf-i2nsf-reg-interface@2019-07-24.yang:54: warning: RFC 8407: 3.1: The
> IETF Trust Copyright statement seems to be missing (see pyang --ietf-help
> for details).
>
> To fix this, in the YANG module remove the <> around 2019: Copyright (c)
> <2019>
>
>
>
> - For contact in YANG module, please remove WG chair info (see RFC8407
> appendix B for an example)
>
>
>
> - For the revision in YANg module, put "Initial version" (even though it's
> the 5th revision)
>
>
>
> - Why define a union of ipv4-address and ipv6-address in typedef
> nsf-address, why not reuse existing ip-address type from RFC6021?
>
>
>
> - For bandwidth, is there a reason why it's limited to uint16? Even though
> 65Tbps is a lot, I wouldn't limit it to uint16. And aren't there any
> use-cases for bandwidth smaller than 1 Gbps? If yes, use e.g Mbps as unit
> and use uint32 instead of uint16? Please use units statement.
>
> - It is not clear to me what’s the distinction between nsf-name and
> nsf-instance-name. In Examples 4 and 5, they have the same value, but not
> in Example 3.  Might be worth clarifying or giving the same name.
>
>
>
> - Having nsf or i2nsf in many node names is redundant, since NSF or I2NSF
> is in the higher level container name.  e.g, in NSF Capability Registration
> all nodes seem to have i2nsf or nsf in their name.
>
>
>
> - There seems to be some indentation issues in the YANG  module (e.g. P16)
>
>
>
> - Abide by order in RFC8407 Appendix B. e.g. RPC statements should be
> after groupings.
>
>
>
> Nits:
>
>
>
> - Appendix B: Managmenet -> Management
>
>
>
> - Section 6.2: capailities -> capabilities
>
>
>
> - Example 5: space in "http_and_h ttps_flood_mitigation_capability"
>
>
>
> Regards,
>
> Reshad.
>
>
>
>
>
> Regards,
>
> Reshad.
>
>
>
> *From: *"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
> *Date: *Tuesday, November 5, 2019 at 9:02 PM
> *To: *"Reshad Rahman (rrahman)" <rrahman@cisco.com>
> *Cc: *YANG Doctors <yang-doctors@ietf.org>rg>, "i2nsf@ietf.org" <
> i2nsf@ietf.org>gt;, "draft-ietf-i2nsf-registration-interface-dm.all@ietf.org"
> <draft-ietf-i2nsf-registration-interface-dm.all@ietf.org>rg>, Sangwon Hyun <
> swhyun77@gmail.com>gt;, "skku-iotlab-members@googlegroups.com" <
> skku-iotlab-members@googlegroups.com>gt;, "Mr. Jaehoon Paul Jeong" <
> jaehoon.paul@gmail.com>
> *Subject: *Re: [I2nsf] Yangdoctors last call review of
> draft-ietf-i2nsf-registration-interface-dm-04
>
>
>
> Hi Reshad,
> I believe that I have addressed your comments on I2NSF Registration
> Interface Data Model:
> https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05
>
> If you are satisfied with the revision, could you update the Review result
> in the following page?
>
> https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/
>
> Thanks.
>
> Best Regards,
> Paul
>
>
>
> On Thu, Jul 25, 2019 at 11:23 PM Mr. Jaehoon Paul Jeong <
> jaehoon.paul@gmail.com> wrote:
>
> Hi Reshad,
> Here is the revision letter for the revised draft, reflecting your
> comments along with the revised draft:
> https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05
>
>
>
> If you have further comments and questions, please let me know.
>
> Thanks.
>
> Best Regards,
> Paul
>
>
>
> On Fri, Jun 28, 2019 at 5:17 PM Reshad Rahman via Datatracker <
> noreply@ietf.org> wrote:
>
> Reviewer: Reshad Rahman
> Review result: On the Right Track
>
> YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-04 (by
> Reshad
> Rahman)
>
> Major comments:
> - Look at appendix B of RFC8407 for an example of how a YANG module should
> be
> structured. This document does not abide to that. - Poor descriptions e.g.
> "nsf-name" for leaf "nsf-name" etc - prefix "iiregi" doesn't seem right.
> What
> about "nsfreg"? Probably needs coordination with the other I2NSF YANG
> modules
> to have consistency between the prefixes. I see that YD Acee suggested
> "nsfintf" for draft-ietf-i2nsf-nsf-facing-interface-dm-06 - No unit
> specified
> for bandwidth, processing (performance) - nsf-address is IPv4 specific -
> Security considerations should list the nodes as per section 3.7 of
> RFC8407. -
> Should this document be informational since 8329 is informational? -
> Section 2
> should use RFC8174 also - Refer to RFC8407 instead of 6807 (YANG
> Guidelines) -
> Examples should use IPv6 as examples (use the range from RFC3849). Kudos
> for
> all the examples.
>
> Minor comments and questions:
> - The YANG trees such as Figure 6, 7 etc don't show the contents of the
> groupings. So they don't help much. - nsf-port-address should be nsf-port?
> -
> Section 4, last bullet. I am not an expert on I2NSF so not clear to me why
> this
> query is needed, is it because NSF may not re-register after their
> capabilities
> have been updated? Might be worth adding some explanation. - Have the
> examples
> been validated?
>
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org
> https://www.ietf.org/mailman/listinfo/i2nsf
>
>
>
>
> --
>
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>
>
>
>
> --
>
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>
>
>
>
> --
>
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>
>
>
>
> --
>
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>