Re: [i2rs] Yangdoctors early review of draft-ietf-i2rs-yang-l2-network-topology-04

"Susan Hares" <shares@ndzh.com> Fri, 04 May 2018 20:39 UTC

Return-Path: <shares@ndzh.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7461012D967 for <i2rs@ietfa.amsl.com>; Fri, 4 May 2018 13:39:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.945
X-Spam-Level:
X-Spam-Status: No, score=0.945 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9fZLZ5hzQn4s for <i2rs@ietfa.amsl.com>; Fri, 4 May 2018 13:39:41 -0700 (PDT)
Received: from hickoryhill-consulting.com (50-245-122-97-static.hfc.comcastbusiness.net [50.245.122.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F165312D965 for <i2rs@ietf.org>; Fri, 4 May 2018 13:39:40 -0700 (PDT)
X-Default-Received-SPF: pass (skip=loggedin (res=PASS)) x-ip-name=107.92.121.30;
From: Susan Hares <shares@ndzh.com>
To: "'Dongjie (Jimmy)'" <jie.dong@huawei.com>, 'Ladislav Lhotka' <lhotka@nic.cz>
Cc: i2rs@ietf.org, 'Martin Vigoureux' <martin.vigoureux@nokia.com>
References: <152526794842.11272.8213634409290285584@ietfa.amsl.com> <76CD132C3ADEF848BD84D028D243C92798440318@NKGEML515-MBS.china.huawei.com>
In-Reply-To: <76CD132C3ADEF848BD84D028D243C92798440318@NKGEML515-MBS.china.huawei.com>
Date: Fri, 04 May 2018 16:39:18 -0400
Message-ID: <00c001d3e3e7$f9b18e70$ed14ab50$@ndzh.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Content-Language: en-us
Thread-Index: AQNe1+FL8Tl1YbLI7rTemtnvRB4QjwKKzLXooPXGsaA=
X-Authenticated-User: skh@ndzh.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/2r_Si2PZXl-sI9eNIZFF7nH6eu0>
Subject: Re: [i2rs] Yangdoctors early review of draft-ietf-i2rs-yang-l2-network-topology-04
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 May 2018 20:39:42 -0000

Jie and Lada: 

I've recently listened to the I2RS meeting in IETF 101.  

Chris Hopps asked about the notifications in L2.  He was asking about a more
general use of the notification that might be useful in the 

I'm not really sure how to approach responding to his operational request -
since it really impacts all topology models.  My inclination is to push this
draft through into RFC usage, and then to work through a "-bis"
functionality.  

Jie - would you ask the individuals pushing for L2 model if that works for
them. 

Lada - would you ask the Yang doctors if this is the right approach to take.
Of course, this might be easier if we had versioning instead of a model name
change.  

Sue Hares 
-----Original Message-----
From: i2rs [mailto:i2rs-bounces@ietf.org] On Behalf Of Dongjie (Jimmy)
Sent: Thursday, May 3, 2018 10:09 PM
To: Ladislav Lhotka; yang-doctors@ietf.org
Cc: i2rs@ietf.org; ietf@ietf.org;
draft-ietf-i2rs-yang-l2-network-topology.all@ietf.org
Subject: Re: [i2rs] Yangdoctors early review of
draft-ietf-i2rs-yang-l2-network-topology-04

Hi Lada, 

Thanks a lot for your review comments. Please see some replies inline:

> -----Original Message-----
> From: Ladislav Lhotka [mailto:lhotka@nic.cz]
> Sent: Wednesday, May 02, 2018 9:32 PM
> To: yang-doctors@ietf.org
> Cc: i2rs@ietf.org; ietf@ietf.org;
> draft-ietf-i2rs-yang-l2-network-topology.all@ietf.org
> Subject: Yangdoctors early review of 
> draft-ietf-i2rs-yang-l2-network-topology-04
> 
> Reviewer: Ladislav Lhotka
> Review result: Ready
> 
> This draft and YANG modules contained therein fit into the framework 
> of I2RS network topology models. I have no substantial comments, from 
> the YANG point of view this document is ready to be published.
> 
> Comments and questions:
> 
> 1. What is the purpose of the 'flag-type' type and 'flag-identity'
identity?
> There are no identities derived from the latter.

The "flag-type" type is used in the grouping "l2-network-attributes",
"l2-node-attributes" and "l2-link-attributes".

While there is no identities derived from the "flag-identity", it is used in
the typedef flag-type. Is this OK?

> 2. Some descriptions overuse capitalization. For example, instead of 'VLAN
Name'
> I would suggest 'VLAN name'.

Thanks for catching this. Will fix in next revision.

> 3. An example of an instance document in an appendix would be very
helpful.

Thanks for your suggestion. We will add an example to the appendix.

Best regards,
Jie

_______________________________________________
i2rs mailing list
i2rs@ietf.org
https://www.ietf.org/mailman/listinfo/i2rs