[i2rs] Yangdoctors early review of draft-ietf-i2rs-yang-l2-network-topology-04

Ladislav Lhotka <lhotka@nic.cz> Wed, 02 May 2018 13:32 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ladislav Lhotka <lhotka@nic.cz>
To: yang-doctors@ietf.org
Cc: i2rs@ietf.org, ietf@ietf.org, draft-ietf-i2rs-yang-l2-network-topology.all@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152526794842.11272.8213634409290285584@ietfa.amsl.com>
Date: Wed, 02 May 2018 06:32:28 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/Cda5BqfDOVxVVHKQVFb0czQZOnk>
Subject: [i2rs] Yangdoctors early review of draft-ietf-i2rs-yang-l2-network-topology-04

Reviewer: Ladislav Lhotka
Review result: Ready

This draft and YANG modules contained therein fit into the framework of I2RS
network topology models. I have no substantial comments, from the YANG point of
view this document is ready to be published.

Comments and questions:

1. What is the purpose of the 'flag-type' type and 'flag-identity' identity?
There are no identities derived from the latter.

2. Some descriptions overuse capitalization. For example, instead of 'VLAN
Name' I would suggest 'VLAN name'.

3. An example of an instance document in an appendix would be very helpful.

[i2rs] Yangdoctors early review of draft-ietf-i2r… Ladislav Lhotka
Re: [i2rs] Yangdoctors early review of draft-ietf… Dongjie (Jimmy)
Re: [i2rs] Yangdoctors early review of draft-ietf… Ladislav Lhotka
Re: [i2rs] Yangdoctors early review of draft-ietf… Susan Hares
Re: [i2rs] Yangdoctors early review of draft-ietf… Alexander Clemm
Re: [i2rs] Yangdoctors early review of draft-ietf… Dongjie (Jimmy)