Re: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt

Qin Wu <bill.wu@huawei.com> Wed, 21 August 2019 09:29 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 45D0512080C for <i2rs@ietfa.amsl.com>; Wed, 21 Aug 2019 02:29:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pANWRloJSGpn for <i2rs@ietfa.amsl.com>; Wed, 21 Aug 2019 02:29:44 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3EA24120142 for <i2rs@ietf.org>; Wed, 21 Aug 2019 02:29:44 -0700 (PDT)
Received: from LHREML712-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id E33953C40B5AC7C3A9A0; Wed, 21 Aug 2019 10:29:42 +0100 (IST)
Received: from DGGEML406-HUB.china.huawei.com (10.3.17.50) by LHREML712-CAH.china.huawei.com (10.201.108.35) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 21 Aug 2019 10:29:42 +0100
Received: from DGGEML511-MBX.china.huawei.com ([169.254.1.9]) by dggeml406-hub.china.huawei.com ([10.3.17.50]) with mapi id 14.03.0439.000; Wed, 21 Aug 2019 17:29:39 +0800
From: Qin Wu <bill.wu@huawei.com>
To: tom petch <ietfc@btconnect.com>, Susan Hares <shares@ndzh.com>, "i2rs@ietf.org" <i2rs@ietf.org>
CC: "russ@riw.us" <russ@riw.us>
Thread-Topic: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt
Thread-Index: AdVYAHlky+B/kB8PRqi/1/EjPETpPQ==
Date: Wed, 21 Aug 2019 09:29:39 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABAA92AAD01@dggeml511-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.134.31.203]
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/PXOzjLVOLTd2caCiTsGqEz9YRTE>
Subject: Re: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2019 09:29:46 -0000

I can add 802.1ad and 802.1ah, if you like, but to ietf-l2-topolgy, these two references are not significant since we don't reuse any type or grouping in the model related to these two references.
Regarding example using 10.address, good catch, I fixed mac address, but I forgot to fix IPv4 address,
will get this fixed in the next update.
Thanks Tom.

-Qin
-----邮件原件-----
发件人: tom petch [mailto:ietfc@btconnect.com] 
发送时间: 2019年8月20日 17:31
收件人: Qin Wu <bill.wu@huawei.com>om>; Susan Hares <shares@ndzh.com>om>; i2rs@ietf.org
抄送: russ@riw.us
主题: Re: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt

Qin

Thank you for the revised module; top posting on two points I do not see fixed in -09.

I see no reference for

802.1ad
802.1ah

And the example uses a 10. address rather than the documentation range in RFC5737

I hope to look some more at the technicalities and so may have some more comments - I would not post another revision just yet:-)

Tom Petch


----- Original Message -----
From: "Qin Wu" <bill.wu@huawei.com>
To: "tom petch" <ietfc@btconnect.com>om>; "Susan Hares" <shares@ndzh.com>om>; <i2rs@ietf.org>
Cc: <russ@riw.us>
Sent: Monday, August 19, 2019 6:03 AM

> Hi, Tom:
> Thank for your valuable review. See comments inline below.
> -----邮件原件-----
> 发件人: i2rs [mailto:i2rs-bounces@ietf.org] 代表 tom petch
> 发送时间: 2019年8月16日 20:00
> 收件人: Susan Hares <shares@ndzh.com>om>; i2rs@ietf.org
> 抄送: russ@riw.us
> 主题: Re: [i2rs] WG LC:
draft-ietf-i2rs-yang-l2-network-topology-07.txt
>
> Not ready
>
> The text says
>     /*Consider udpating this part to make use of
draft-ietf-softwire-iftunnel*/ Well yes, consider it and come to a conclusion otherwise I cannot see how this is ready to advance.
> [Qin]: Good catch, will fix this. The idea is to align with RFC7224
and reuse iana-interface-type.
>
> The YANG module contains many references - good - but they are not in
the I-D references; again, not ready to advance.  I see
>
> 4761
> 4762
> 6325
> 6326
> 7348
>
> 802.1ad
> 802.1ah
> 802.1Q
>
> [Qin]:Fixed.
> IANA considerations references RFC7950 - RFC 6020 is better here as
all that RFC7950 says is go see RFC6020.
> [Qin]:Agree, will update based on your suggestion.
>
> OLD
>
>        This version of this YANG module is part of
>        draft-ietf-i2rs-yang-l2-network-topo-07;
>
> NEW
>        This version of this YANG module is part of
>         "RFC XXXX: A YANG Data Model for Layer-2 Network Topologies"
>
> [Qin]:Fixed.
> You also have this unsuitable reference twice in the state module 
> [Qin]:Fixed.
> The state module lacks references for the imports [Qin]:Fixed.
> The state module description clause seems misleading; it is only the
state part of a module when NMDA is not supported.
> [Qin]:Fixed.
> Appendix A - is it Normative?  The customary convention is the
Appendices are not unless stated otherwise and there is no statement here.
> [Qin]:No, will make this clear.
> 'An Example' does not use the addresses set aside for documentation 
> [Qin]:Good catch, will use RFC7042 recommended address range.
> What is the closing date for this Last call?
>
> Tom Petch
>
> ----- Original Message -----
> From: "Susan Hares" <shares@ndzh.com>
> To: <i2rs@ietf.org>
> Cc: <russ@riw.us>
> Sent: Friday, August 09, 2019 4:42 PM
>
>
> > Greetings:
> >
> >
> >
> > This draft on L2 network topology has been reviewed by the I2RS WG 3
> times.
> >
> > However, in discussion with the ADs it is deemed appropriate to do
one
> more
> >
> > WG LC and include any input from rtgwg or grow.
> >
> >
> >
> > Please indicate whether you support publication of this document.
> >
> > In your comments, please indicate "support" or no "support".
> >
> >
> >
> > If you feel there issues that need to be resolved,
> >
> > Please indicate whether these issues are editorial,
> >
> > Yang syntax, or technical content.
> >
> >
> >
> > It would be helpful to indicate whether you know of
> >
> > Network deployments or potential network deployments of this draft.
> >
> >
> >
> > Cheerily,
> >
> >
> >
> > Sue Hares
> >
> >
> >
> >
>
>
> ----------------------------------------------------------------------
--
> --------
>
>
> > _______________________________________________
> > i2rs mailing list
> > i2rs@ietf.org
> > https://www.ietf.org/mailman/listinfo/i2rs
> >
>
> _______________________________________________
> i2rs mailing list
> i2rs@ietf.org
> https://www.ietf.org/mailman/listinfo/i2rs
>