Re: [i2rs] draft-ietf-i2rs-yang-dc-fabric-network-topology - WG LC from 11/28 to 12/12/2017

Alexander Clemm <alexander.clemm@huawei.com> Wed, 29 November 2017 17:52 UTC

Return-Path: <alexander.clemm@huawei.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2F11D120726 for <i2rs@ietfa.amsl.com>; Wed, 29 Nov 2017 09:52:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YoaJMRZSqIk0 for <i2rs@ietfa.amsl.com>; Wed, 29 Nov 2017 09:52:17 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8526B1288A9 for <i2rs@ietf.org>; Wed, 29 Nov 2017 09:52:17 -0800 (PST)
Received: from lhreml704-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 25658CCA82831 for <i2rs@ietf.org>; Wed, 29 Nov 2017 17:52:13 +0000 (GMT)
Received: from SJCEML702-CHM.china.huawei.com (10.208.112.38) by lhreml704-cah.china.huawei.com (10.201.108.45) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 29 Nov 2017 17:52:15 +0000
Received: from SJCEML521-MBX.china.huawei.com ([169.254.1.83]) by SJCEML702-CHM.china.huawei.com ([169.254.4.18]) with mapi id 14.03.0361.001; Wed, 29 Nov 2017 09:51:57 -0800
From: Alexander Clemm <alexander.clemm@huawei.com>
To: "Zhuangyan (Yan)" <zhuangyan.zhuang@huawei.com>, Susan Hares <shares@ndzh.com>, "i2rs@ietf.org" <i2rs@ietf.org>
Thread-Topic: [i2rs] draft-ietf-i2rs-yang-dc-fabric-network-topology - WG LC from 11/28 to 12/12/2017
Thread-Index: AdNpD+0upjXSuscxSY2Fzf5NKm4gUQAKrSQg
Date: Wed, 29 Nov 2017 17:51:56 +0000
Message-ID: <644DA50AFA8C314EA9BDDAC83BD38A2E0EACF647@sjceml521-mbx.china.huawei.com>
References: <9B4BC45FDEDDD84F813E9E4A5BAF8785A9665C2E@nkgeml513-mbx.china.huawei.com>
In-Reply-To: <9B4BC45FDEDDD84F813E9E4A5BAF8785A9665C2E@nkgeml513-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.209.216.194]
Content-Type: multipart/alternative; boundary="_000_644DA50AFA8C314EA9BDDAC83BD38A2E0EACF647sjceml521mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/bVDTv4TUZqji4gWizD4NimudwcM>
Subject: Re: [i2rs] draft-ietf-i2rs-yang-dc-fabric-network-topology - WG LC from 11/28 to 12/12/2017
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2017 17:52:20 -0000

Thanks, Yan.

I looked at the update.  This looks really good now.  Support.

--- Alex

From: Zhuangyan (Yan)
Sent: Wednesday, November 29, 2017 4:50 AM
To: Alexander Clemm <alexander.clemm@huawei.com>; Susan Hares <shares@ndzh.com>; i2rs@ietf.org
Subject: Re: [i2rs] draft-ietf-i2rs-yang-dc-fabric-network-topology - WG LC from 11/28 to 12/12/2017

Hi Alex,

Thank you very much for the comments : ) We¡¯ve updated them in the new version -02 as posted.

Best Regards,

Yan

·¢¼þÈË: i2rs [mailto:i2rs-bounces@ietf.org] ´ú±í Alexander Clemm
·¢ËÍʱ¼ä: 2017Äê11ÔÂ29ÈÕ 3:44
ÊÕ¼þÈË: Susan Hares <shares@ndzh.com<mailto:shares@ndzh.com>>; i2rs@ietf.org<mailto:i2rs@ietf.org>
Ö÷Ìâ: Re: [i2rs] draft-ietf-i2rs-yang-dc-fabric-network-topology - WG LC from 11/28 to 12/12/2017

Hi,

I did a quick review of this.  I support publication of this yang module.  I think the draft is in good shape.

I do have a few very minor nits which should be easy to address:

-          There are a few formatting issues of the ¨Cstate module, such as inconsistent indentations (sometimes 2, sometimes 4, sometimes 8 spaces) or elements at the same level indented differently.

-          Leaf ¡°bandwith¡± should be renamed ¡°bandwidth¡± (for correct spelling)

-          I am wondering whether identity+identityref might be a better choice than enumeration types for port-type enumeration (with regards to extensibility).  Same for bandwith (or at least include choice ¡°other¡±?).   I don¡¯t feel strongly about this but it¡¯s a possible consideration.

-          Name of ¡°fabric-attribute¡±.  This is not really a single attribute.  Just call it ¡°fabric¡± (as a whole), or make it plural?  Again, just for consideration.

Thanks
--- Alex

From: i2rs [mailto:i2rs-bounces@ietf.org] On Behalf Of Susan Hares
Sent: Tuesday, November 28, 2017 5:56 AM
To: i2rs@ietf.org<mailto:i2rs@ietf.org>
Subject: [i2rs] draft-ietf-i2rs-yang-dc-fabric-network-topology - WG LC from 11/28 to 12/12/2017

This begins a 2 week WG LC on the I2RS draft draft-ietf-i2rs-yang-dc-fabric-network-topology from 11/28 to 12/12/2017.

https://datatracker.ietf.org/doc/draft-ietf-i2rs-yang-dc-fabric-network-topology/

The authors should indicate if they know of any IPR relating to this draft.

Please consider during your WG LC review, the following questions:


1)      Do you know of any implementations of this draft?

2)      Does this draft adhere to the Network Management Datastore architecture (NMDA)?

3)      Do you know of any technical issues with this yang module?

4)      Will the deployment of this yang module aid the management of Data Center Fabrics?

5)      Do you support publication of this yang module?

Sue Hares