Re: [i2rs] RtgDir review: draft-ietf-i2rs-yang-l2-network-topology-13.txt

mohamed.boucadair@orange.com Wed, 24 June 2020 18:13 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7BE8B3A1113; Wed, 24 Jun 2020 11:13:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W7siZsaLeHJw; Wed, 24 Jun 2020 11:13:37 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B26AF3A10A7; Wed, 24 Jun 2020 11:13:36 -0700 (PDT)
Received: from opfedar05.francetelecom.fr (unknown [xx.xx.xx.7]) by opfedar24.francetelecom.fr (ESMTP service) with ESMTP id 49sWVR0jF3z5w4V; Wed, 24 Jun 2020 20:13:35 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1593022415; bh=826G/KrrbANKHsk1By2AKT+W6DnlcU8ICtdQ8Zfy9G8=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=VgZd8g85j7qnopO/NeKM46BALEsdhDwMA65kM75rmxjcsfyl2cUNufi3UR2+3F539 Xz0dWhyejxG66lJeKWvjREOOjvuyXmxxvCdQPLgl6xM5zRB3/UoooCGAItY25Qj+hn qudUz8eEvMjwdv8T6wVDqG8PPfOrNnnWDv+BlWpJS5+tPCp6JQFPYdT9jVy2rTko52 G/xzgoy9xmlQDJ66S0e0dwGxz3aYka1NQpM/H5yn3UdlwnRjlIoCK9yJtUmpOP4O2m JiF62QrGz+77SfkrhTRABNbtGRd6jEu/1d/8PLVOQG0sWGGm8U/lJFNn7YCZYRDZVE foy916vNVNHvw==
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.23]) by opfedar05.francetelecom.fr (ESMTP service) with ESMTP id 49sWVQ6YR9z2xCX; Wed, 24 Jun 2020 20:13:34 +0200 (CEST)
From: <mohamed.boucadair@orange.com>
To: Stig Venaas <stig@venaas.com>, "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-i2rs-yang-l2-network-topology.all@ietf.org" <draft-ietf-i2rs-yang-l2-network-topology.all@ietf.org>, "i2rs@ietf.org" <i2rs@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-i2rs-yang-l2-network-topology-13.txt
Thread-Index: AQHWSkn+jc8tKo+GPEq5R2VzLhcFIqjoDo3g
Date: Wed, 24 Jun 2020 18:13:33 +0000
Message-ID: <10633_1593022414_5EF397CE_10633_415_1_787AE7BB302AE849A7480A190F8B9330314E691E@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <CAHANBt+aOh-O9EuamGL6xPvHGtHdYQLSwAM_T1haeMoSVhaEgA@mail.gmail.com>
In-Reply-To: <CAHANBt+aOh-O9EuamGL6xPvHGtHdYQLSwAM_T1haeMoSVhaEgA@mail.gmail.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.247]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/doLLwIV0SvTL69KOueF2KeFRzro>
Subject: Re: [i2rs] RtgDir review: draft-ietf-i2rs-yang-l2-network-topology-13.txt
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2020 18:13:39 -0000

Hi Stig, 

Thank you for the review. These nits will be fixed in the next iteration. 

As per this comment: 

"There may be some minor model issues, tracker says: Yang Validation 9 errors, 2 warnings." 

Actually, this is an issue of the IETF datatracker that only populates in IETF-defined modules. In particular, IEEE-related modules are not populated in as revealed by the error message:

==
ietf-l2-topology@2019-10-15.yang:31: error: module "ieee802-dot1q-types" not found in search path
==

Unless I'm mistaken, Sue has reported this issue in the write-up. Will look further on the warnings, though. 

Cheers,
Med

> -----Message d'origine-----
> De : Stig Venaas [mailto:stig@venaas.com]
> Envoyé : mercredi 24 juin 2020 19:07
> À : <rtg-ads@ietf.org>
> Cc : rtg-dir@ietf.org; draft-ietf-i2rs-yang-l2-network-
> topology.all@ietf.org; i2rs@ietf.org
> Objet : RtgDir review: draft-ietf-i2rs-yang-l2-network-topology-13.txt
> 
> Hello,
> 
> I have been selected as the Routing Directorate reviewer for this
> draft. The Routing Directorate seeks to review all routing or
> routing-related drafts as they pass through IETF last call and IESG
> review, and sometimes on special request. The purpose of the review is
> to provide assistance to the Routing ADs. For more information about
> the Routing Directorate, please see
> http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
> 
> Although these comments are primarily for the use of the Routing ADs,
> it would be helpful if you could consider them along with any other
> IETF Last Call comments that you receive, and strive to resolve them
> through discussion or by updating the draft.
> 
> Document: draft-ietf-i2rs-yang-l2-network-topology-13.txt
> Reviewer: Stig Venaas
> Review Date: 2020-06-24
> IETF LC End Date: 2020-06-25
> Intended Status: Standards Track
> 
> Summary:
> This document is basically ready for publication, but has nits that
> should be considered prior to publication.
> 
> Comments:
> The document is well written and easy to read. I only found some minor
> nits that should be taken care of.
> 
> Major Issues:
> No major issues found.
> 
> Minor Issues:
> No minor issues found.
> 
> Nits:
> 
> The idnits tool found some nits; regarding references in particular.
> 
> There may be some minor model issues, tracker says: Yang Validation 9
> errors, 2 warnings.
> 
> The abstract is rather short, I think it would be worth going into a
> little more detail.
> 
> In Introduction “A sample example” should maybe just be “An example”?
> 
> For grouping l2-network-type, shouldn’t “indicates” be capitalized?
>       presence "indicates L2 Network";
> 
> For leaf maximum-frame-size, missing space before PPP
>       if L2 frame is other type (e.g.,PPP), the L2
> 
> For l2-termination-point-type, leaf tag, should say “is supported”
>       "Defines whether lag is support or not.";
> 
> In the security considerations, should be “defines”
>       The Layer 2 topology module define
> 
> In Appendix A, should say “represents”.
>       implementations, a corresponding companion module is defined that
>       represent the operational state of layer 2 network topologies.  The
> 
> Regards,
> Stig

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.