[i2rs] RtgDir review: draft-ietf-i2rs-yang-l2-network-topology-13.txt

Stig Venaas <stig@venaas.com> Wed, 24 June 2020 17:07 UTC

Return-Path: <stig@venaas.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 781673A10EC for <i2rs@ietfa.amsl.com>; Wed, 24 Jun 2020 10:07:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id hYTjtZcgveob for <i2rs@ietfa.amsl.com>; Wed, 24 Jun 2020 10:07:35 -0700 (PDT)
Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 98FCD3A10BE for <i2rs@ietf.org>; Wed, 24 Jun 2020 10:07:35 -0700 (PDT)
Received: by mail-ej1-x632.google.com with SMTP id q19so3184858eja.7 for <i2rs@ietf.org>; Wed, 24 Jun 2020 10:07:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=PghgYIGzc/l39A3ennDNafjZ/6ku/7itWYtq7/KFMDk=; b=lKd1RmyO4jUQdShNv++wmPLPXOyxfImincGb9isvk9ElzOOVfS2GPiT9tHDfYJTKZh fuJPsLyV3feUMyHbDZMfYMSrBmaZXOt2ka3/SRLZyoHE+ITJ6G1Mcmn0MR1NsR+4SfNQ DDAhkxlxHm0Tj9c56tDoENFbqYKy/Jc0THYK1HBgFz1ES7I1eyAAgwnZGlE7fRxSSZyz +gl3dTzBw4ZcmwcN+X14Eb1Chqtp13qfmLYL+lXdqqWd+lIEWTK01ho+VhHJocOuKGQg 2IKFEpdZi68RnBvHKDMMEfw7Y+WS68jXneRWSU7ZqeuSBIh7ihlNnJjFa62TzSGY4fnU 3z/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=PghgYIGzc/l39A3ennDNafjZ/6ku/7itWYtq7/KFMDk=; b=jxkPUoYAd8SSIw0VFxTPnnGzYeetnV0PvxpyPbGuXhqrbHTk/1spHm/7adveszCstF 0Vsa6xY0RoEDLbSulZPMpIcAVk1w6KULYMAdNFrwCcA1Eo5ZgeZ9CxjIOPi7Aqoofe6z 1twl4F9A8If6IjWMnt7pSofpmSKKOj+a4A3REZ96tDJQHvOV5e/8wFBSrN8gkO4kDC2G 0AEoyiKFlzPVTTXlBj/+RVAj4ILXw4dgGWm+x5WVJRrhRklbT3URJOlei5dOXep7l2fa BCprm+L6QiuZ143FJqYm+aFIlhfp8A0XWKh0a/vUXoxJCDCTANArnwzsoVVkf63LSiKu 0lyQ==
X-Gm-Message-State: AOAM532/ETtQ4IaN4SCOF7jJSQLUIO+eTLwy8DXPqnkELDRT1qbuevEC ukwCUAleGLfgpccWz+/dfjGT0YtxFJ0y71idQ51hXw==
X-Google-Smtp-Source: ABdhPJwDUAypL20MyUY9A2VvS4q5GPgujq9F6Fww+48vPyXWBV5u5LegTeTrhlIH7JZQnSJTQU4ixZOAgry4cJ4sPRU=
X-Received: by 2002:a17:906:5250:: with SMTP id y16mr26006146ejm.3.1593018453833; Wed, 24 Jun 2020 10:07:33 -0700 (PDT)
MIME-Version: 1.0
From: Stig Venaas <stig@venaas.com>
Date: Wed, 24 Jun 2020 10:07:23 -0700
Message-ID: <CAHANBt+aOh-O9EuamGL6xPvHGtHdYQLSwAM_T1haeMoSVhaEgA@mail.gmail.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Cc: rtg-dir@ietf.org, draft-ietf-i2rs-yang-l2-network-topology.all@ietf.org, i2rs@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/eqNNeLVxa8AbURK8BHRQV7TNDUc>
Subject: [i2rs] RtgDir review: draft-ietf-i2rs-yang-l2-network-topology-13.txt
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2020 17:07:37 -0000


I have been selected as the Routing Directorate reviewer for this
draft. The Routing Directorate seeks to review all routing or
routing-related drafts as they pass through IETF last call and IESG
review, and sometimes on special request. The purpose of the review is
to provide assistance to the Routing ADs. For more information about
the Routing Directorate, please see

Although these comments are primarily for the use of the Routing ADs,
it would be helpful if you could consider them along with any other
IETF Last Call comments that you receive, and strive to resolve them
through discussion or by updating the draft.

Document: draft-ietf-i2rs-yang-l2-network-topology-13.txt
Reviewer: Stig Venaas
Review Date: 2020-06-24
IETF LC End Date: 2020-06-25
Intended Status: Standards Track

This document is basically ready for publication, but has nits that
should be considered prior to publication.

The document is well written and easy to read. I only found some minor
nits that should be taken care of.

Major Issues:
No major issues found.

Minor Issues:
No minor issues found.


The idnits tool found some nits; regarding references in particular.

There may be some minor model issues, tracker says: Yang Validation 9
errors, 2 warnings.

The abstract is rather short, I think it would be worth going into a
little more detail.

In Introduction “A sample example” should maybe just be “An example”?

For grouping l2-network-type, shouldn’t “indicates” be capitalized?
      presence "indicates L2 Network";

For leaf maximum-frame-size, missing space before PPP
      if L2 frame is other type (e.g.,PPP), the L2

For l2-termination-point-type, leaf tag, should say “is supported”
      "Defines whether lag is support or not.";

In the security considerations, should be “defines”
      The Layer 2 topology module define

In Appendix A, should say “represents”.
      implementations, a corresponding companion module is defined that
      represent the operational state of layer 2 network topologies.  The