[i2rs] Yangdoctors last call review of draft-ietf-i2rs-yang-l2-network-topology-13
Ladislav Lhotka via Datatracker <firstname.lastname@example.org> Tue, 23 June 2020 13:52 UTC
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F6E33A0E12; Tue, 23 Jun 2020 06:52:02 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
From: Ladislav Lhotka via Datatracker <email@example.com>
Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org
Reply-To: Ladislav Lhotka <email@example.com>
Date: Tue, 23 Jun 2020 06:52:02 -0700
Subject: [i2rs] Yangdoctors last call review of draft-ietf-i2rs-yang-l2-network-topology-13
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:firstname.lastname@example.org?subject=unsubscribe>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:email@example.com?subject=subscribe>
X-List-Received-Date: Tue, 23 Jun 2020 13:52:03 -0000
Reviewer: Ladislav Lhotka Review result: Ready with Nits I already reviewed revision -04 of this document with the conclusion that from YANG point of view it is ready to be published. It is still the case with the current revision -13. All my earlier comments have been addressed. I appreciate the example in Appendix B, it is really useful. However, I discovered several problems with the JSON instance data: - In all 6 entries of the "ietf-network-topology:link" list, commas are missing after the "source" object. - The identifier "ietf-l2-topology:l2-termination-point-attributes" is split between two lines (7 times), which makes it invalid. While this is explained in the introductory text, I would suggest to find another way of satisfying the 72 character limit that doesn't affect the instance data validity. One option is to use the convention of draft-ietf-netmod-artwork-folding-12, but it is also possible to simply dedent the offending lines. - According to the rules of RFC 7951, the identifier of "termination-point" list needs to be qualified with module name, i.e. "ietf-network-topology:termination-point". - The format of "mac-address" leaves doesn't match the regex pattern of their types: semicolons rather than dashes have to be used as octet separators.
- [i2rs] Yangdoctors last call review of draft-ietf… Ladislav Lhotka via Datatracker
- Re: [i2rs] Yangdoctors last call review of draft-… mohamed.boucadair