[i2rs] Yangdoctors last call review of draft-ietf-i2rs-yang-l2-network-topology-13

Ladislav Lhotka via Datatracker <noreply@ietf.org> Tue, 23 June 2020 13:52 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: i2rs@ietf.org
Delivered-To: i2rs@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F6E33A0E12; Tue, 23 Jun 2020 06:52:02 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ladislav Lhotka via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: last-call@ietf.org, draft-ietf-i2rs-yang-l2-network-topology.all@ietf.org, i2rs@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.3.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159292032253.25999.14074401115344645476@ietfa.amsl.com>
Reply-To: Ladislav Lhotka <lhotka@nic.cz>
Date: Tue, 23 Jun 2020 06:52:02 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/ew1Vx5Mp2bfHfU-tDbmaz8IDkjc>
Subject: [i2rs] Yangdoctors last call review of draft-ietf-i2rs-yang-l2-network-topology-13
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jun 2020 13:52:03 -0000

Reviewer: Ladislav Lhotka
Review result: Ready with Nits

I already reviewed revision -04 of this document with the conclusion that from
YANG point of view it is ready to be published. It is still the case with the
current revision -13. All my earlier comments have been addressed.

I appreciate the example in Appendix B, it is really useful. However, I
discovered several problems with the JSON instance data:

- In all 6 entries of the "ietf-network-topology:link" list, commas are missing
after the "source" object.

- The identifier "ietf-l2-topology:l2-termination-point-attributes" is split
between two lines (7 times), which makes it invalid. While this is explained in
the introductory text, I would suggest to find another way of satisfying the 72
character limit that doesn't affect the instance data validity. One option is
to use the convention of draft-ietf-netmod-artwork-folding-12, but it is also
possible to simply dedent the offending lines.

- According to the rules of RFC 7951, the identifier of "termination-point"
list needs to be qualified with module name, i.e.
"ietf-network-topology:termination-point".

- The format of "mac-address" leaves doesn't match the regex pattern of their
types: semicolons rather than dashes have to be used as octet separators.