Re: [Ice] I-D Action: draft-ietf-ice-trickle-19.txt

Christer Holmberg <christer.holmberg@ericsson.com> Fri, 06 April 2018 03:17 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: ice@ietfa.amsl.com
Delivered-To: ice@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E044C12E87D for <ice@ietfa.amsl.com>; Thu, 5 Apr 2018 20:17:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.32
X-Spam-Level:
X-Spam-Status: No, score=-4.32 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ocmk29Vo_mE6 for <ice@ietfa.amsl.com>; Thu, 5 Apr 2018 20:17:41 -0700 (PDT)
Received: from sesbmg22.ericsson.net (sesbmg22.ericsson.net [193.180.251.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDC0B12E87C for <ice@ietf.org>; Thu, 5 Apr 2018 20:17:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1522984658; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=H++BS/xGTNMLvfrk7lnAuem8yb8q++uRYhULnPKVAEY=; b=RHnmShA/QMteolcu9Tn1fwPPQA55AsYum4UsuIkiHuceHHmkTUw2vz9lth7XIvtZ 3JgquDeCzNPaPoU00sSQ3Y1Fmgi+JWHN5ajaxg6sTMMIxkYgV1jwBAS8/agqaT1I GL9v/MLtrLYGSQqGopuvfEw1l9HOSulsutPq6WvWNe0=;
X-AuditID: c1b4fb30-a99ff70000005e22-50-5ac6e6d2abca
Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id F5.9D.24098.2D6E6CA5; Fri, 6 Apr 2018 05:17:38 +0200 (CEST)
Received: from ESESSMB109.ericsson.se ([169.254.9.115]) by ESESSHC002.ericsson.se ([153.88.183.24]) with mapi id 14.03.0382.000; Fri, 6 Apr 2018 05:17:38 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Peter Saint-Andre <stpeter@mozilla.com>
CC: "ice@ietf.org" <ice@ietf.org>
Thread-Topic: [Ice] I-D Action: draft-ietf-ice-trickle-19.txt
Thread-Index: AQHTzQOfCKJgJePi7US1u8Loo3rkkKPyTFeAgAA2enD///VlAIAAmWLp
Date: Fri, 06 Apr 2018 03:17:37 +0000
Message-ID: <4D6CCAB5-BD6C-469E-AEAA-4887554E0E23@ericsson.com>
References: <152294934091.25921.10530377448316012094@ietfa.amsl.com> <abbf2b2b-3c40-63e6-f1e6-7f1efe1b9d7e@mozilla.com> <7594FB04B1934943A5C02806D1A2204B72E4A6BD@ESESSMB109.ericsson.se>, <22036e60-ec76-9454-ad37-cd150aa1c151@mozilla.com>
In-Reply-To: <22036e60-ec76-9454-ad37-cd150aa1c151@mozilla.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Content-Type: multipart/alternative; boundary="_000_4D6CCAB5BD6C469EAEAA4887554E0E23ericssoncom_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42KZGbFdQvfSs2NRBv8vmFl8u1Br8WzlKUYH Jo8lS34yefQd6GINYIrisklJzcksSy3St0vgyvg45RB7wR2Dik87f7M3MK7T7GLk5JAQMJFo vHGTqYuRi0NI4AijxJsdP1ghnMWMEq8ONLJ0MXJwsAlYSHT/0wZpEBHQlrh5aC9YmFlAUeLl XjUQU1jARuL5z0KICluJYx2nmCBsN4nHDzvYQWwWARWJb9Pngdm8AvYSfUt3Q236wCjx8f1T RpA5nECJ1e9NQWoYBcQkvp9aAzaHWUBc4taT+UwQJwtILNlznhnCFpV4+fgfK0RNssTczVuY IeYLSpyc+YRlAqPwLCTts5CUzUJSBhHXk7gxdQobhK0tsWzha2YIW1dixr9DLMjiCxjZVzGK FqcWJ+WmGxnppRZlJhcX5+fp5aWWbGIERs7BLb8NdjC+fO54iFGAg1GJh/fXw2NRQqyJZcWV uYcYJTiYlUR4ncOAQrwpiZVVqUX58UWlOanFhxilOViUxHkt/DZHCQmkJ5akZqemFqQWwWSZ ODilGhjtM0VV14TdelDstmRq9eaLLstSv83XzBe6Vy/sKDp9wnO7xaHKHSJRk5QX7DKs3J+s c2yeGHPHNllz5d1vfbs5E3+GBOkfWvTgttt0Z/VlTnGZ0v2zZ36vaxfvfsrFExD/6HiYXzKH SXbmdfXk8P2hR59ctGbQvrFml16msPHF6LVXrZfwSSqxFGckGmoxFxUnAgAkSf+XmAIAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/ice/6t04JuVh4HW9rF6BF1dL7Hp2heQ>
Subject: Re: [Ice] I-D Action: draft-ietf-ice-trickle-19.txt
X-BeenThere: ice@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interactive Connectivity Establishment \(ICE\)" <ice.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ice>, <mailto:ice-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ice/>
List-Post: <mailto:ice@ietf.org>
List-Help: <mailto:ice-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ice>, <mailto:ice-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 03:17:43 -0000

Hi.

If the procedures in section 7 only happens when the check lists are initially created, maybe that needs to be more explicit.

Also, regarding the pruning text, if you remove the text about peer reflexive I guess you could simply reference 5245bis for the pruning procedure - no need to copy/paste the procedure text.

Regards,

Christer

Sent from my iPhone

On 5 Apr 2018, at 23.08, Peter Saint-Andre <stpeter@mozilla.com<mailto:stpeter@mozilla.com>> wrote:

On 4/5/18 12:58 PM, Christer Holmberg wrote:
Hi,

Still a few questions:

Thanks for the continued review.

The text in section 7.1 says:

  "With regard to pruning of duplicate candidate pairs, a Trickle ICE
  agent SHOULD follow a policy of keeping the higher priority candidate
  unless it is peer reflexive."

Wasn't there a question on the "unless it is peer reflexive" part?

Ah, I thought I had removed that. It was in two places, and I missed
this one.

---

The text in section 8.1 says:

     "2.  The agent eliminates redundant pairs by following the rules in
      Section 5.1.3 of [rfc5245bis], but only if the old pair has a
      state of Waiting or Frozen (thus avoiding removal of pairs for
      which connectivity checks are in flight or for which connectivity
      checks have already yielded a definitive result)."

I realized that Section 5.1.3 of 5245bis does not talk about eliminating of pairs - it only talks about eliminating of redundant candidates. So, shouldn't the eliminating of pairs be covered in section 7.1?

IMHO §8.1 (of draft-ietf-ice-trickle) is the right place for this text,
because it's about how to handle new candidates/pairs. But we need to
clear up the distinction between candidates and pairs in §8 and §8.1.
I'll look at this more closely and post to the list again.

Peter