[Idr] RtgDir Early review: draft-ietf-idr-bgp-open-policy-15.txt

Mach Chen <mach.chen@huawei.com> Thu, 13 May 2021 06:50 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FE6C3A2A52; Wed, 12 May 2021 23:50:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9Ytk8wh-wqPr; Wed, 12 May 2021 23:49:59 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9B5CC3A2A51; Wed, 12 May 2021 23:49:59 -0700 (PDT)
Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Fghry0TL0z6rm0h; Thu, 13 May 2021 14:41:38 +0800 (CST)
Received: from dggpemm100002.china.huawei.com (7.185.36.179) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 13 May 2021 08:49:57 +0200
Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm100002.china.huawei.com (7.185.36.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 13 May 2021 14:49:55 +0800
Received: from dggpemm500002.china.huawei.com ([7.185.36.229]) by dggpemm500002.china.huawei.com ([7.185.36.229]) with mapi id 15.01.2176.012; Thu, 13 May 2021 14:49:55 +0800
From: Mach Chen <mach.chen@huawei.com>
To: "idr-chairs@ietf.org" <idr-chairs@ietf.org>, "draft-ietf-idr-bgp-open-policy.all@ietf.org" <draft-ietf-idr-bgp-open-policy.all@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: RtgDir Early review: draft-ietf-idr-bgp-open-policy-15.txt
Thread-Index: AddHqF05jAuFF5QzTsaQPC2aQyKdxQ==
Date: Thu, 13 May 2021 06:49:55 +0000
Message-ID: <e45c1b2dcd1a493f9022bb1d9fff40bb@huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.108.243.140]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/0sFXZgdoMAktI7G4dKUGmMhU5Ys>
Subject: [Idr] RtgDir Early review: draft-ietf-idr-bgp-open-policy-15.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 May 2021 06:50:04 -0000

Hello

I have been selected to do a routing directorate “early” review of this draft.
​https://datatracker.ietf.org/doc/ draft-ietf-idr-bgp-open-policy /

The routing directorate will, on request from the working group chair, perform an “early” review of a draft before it is submitted for publication to the IESG. The early review can be performed at any time during the draft’s lifetime as a working group document. The purpose of the early review depends on the stage that the document has reached.

As this document has been sent to IESG for publication, my focus for the review was to determine whether the document is ready to be published. Please consider my comments along with the other last call comments.

Document: draft-ietf-idr-bgp-open-policy-15.txt
Reviewer: Mach Chen
Review Date: 2021/05/13
Intended Status: Standards Track

Summary:

This document is basically ready for publication, but has nits and minor concerns that should be considered prior to being submitted to the IESG.

Comments:

Section 6. 
It does not specify how a speaker handle a route with OTC attribute but the sender's role is unknown.


Nits:

Section 2. 
s/ their customers/its customers

Section 3.
s/Allowed Role values/Allowed Roles

Section 4.
It's better to update the table as follows:

                      +-------+---------------------+
                      | Value | Role name           |
                      +-------+---------------------+
                      |   0   | Sender is Provider  |
                      |   1   | Sender is RS        |
                      |   2   | Sender is RS-client |
                      |   3   | Sender is Customer  |
                      |   4   | Sender is Peer      |
                      | 5-255  | Reserved      |                         
                      +-------+---------------------+

Section 5.
OLD:
"If the role of the receiving speaker for the eBGP session in
   consideration is included in Table 1 and the observed Role pair is
   not in the above table,"
NEW:

"If the observed Role pair is not in the above table,"

IMHO, it's redundant to include "If the role of the receiving speaker for the eBGP session in consideration is included in Table 1", just keep the second half of the sentence is enough.

Section 5.1

s/send a send a/send a, there is a redundant "send a".

Best regards,
Mach