Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis, worth fixing?
Christoph Loibl <c@tix.at> Thu, 24 September 2020 09:48 UTC
Return-Path: <c@tix.at>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF1663A0985; Thu, 24 Sep 2020 02:48:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=tix.at
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dTQaGlRjRvfd; Thu, 24 Sep 2020 02:48:56 -0700 (PDT)
Received: from mail.fbsd.host (mail.fbsd.host [IPv6:2001:858:58::22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 653733A0982; Thu, 24 Sep 2020 02:48:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tix.at; s=rev1; h=References:To:Cc:In-Reply-To:Date:Subject:Mime-Version:Content-Type :Message-Id:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=b6INii6tlRzFC8AIYLzuhrWxpVAjF6VDHJX6kuwDs18=; b=fz0d7hC+ijq/Nk1wVsTPlJHjI2 rtrhFZRmi8/vqjYmEQrPXbagq3+oBgbQ1eDeMiWMVh7LM/3Ft6uiY/gT32Zi6CjUSTTnDfFCPNHJU q7Q2AdcIVPCzmI0YMcKfJ6kTusW72ULwcSgCdp5rVIHpowM3a8GLFpPHT96qBfRHia9D38FGzdoLu wUvTFCBNOoxpEy62txfkVQWxmAGWUBeNfwa5W2DHBjNWbtWILfViwfyH/K8qHW3MiYtgUxap2iRud 3NyS9JOtgtPZypW2OvToapXp5t93NyOMU5C0ZvVd3qZ9tt8RqND5qCBR4tjJnKdJ0gCRDgLjXjFM9 W054eKZA==;
Received: from 089144194067.atnat0003.highway.a1.net ([89.144.194.67] helo=[192.168.43.10]) by mail.fbsd.host with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from <c@tix.at>) id 1kLNrq-0003yT-EN; Thu, 24 Sep 2020 11:48:48 +0200
From: Christoph Loibl <c@tix.at>
Message-Id: <C0952E92-34D8-4E05-A6A5-5ED0158BE751@tix.at>
Content-Type: multipart/alternative; boundary="Apple-Mail=_1BAAD644-1ECD-4236-9003-76C11FA10FB7"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Date: Thu, 24 Sep 2020 11:48:44 +0200
In-Reply-To: <CAMMESsy8uZb9GLgh12LD9SvYSxZeMczy52TDM30w88Fbx5+2Nw@mail.gmail.com>
Cc: John Scudder <jgs@juniper.net>, "idr@ietf. org" <idr@ietf.org>, "Dongjie (Jimmy)" <jie.dong@huawei.com>, Hares Susan <shares@ndzh.com>, "draft-ietf-idr-rfc5575bis@ietf.org" <draft-ietf-idr-rfc5575bis@ietf.org>
To: Alvaro Retana <aretana.ietf@gmail.com>
References: <303E54F6-833A-4458-B3E6-DE90E7CA121B@juniper.net> <CAMMESsy8uZb9GLgh12LD9SvYSxZeMczy52TDM30w88Fbx5+2Nw@mail.gmail.com>
X-Mailer: Apple Mail (2.3608.120.23.2.1)
X-Scanned-By: primary on mail.fbsd.host (78.142.178.22); Thu, 24 Sep 2020 11:48:46 +0200
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/0whTfv3WIeHlBK2RKN652Ow45sg>
Subject: Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis, worth fixing?
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Sep 2020 09:49:00 -0000
Hi, I fully agree with Alvaro (to both statements). John: If you want me to edit this phrase into the document I think there won't be any objections (while I believe it is not needed). How shall we continue (should I do the change or is this something RFC-editors are doing now?). Cheers Christoph -- Christoph Loibl c@tix.at | CL8-RIPE | PGP-Key-ID: 0x4B2C0055 | http://www.nextlayer.at > On 23.09.2020, at 23:37, Alvaro Retana <aretana.ietf@gmail.com> wrote: > > John: > > Hi! > > Personal opinion: I believe that the “specified here” part (meaning this document) is already covering the unknown case. However, I have no objections to adding the phrase in. > > > Thanks! > > Alvaro. > > On September 23, 2020 at 5:14:50 PM, John Scudder (jgs@juniper.net <mailto:jgs@juniper.net>) wrote: > >> Hi All, >> >> I’m a little concerned about a change I failed to notice earlier in 5575bis. Version 17 had this paragraph in Section 4.2: >> >> All combinations of component types within a single NLRI are allowed, >> even if the combination makes no sense from a semantical perspective. >> If a given component type within a prefix in unknown, the prefix in >> question cannot be used for traffic filtering purposes by the >> receiver. Since a Flow Specification has the semantics of a logical >> AND of all components, if a component is FALSE, by definition it >> cannot be applied. However, for the purposes of BGP route >> propagation, this prefix should still be transmitted since BGP route >> distribution is independent on NLRI semantics. >> >> Version 18 removed the paragraph. I believe it was removed because of good and reasonable concerns about the “prefix should still be transmitted” part. But, it appears we threw out the baby with the bathwater: the final version of the draft has nothing that corresponds to the underlined part. It is underspecified with respect to what should be done with unknown component types. The closest it comes is this paragraph in Section 4.2 of version 26: >> >> A NLRI value not encoded as specified specified here is considered >> malformed and error handling according to Section 10 <https://tools.ietf.org/html/draft-ietf-idr-rfc5575bis-26#section-10> is performed. >> >> But I think this falls well short of being either clear or unambiguous, because what does “as specified here” mean exactly? >> >> I’d like to open a discussion of whether the WG agrees that this is a bug and if so, whether it’s concerning enough to request a last-minute patch to the document, which is currently with the RFC Editor, so it’s almost an RFC. I think the least intrusive fix would be to insert the clause “including an NLRI that contains an unknown component type”, as in: >> >> A NLRI value not encoded as specified here, >> including an NLRI that contains an unknown component type, >> is considered >> malformed and error handling according to Section 10 <https://tools.ietf.org/html/draft-ietf-idr-rfc5575bis-26#section-10> is performed. >> >> Just as a side note, “error handling according to Section 10” points us to RFCs 7606 and 4760, which end up telling us to reset the session if the NLRI is malformed. >> >> Until we get a chance to discuss this, I’ve sent a note to the RFC Editor asking them to hold publication. >> >> Thanks, >> >> —John >> >> P.S.: The version 26 text also has a proofreading error, “specified specified”. But I assume the RFC Editor would fix that anyway.
- [Idr] Bug in draft-ietf-idr-rfc5575bis, worth fix… John Scudder
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Alvaro Retana
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Robert Raszuk
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Robert Raszuk
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Christoph Loibl
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… McPherson, Danny
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Susan Hares
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… bruno.decraene
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Robert Raszuk
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Christoph Loibl
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Susan Hares
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Dongjie (Jimmy)
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… bruno.decraene
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Alvaro Retana
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Christoph Loibl
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Robert Raszuk
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Jakob Heitz (jheitz)
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Robert Raszuk
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… bruno.decraene
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… bruno.decraene
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… John Scudder
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Robert Raszuk
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Jakob Heitz (jheitz)
- Re: [Idr] [BULK] [BULK] Bug in draft-ietf-idr-rfc… Christoph Loibl
- Re: [Idr] [BULK] [BULK] Bug in draft-ietf-idr-rfc… John Scudder
- Re: [Idr] [BULK] [BULK] Bug in draft-ietf-idr-rfc… Christoph Loibl
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Dongjie (Jimmy)
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Jakob Heitz (jheitz)
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Robert Raszuk
- Re: [Idr] [BULK] [BULK] Bug in draft-ietf-idr-rfc… Susan Hares
- Re: [Idr] [BULK] [BULK] Bug in draft-ietf-idr-rfc… John Scudder
- Re: [Idr] [BULK] [BULK] Bug in draft-ietf-idr-rfc… Susan Hares
- Re: [Idr] [BULK] [BULK] [BULK] Bug in draft-ietf-… Christoph Loibl
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… Alvaro Retana
- Re: [Idr] Bug in draft-ietf-idr-rfc5575bis, worth… John Scudder
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Jeffrey Haas
- Re: [Idr] [BULK] Bug in draft-ietf-idr-rfc5575bis… Jeffrey Haas