Re: [Idr] WG LC draft-ietf-idr-flowspec-path-redirect-10.txt [11/17/2019 to 12/2/2019]

Jeffrey Haas <jhaas@pfrc.org> Thu, 28 November 2019 13:21 UTC

Return-Path: <jhaas@pfrc.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D14212086C for <idr@ietfa.amsl.com>; Thu, 28 Nov 2019 05:21:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aXXgczTTukbL for <idr@ietfa.amsl.com>; Thu, 28 Nov 2019 05:21:09 -0800 (PST)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 8FEEA120119 for <idr@ietf.org>; Thu, 28 Nov 2019 05:21:09 -0800 (PST)
Received: from dresden.attlocal.net (99-59-193-67.lightspeed.livnmi.sbcglobal.net [99.59.193.67]) by slice.pfrc.org (Postfix) with ESMTPSA id 283E01E2F2; Thu, 28 Nov 2019 08:25:16 -0500 (EST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
From: Jeffrey Haas <jhaas@pfrc.org>
In-Reply-To: <016501d59dd2$e5458850$afd098f0$@ndzh.com>
Date: Thu, 28 Nov 2019 08:21:07 -0500
Cc: idr@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <D0AA5E62-4AE5-43A5-BA23-E66D98AF657B@pfrc.org>
References: <016501d59dd2$e5458850$afd098f0$@ndzh.com>
To: Sue Hares <shares@ndzh.com>
X-Mailer: Apple Mail (2.3601.0.10)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/4BtXPNon8Jj0X__pSGYJSG4A13g>
Subject: Re: [Idr] WG LC draft-ietf-idr-flowspec-path-redirect-10.txt [11/17/2019 to 12/2/2019]
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Nov 2019 13:21:11 -0000

Sue,



> On Nov 18, 2019, at 12:41 AM, Susan Hares <shares@ndzh.com>; wrote:
> 
> This begins a 2 week WG Last call on draft-idr-flowspec-path-redirect-10.txt from [11/17/2019 to 12/2/2019]. 
>  
> You can obtain the draft at:
>  
> https://datatracker.ietf.org/doc/draft-ietf-idr-flowspec-path-redirect/
>  
> Consider in your review whether this draft: 
>  
> 1)      Is compatible with draft-ietf-rfc5575bis-17.txt? 

Yes.  (Close enough.)  The current version of the draft is implementable.

> 2)      Whether the draft is useful for deployments of flow specification

It can be useful.

> 3)      Is this technology ready for deployment? 
> 4)      Is the write-up of this technology in draft-ietf-idr-flowspec-path-redirect clearly written and ready for publication? 

Ready with minor issues, IMO:

Procedure-wise, there needs to be a bit more text covering cases about interactions with other traffic actions.  This was a known headache for similar drafts such as redirect-to-ip.  In particular, interaction with redirect-to-ip and redirect-to-vrf is needed.

The text "A single flowspec rule MUST NOT have more as one indirection-id per S-ID.  On a flowspec client the indirection-id with lowest S-ID MUST be imposed first for any given flowspec entry."  There's no procedure for what happens in error handling when you do have more than one of the same S-ID.  The text about the case for S-ID of 0 is also a bit ambiguous.  It feels like it's reading "there is no sequence", but what do you do when you then have ones that do?

A few IANA issues:
I see the type registry is currently registered with IANA (code point 0x09).  However, the sub-type registry is not established for some reason?
The ID-Type field likely needs its own IANA registry.  Values 1-5 are defined in this draft.

The flags field (one octet) currently has 3 bits reserved.  In the past, we've not done a registry for such cases (c.f. graceful restart) until we need to start carving out those reserved bits for future extensions.  I leave it to the chairs' opinion whether we want this a priori or not.



>  
> Thank you for considering this draft. 
>  
> Cheerily, Susan Hares 
>  
> _______________________________________________
> Idr mailing list
> Idr@ietf.org
> https://www.ietf.org/mailman/listinfo/idr