Re: [Idr] AD Review of draft-ietf-idr-tunnel-encaps-15

John Scudder <jgs@juniper.net> Mon, 04 May 2020 20:51 UTC

Return-Path: <jgs@juniper.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C839D3A1056; Mon, 4 May 2020 13:51:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b=dPAs3A8e; dkim=pass (1024-bit key) header.d=juniper.net header.b=QhZrqIIA
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2t0bfN428lJn; Mon, 4 May 2020 13:51:49 -0700 (PDT)
Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1AD63A1042; Mon, 4 May 2020 13:50:36 -0700 (PDT)
Received: from pps.filterd (m0108156.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 044KmnRB032446; Mon, 4 May 2020 13:50:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=CapUXO3ACYNxaCq3EvTfkOLxEm7sL2l1/+77xrAbisg=; b=dPAs3A8e93I0gergPeTbHXhtBni/7IhIxBVwp4pCl0DcklzmvAb9WHscRHfa+OpJ6Hhk uFHM//aYB6A29Mm5zPUEWBPNn+DZRU5KAQT6fnv15KtqldWyPr0PR0TrTAhKVk0TL+F1 O90TuJF7hCKzbrMZjuAsEdaxlQbKJ958aA+cSesQh6qghLgEK7kqHGwkZ91X6Ddy0qAH fTg4wHiSXOrU6eZhthc0lc0qFO1hXJOCsY8Hdxn44OM9na50P6JoANd2BIO38Cl4H35j L0AEBgo9S84l8yy8X3ofCHo58IWCfgyuYxNSJrNvI8f/dzkLQ2P+WH43AkNjno19nGfe aQ==
Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by mx0a-00273201.pphosted.com with ESMTP id 30s7vqbjed-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 May 2020 13:50:35 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0OALCWRCxNwLMvu/TVtdSNgJDk1O/J/vfPAg9KaLS6ADsye25uwDOjh9w6RnWnaiivgcmVVz3+RQpaZiOJN5BCgfmxcTE2eTfclEGZKiYzYmWvg9OgOygrc4CVDGDRhKPHRHAiyNRCTehm6avs9ERYZ2FxTVTIFpgqjSFW/VPFGsu3jZOefWieKxkACl9JaegcgRFtp5Wu0zerMiVIZK6RPUrYbkWvFIW5EjVDf7freL2CS770tYWPPduUoQu+iDv96ns7j4HaqqTSpx4IjyzhTfZaxDpYehojpEHjjS7pjHCf/qBBs/nAUOch7f7moZ4piAr0xWMfSxwRVfv+SJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CapUXO3ACYNxaCq3EvTfkOLxEm7sL2l1/+77xrAbisg=; b=FB0LUA+g5d9zL/nJXfToVyILgnVQ7ElX+NJ4E3Hy1rJgQyerpCO+ikZlmtow2khggEp8sodBmEL8wx4nvm8JWuBDSRCS4OfmVMXbDp2WEDX/9GhozN6lO1VtKFduzfKHXI0TLzo0In91pT6D2e7aPE0/aUIjAqctMuCWBr99jq/hWgYKhVPiSsM6FK2sDY5tC3JBCAsMjgfDoTgL07/Z8Z3MzgVjWAJxYx2WK9/Ut4MV7QSwIfFP6JCQid8o1aisJMNebRFgn5THHK0i6T85KwWY71iMENnvqpnq+cKYvzue7naoULLqydFzAQnRI6HrlPf32mh1SKAHU/jSLlddag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CapUXO3ACYNxaCq3EvTfkOLxEm7sL2l1/+77xrAbisg=; b=QhZrqIIA149AEheHGz4OAp0ooRWNWCwIVTgeYeqA3RjIdZRHB7/7YCbDUrewhmHFvL3R31onzCi1emgyPqr6usBErGalcfN0oFWx04vWsRx/RWtSXkRhDJKsp4cs6DUTE6s6q6cf1FcvaHEzjwtHyXpznbDwqFnwhxbvSpd+CKU=
Received: from BL0PR05MB5076.namprd05.prod.outlook.com (2603:10b6:208:83::12) by BL0PR05MB5425.namprd05.prod.outlook.com (2603:10b6:208:2f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.14; Mon, 4 May 2020 20:50:33 +0000
Received: from BL0PR05MB5076.namprd05.prod.outlook.com ([fe80::d450:6f4c:4c28:b45f]) by BL0PR05MB5076.namprd05.prod.outlook.com ([fe80::d450:6f4c:4c28:b45f%7]) with mapi id 15.20.2979.024; Mon, 4 May 2020 20:50:33 +0000
From: John Scudder <jgs@juniper.net>
To: Alvaro Retana <aretana.ietf@gmail.com>
CC: "draft-ietf-idr-tunnel-encaps@ietf.org" <draft-ietf-idr-tunnel-encaps@ietf.org>, "idr-chairs@ietf.org" <idr-chairs@ietf.org>, "idr@ietf. org" <idr@ietf.org>
Thread-Topic: AD Review of draft-ietf-idr-tunnel-encaps-15
Thread-Index: AQHV6LURgETtNTA88kySyYPq0YikO6iY2eMA
Date: Mon, 4 May 2020 20:50:32 +0000
Message-ID: <56ABBBD4-3B79-40B2-9DE1-BCE943EABEFC@juniper.net>
References: <CAMMESsw09LGWWhqyJ_0=jRimUN+_UuCjaXHCdqF9zkpaxSQgVQ@mail.gmail.com>
In-Reply-To: <CAMMESsw09LGWWhqyJ_0=jRimUN+_UuCjaXHCdqF9zkpaxSQgVQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.80.23.2.2)
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=juniper.net;
x-originating-ip: [66.129.241.14]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 350d7d50-ca59-48f5-0450-08d7f06cc9e8
x-ms-traffictypediagnostic: BL0PR05MB5425:
x-microsoft-antispam-prvs: <BL0PR05MB542514E642029F13928381A0AAA60@BL0PR05MB5425.namprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 03932714EB
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 0Zx5JYT+aNqfqsjDwetoQ4Aew9iGEwFqTbfd70zhwjlnrXTtPuByXC9drSkJ8mduRQpJ4o1mLD7WlTgsHml0dCftSfCAn1Cbrhzohslueyvfp8CO4PK0vT6Y9q494tJRvMyK0Lon00CcB25Dbje//khrYqwQzGp68OBNEQ4VGd6fzwi8YcLhwIXNcinRPkwTMfO0K83RhVlLROu9nQJiTyl0Y5Vv8V0DWbqg9Hl5B0c5a5BmP6gAcwBCH9gssTZMCzZZtcdlla2bWgfJsokSobBiInt3e+aREtlJjqRobLfvexxV6M2ptgcFmdQchbSZvvSAo0i+Lj4ofNnTAQ3HNt3NuBRmeQu1Jeq9wmHHOc2682YRHMEY4IFPJjA9LrQ630yGOhzofsHfNspXAz2PU50eXAt2VCKvMZhcu8mKGJ/VUDFnuxetEm5EyIFtn2SS
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR05MB5076.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(346002)(136003)(396003)(366004)(2906002)(54906003)(6916009)(26005)(186003)(316002)(6512007)(478600001)(36756003)(86362001)(33656002)(8676002)(5660300002)(66946007)(8936002)(4326008)(53546011)(2616005)(71200400001)(76116006)(6506007)(6486002)(66556008)(64756008)(66446008)(66476007); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: HmgN8tHi6bMhBWWSzPDRxqxj8ZU0d1S+M6ualwBF/B7jSugHSWBmQpiPwYf2Mi92OKHOklHHyQcsbUeIv8Q7GJU7+/rr12ojhi8GM52aYNadqBYPmiYI9yd7ixINm82dGcYELZrlEcfzT725CS3Y3VI2vkUHJ15M4i0iWr+IFujKGn/HXLiUN9P+W6Ioa1BJTSN16ft+anzewh7AELkqY/4n3DWDOdG4KYduwMt7CxmBbfOaR/zTzc/KuMjx8nqHzMRJ22DubRd49zPQwGG0x+coLV3sNMg03g4dnmEVXK7HX756yXj0dYaQznWZaR57nzKzDms9xPn/H7Mal4NQP47REdVyG/zYqBD9orB6YGOZKvyk/qo6fbWlLmxXsdMRzEGJBbn1VftJxsWiTocaScW4THQ8I3NsMY75zH2rxExU54mKHiUxS0nAOPc9kZGjKN3gEC969LQOA7jWsaSFXPQ+Zbe555z0GMST/idMUEm+Za9OKmnWg5qcjFRs8CWn9X6EDuBL7JLbZTIRqY2DChEfZXqzKl1JAXolvmWpfMEv3CX/m1AYwlknOKHCQrl25kZoYFwhTzOpI4mWuw8CY3yS53BeOIOSXQG75jrn9Aqcpf26y6AVzQrWMw7GkLZEoTbrmLe3aI9SiTV1uIjJIZJiJed7ksLnZYaZR7I2j7M8PIT80dJyemIokcy+rR/QDeuprO4Jci8HpDftrDA0CTa4UvD2kSvG545xtR1OVcMc7M925CnPUetuCXRcXY8nOGwbHznJao9iBetLqL3nihLB7bvR7LygznqQNGROnW0=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_56ABBBD43B7940B29DE1BCE943EABEFCjunipernet_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 350d7d50-ca59-48f5-0450-08d7f06cc9e8
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2020 20:50:32.9435 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IBjJUFEBuxwIdpNxMl9Qh4dVDjHiccEglqINcvOu+MmwHQVCbrF48usJD5mdHaPg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB5425
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-04_11:2020-05-04, 2020-05-04 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 mlxscore=0 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005040162
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/53jv3dMVzB9-rQYPWuIyuk_pHi0>
Subject: Re: [Idr] AD Review of draft-ietf-idr-tunnel-encaps-15
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 May 2020 20:51:58 -0000

Hi Alvaro,

On Feb 21, 2020, at 7:47 AM, Alvaro Retana <aretana.ietf@gmail.com<mailto:aretana.ietf@gmail.com>> wrote:

442    When redistributing a route that is carrying a Tunnel Encapsulation
443    attribute containing a TLV that itself contains a malformed Tunnel
444    Endpoint sub-TLV, the TLV MUST be removed from the attribute before
445    redistribution.

[minor] This paragraph seems to say the same thing as §11, but please
take it out and specify things only once.

You’re referring to this paragraph in section 11?

   In general, if a TLV contains a sub-TLV that is malformed (e.g.,
   contains a length field whose value is not legal for that sub-TLV),
   the sub-TLV should be treated as if it were an unrecognized sub-TLV.
   This document specifies one exception to this rule -- within a tunnel
   encapsulation attribute that is carried by a BGP UPDATE whose AFI/
   SAFI is one of those explicitly listed in the second paragraph of
   Section 5, if a TLV contains a malformed Tunnel Egress Endpoint sub-
   TLV (as defined in Section 3.1), the entire TLV MUST be ignored, and
   MUST be removed from the Tunnel Encapsulation attribute before the
   route carrying that attribute is redistributed.

I’m inclined to agree with you that it covers the same ground. There is one difference, though: the section 11 paragraph is conditioned on the second paragraph of section 5:

   The BGP Tunnel Encapsulation attribute MAY be carried in any BGP
   UPDATE message whose AFI/SAFI is 1/1 (IPv4 Unicast), 2/1 (IPv6
   Unicast), 1/4 (IPv4 Labeled Unicast), 2/4 (IPv6 Labeled Unicast),
   1/128 (VPN-IPv4 Labeled Unicast), 2/128 (VPN-IPv6 Labeled Unicast),
   or 25/70 (Ethernet VPN, usually known as EVPN)).  Use of the Tunnel
   Encapsulation attribute in BGP UPDATE messages of other AFI/SAFIs is
   outside the scope of this document.

So the section 3.1 language you quoted could be considered to mean something just slightly different. Options I can think of include:

- Ditch the section 3.1 language anyway, it’s close enough and besides section 5 says that all other AFI/SAFI are “beyond the scope of this document”.
- Leave the section 3.1 language, because it’s more general.
- Get rid of the condition in the section 11 language. (And also get rid of the 3.1 language.)

I kind of like the third option. Thoughts? (Not just from Alvaro but from the authors and the WG?)

—John