Re: [Idr] [yang-doctors] Yangdoctors early review of draft-ietf-idr-bgp-model-07
Andy Bierman <andy@yumaworks.com> Thu, 02 January 2020 21:28 UTC
Return-Path: <andy@yumaworks.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3E0F120164 for <idr@ietfa.amsl.com>; Thu, 2 Jan 2020 13:28:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XfHWuaf6-tld for <idr@ietfa.amsl.com>; Thu, 2 Jan 2020 13:28:15 -0800 (PST)
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49A7B12004D for <idr@ietf.org>; Thu, 2 Jan 2020 13:28:15 -0800 (PST)
Received: by mail-lf1-x132.google.com with SMTP id b15so30732539lfc.4 for <idr@ietf.org>; Thu, 02 Jan 2020 13:28:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CbMxM3zr+jg9dlsaqJdw4+Zc9avO6OsckYoIXHUhbLA=; b=1XvMGa9GYGvSUjbCzWxJco1UqD5q2XKKERTKZG738OSMFmyemG6d5FCI+qZJV/AY7+ A2NF66WYrLkjJ1bz+oX5NHdTtqqr3SQXR2M2V0caYh35sXu047ahUTjkr2aL6ibtywIt a33ZvsgUYaMEx4TWcyYVEIEPdw6LA8BqOl9IaF1gW4+8im60cSbtWHo1LIjMR3cRDGib iWZ4p0uJNGiUWyfbLnrWupDOaEqq0RAjxs0vdovdkLhRv1OTpcsM7kgdNbYEwWA2baox 6oJZ2NWOhM2Bv0lA8JxaYT6oab/t8Acr4UvZKz02AYwP/s/PCO6TL+S5eGprtPoece5o 6v3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CbMxM3zr+jg9dlsaqJdw4+Zc9avO6OsckYoIXHUhbLA=; b=bS09w1Q/l5T6rEnaGxsnRP+9kMcOMilMfHWui+g7DI3q59kD8VpHCzQmc3G6R0xcZI 0eb9wlaA4rpnU9JVK8sJOCrpmrFS3lPxhkl5ET+JKfXz1xN0F2WlApbKLLZwbemQxBJG Ij0T5P+TtpDTbqY6qoYOWDNVZ1pzFF0aucqszsu0rFku+N1+4JpNaOWhiTzSwqP8H9TD UcHunXuIa05jKi/F0smKwwxcIHU6jQJzrEXdUYfTt+zYr81UgRDCUOIi/88O153Wgxaf Lv6K8ZkQXTAn85Dy093XntEFbeccUyWF1eer95VygyId/mIBqHmgPsKDVcFN62Hu1fvQ s/3g==
X-Gm-Message-State: APjAAAWoQxD/PXiYlyuiqkerXlk4KilGK8U6VYXu3RoDIXildkE90eFu dsGFwedtbVZP8bxzfsUa52e9veOB36R4qK3TB4nVFA==
X-Google-Smtp-Source: APXvYqy2H/M3fZd3LwGlzNNHQwOpPIs6DT+to0W/UlNRfMYoOaKGSYEGA6oxqm+Z37vLxO2ncGSKzO0IpVS7dy475A8=
X-Received: by 2002:ac2:430d:: with SMTP id l13mr50932029lfh.112.1578000493304; Thu, 02 Jan 2020 13:28:13 -0800 (PST)
MIME-Version: 1.0
References: <157773531468.4577.5049465733732578910@ietfa.amsl.com> <168831D6-8542-4762-9400-0D6D632619FC@cisco.com>
In-Reply-To: <168831D6-8542-4762-9400-0D6D632619FC@cisco.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Thu, 02 Jan 2020 13:28:02 -0800
Message-ID: <CABCOCHRWv1Og5V284Vo_Y8vL=Do0=bYc9EjvfE3_M-d+iuPg-w@mail.gmail.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
Cc: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "idr@ietf.org" <idr@ietf.org>, "draft-ietf-idr-bgp-model.all@ietf.org" <draft-ietf-idr-bgp-model.all@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000dbf54e059b2ede4d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/6ACMdXTo3fg4ttf8u-9BIZ0lk70>
Subject: Re: [Idr] [yang-doctors] Yangdoctors early review of draft-ietf-idr-bgp-model-07
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jan 2020 21:28:18 -0000
On Thu, Jan 2, 2020 at 1:18 PM Acee Lindem (acee) <acee@cisco.com> wrote: > Hi Andy, et al, > > On 12/30/19, 2:49 PM, "yang-doctors on behalf of Andy Bierman via > Datatracker" <yang-doctors-bounces@ietf.org on behalf of noreply@ietf.org> > wrote: > > Reviewer: Andy Bierman > Review result: On the Right Track > > > Major issues: > > - The ietf-bgp module uses (legal) YANG 1.1 constructs that are > not supported by available tools so it cannot be validated. > The solution options are > (A) rewrite the module so it does not place any definitions > in the main module. Instead place all definitions in > submodules. Add YANG 1.0 include-stmts as needed so pyang > can validate the module > (B) wait until the opensource tools properly support this > YANG 1.1 usage and resubmit the module at that time > > - The modules import ietf-routing-policy. Version used was > 2019-03-04. This module has a fatal error caused because > ietf-interface-common has apparently been replaced with > ietf-if-extensions@2019-11-04 > > leaf subinterface { > type leafref { > path "/if:interfaces/if:interface/if-cmn:encapsulation" > + "/if-l3-vlan:dot1q-vlan" > + "/if-l3-vlan:outer-tag/if-l3-vlan:vlan-id"; > } > > The path expression is wrong. if-cmn:encapsulation is now > if-ext:encapsulation. You need to check the XPath everywhere > when you refactor YANG modules. > > I have fixed this in the -08 version. > > https://datatracker.ietf.org/doc/draft-ietf-rtgwg-policy-model/ > > Now, if only we could get the IETF tools to include the > ieee802-dot1q-types.yang model so that ietf-if-l3-vlan.yang parses.... > > I noticed that IEEE modules are being imported into some IETF models now. I did not raise it in the ietf-bgp review but it does raise a process or tools issue. Is it possible to standardize tools based on the github YangModels repo, using standard module search path. e.g -p repo/experimental/ietf-extracted-YANG-models -p repo/standard Thanks, > Acee > Andy > > - Full review of these modules is not possible at this time without > proper opensource tools. Processing the YANG statements > by hand is extremely difficult, given the large amount > of groupings used which are spread across many modules and > submodules. > > > Minor Issues > > - The "clear" actions need to be specific about the exact set > of objects that are affected. The value of each object once it > is cleared needs to be specified in every object that is affected > by the action. Impact on operations should be explained in > each action-stmt > > - Some TODO items still remain indicating the YANG definitions > are temporary and will be replaced by more correct statements. > > - Additional reference-stmts would be useful to implementors > who are familar with the routing RFCs that the YANG objects > are based on > > Editorial Comments > > - The implementation complexity appears to be very high > for both server and client developers. The interactions between > subtrees is non-trivial and probably requires more clarifications. > This needs to be done by implementors, not document reviewers. > > > _______________________________________________ > yang-doctors mailing list > yang-doctors@ietf.org > https://www.ietf.org/mailman/listinfo/yang-doctors > > >
- [Idr] Yangdoctors early review of draft-ietf-idr-… Andy Bierman via Datatracker
- Re: [Idr] [yang-doctors] Yangdoctors early review… Acee Lindem (acee)
- Re: [Idr] [yang-doctors] Yangdoctors early review… Andy Bierman