Re: [Idr] I-D Action: draft-lin-idr-bgp-nof-nlri-01.txt

Robert Raszuk <robert@raszuk.net> Wed, 11 May 2022 20:50 UTC

Return-Path: <robert@raszuk.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C4E5C1595FD for <idr@ietfa.amsl.com>; Wed, 11 May 2022 13:50:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=raszuk.net
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id egCNQzciop0Y for <idr@ietfa.amsl.com>; Wed, 11 May 2022 13:50:10 -0700 (PDT)
Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [IPv6:2607:f8b0:4864:20::a36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B5EB8C1595FB for <idr@ietf.org>; Wed, 11 May 2022 13:50:10 -0700 (PDT)
Received: by mail-vk1-xa36.google.com with SMTP id q136so1731211vke.10 for <idr@ietf.org>; Wed, 11 May 2022 13:50:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raszuk.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=yc8q+xljXV1QgTzpqSfQlv+2sFxi6PL/uzTojnn5Yls=; b=GqqIKV+JaehZaC0LaqNyKNRpcXA6xl2wg/td8mVivhh49U3R1jkOoOrZvhB0k5d4pu EdKQ9tqKmTRRWs2n6GGuwA7CvJU9ebjs0EFbPJNntrjcW3LGdnJJo3YQMBSq5bDhV8ls o9UPzZAI5qVwqQJCWPMZopfGSUqZgSXtoxC4eJ8INM+68GYgcAot0Rzaxd3gxVEYDeD9 VBDbAWZ1QsMdENKSLoG/NgkK++3tWC1xdPIjA+WSgtTQZ/F7pGVFpc+7YId4ZQteF3Bz wqLHkJvFUH7seaJLeRP0U3WKll4rNLqQEV3eG2GYIU4UzuhUC0LD/zJ8bUUC6wfPERxB dfJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=yc8q+xljXV1QgTzpqSfQlv+2sFxi6PL/uzTojnn5Yls=; b=CNRAYNATUL7XdDXzGPtFihXdNSTUyUIsqUEDDnYThf+wAnnh6MrcllEf/G+KYcnzOV PkJ5Jgm+0NAkptRDv3xthgaEGx236UVA5HoEUiPqCoXHSo7pul3ckgdAHNR9F3fjCxDL L1YYf8b60U1eygijl2VNQ7SaujTmriUerj2hTFoss2JrAY7PwH1VpxfUxqIh0sXLc34j ge/Mmy0tVe2XAt38xCgS6EUUQLitsC8mqBMaJUrvUsd5M6Mha54BwG8YlcnmSCUWZ2t9 WBYo9CYVVZg2dyGN8BapcFfn8WKLxCjV5FKelHqgGnbysnq7sM7iaqzMhymG9LocCEk4 W74g==
X-Gm-Message-State: AOAM533CbapywWGQAzcaMN/nDd8K9MDnm+2atoOr2P/ZlDoT7B3Spf+/ 5avaZYYxpF4wGGZ7IJH5zxd/w5G7PTv2P437obn3ZYQn7e7UoA==
X-Google-Smtp-Source: ABdhPJwH5rwbhywdkvfTrsqb84rcTl06ZWIidHdq0Jnznk0VFCwM/QzYuqXPQxxvyvhp1B/3pFXCI5ulQV9dYZxxwzs=
X-Received: by 2002:a1f:e2c7:0:b0:34d:310f:6b0 with SMTP id z190-20020a1fe2c7000000b0034d310f06b0mr15096812vkg.19.1652302208984; Wed, 11 May 2022 13:50:08 -0700 (PDT)
MIME-Version: 1.0
References: <165223635327.45335.11199575676627923397@ietfa.amsl.com>
In-Reply-To: <165223635327.45335.11199575676627923397@ietfa.amsl.com>
From: Robert Raszuk <robert@raszuk.net>
Date: Wed, 11 May 2022 22:50:22 +0200
Message-ID: <CAOj+MMFhWJDdsqx6e3k2ByV2umHiMkoYA-7F+W16wrJV3Z7HOg@mail.gmail.com>
To: "idr@ietf. org" <idr@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000003a7bda05dec2962a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/6dGc5sU0xvz-l4FTM6SOTs8cdD8>
Subject: Re: [Idr] I-D Action: draft-lin-idr-bgp-nof-nlri-01.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2022 20:50:14 -0000

Dear authors of  draft-lin-idr-bgp-nof-nlri/
<https://datatracker.ietf.org/doc/draft-lin-idr-bgp-nof-nlri/>,

I have read your draft and have few comments.

First if we consider BGP to be a database distribution protocol the
described idea seems pretty interesting (in a positive sense). I am not
sure why you would like to use BGP and RRs to discover storage devices,
especially considering that all you need is a p2p information channel.
Moreover PUB-SUB model seems to be also requirement here (for example to
limit received information to a given zone). IMO use of DROID (
https://www.ietf.org/id/draft-li-lsr-droid-00.html) or any other pub-sub
package may be a much better fit.

But let's assume you do want to use the BGP protocol. With that I have two
technical suggestions:

**A** Use Transport Instance BGP with new port number as described in
https://datatracker.ietf.org/doc/html/draft-raszuk-ti-bgp-01

**B** Redefine BGP encoding to define one short NLRI to be an information
key and put all TLVs into the BGP Attribute. Currently "Device Discovery
NLRI" contains in itself all discovery information which is in parallel
accompanied by "Device Zone NLRI". In BGP NLRIs are independent entities
and your encoding model is trying to glue them. Redefining it should be a
pretty simple task from all of the above.

Kind regards,
Robert

On Wed, May 11, 2022 at 4:32 AM <internet-drafts@ietf.org> wrote:

>
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
>
>
>         Title           : Distribution of Device Discovery Information in
> NVMe Over RoCEv2 Storage Network Using BGP
>         Authors         : Changwang Lin
>                           Mengxiao Chen
>                           Hao Li
>                           Ruixue Wang
>                           Fengwei Qin
>                           Qi Zhang
>         Filename        : draft-lin-idr-bgp-nof-nlri-01.txt
>         Pages           : 16
>         Date            : 2022-05-10
>
> Abstract:
>    This document proposes a method of distributing device discovery
>    information in NVMe over RoCEv2 storage network using the BGP
>    routing protocol. A new BGP Network Layer Reachability Information
>    (NLRI) encoding format, named NoF NLRI, is defined.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-lin-idr-bgp-nof-nlri/
>
> There is also an htmlized version available at:
> https://datatracker.ietf.org/doc/html/draft-lin-idr-bgp-nof-nlri-01
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-lin-idr-bgp-nof-nlri-01
>
>
> Internet-Drafts are also available by rsync at rsync.ietf.org:
> :internet-drafts
>
>
> _______________________________________________
> I-D-Announce mailing list
> I-D-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html
> or ftp://ftp.ietf.org/ietf/1shadow-sites.txt
>