Re: [Idr] I-D Action: draft-ietf-idr-large-community-04.txt

David Freedman <david.freedman@uk.clara.net> Tue, 25 October 2016 16:55 UTC

Return-Path: <david.freedman@uk.clara.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 694AE129577 for <idr@ietfa.amsl.com>; Tue, 25 Oct 2016 09:55:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.903
X-Spam-Level:
X-Spam-Status: No, score=-1.903 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6hS5pHtwMgBH for <idr@ietfa.amsl.com>; Tue, 25 Oct 2016 09:55:45 -0700 (PDT)
Received: from mail1.bemta5.messagelabs.com (mail1.bemta5.messagelabs.com [195.245.231.137]) by ietfa.amsl.com (Postfix) with ESMTP id 81829129557 for <idr@ietf.org>; Tue, 25 Oct 2016 09:55:45 -0700 (PDT)
Received: from [85.158.136.83] by server-1.bemta-5.messagelabs.com id 00/20-19721-09E8F085; Tue, 25 Oct 2016 16:55:44 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRWlGSWpSXmKPExsUSsELzi+6EPv4 Igz/PWS1e3X7G5MDosWTJT6YAxijWzLyk/IoE1ox3OycwFpzkq+jqfc/awLiBr4uRi0NI4ACT RMvdaSwQzlpGia3rm4EcTg42ASOJCev2A9kcHCICihIrPyWDmMICLhIdnXIgFSICrhKPbx1mh bD1JBqOnWIEsVkEVCUuth1iArF5Bewlmme/BLMZBWQlvjSuZgaxmQXEJW49mQ8WlxAQkFiy5z wzhC0q8fLxP7CZokAzP91ezQIRV5C4uKCLDeQEZgFNifW79CHG2Eos/LGXFcJWlJjS/ZAdYq2 gxMmZT1gmMArPQrJtFkL3LCTds5B0z0LSvYCRdRWjRnFqUVlqka6hkV5SUWZ6RkluYmaOrqGB qV5uanFxYnpqTmJSsV5yfu4mRmBEMADBDsa+Wc6HGCU5mJREeV17+COE+JLyUyozEosz4otKc 1KLDzHKcHAoSfAK9wLlBItS01Mr0jJzgLEJk5bg4FES4TUASfMWFyTmFmemQ6ROMSpKifPeBp kpAJLIKM2Da4Olg0uMslLCvIxAhwjxFKQW5WaWoMq/YhTnYFQS5vUEGc+TmVcCN/0V0GImoMW C8Twgi0sSEVJSDYzc1auvP/6S8zNX+/6pYuYFP993unp4Wr95USj9x+BD//bjez/2Fr8u+u3V /6XtwoqCuFcTftXKJvB7n9H1t4z58uTTdue0rUs0pD7uMJ/72zi03UfxocI658I3TVttW+YUL 18nv01PsD9xj6Iux6Pvh/eerw+VVP8d2eJgodw7WXODzLzfHzYosRRnJBpqMRcVJwIAxuktPw IDAAA=
X-Env-Sender: david.freedman@uk.clara.net
X-Msg-Ref: server-9.tower-36.messagelabs.com!1477414544!65811131!1
X-Originating-IP: [80.168.41.244]
X-StarScan-Received:
X-StarScan-Version: 9.0.13; banners=-,-,-
X-VirusChecked: Checked
Received: (qmail 7079 invoked from network); 25 Oct 2016 16:55:44 -0000
Received: from staff02.mail.eu.clara.net (HELO staff02.mail.eu.clara.net) (80.168.41.244) by server-9.tower-36.messagelabs.com with SMTP; 25 Oct 2016 16:55:44 -0000
Received: from [80.168.41.252] (port=2343 helo=SRVGREXCAS02.claranet.local) by staff02.mail.eu.clara.net (staff02.mail.eu.clara.net [80.168.41.244]:25) with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1bz50p-0001tY-9X for idr@ietf.org (return-path <david.freedman@uk.clara.net>); Tue, 25 Oct 2016 16:55:43 +0000
Received: from SRVGREXMB01.claranet.local ([fe80::64bc:5d10:5203:a830]) by SRVGREXCAS02.claranet.local ([::1]) with mapi id 14.03.0319.002; Tue, 25 Oct 2016 17:53:32 +0100
From: David Freedman <david.freedman@uk.clara.net>
To: "idr@ietf.org" <idr@ietf.org>
Thread-Topic: [Idr] I-D Action: draft-ietf-idr-large-community-04.txt
Thread-Index: AQHSLuBRsPkuD2mF3UePF3Sqj1Od7w==
Date: Tue, 25 Oct 2016 16:53:32 +0000
Message-ID: <EF5BD8D1-AD17-4305-A5B8-D777C8C00F2D@uk.clara.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1b.0.161010
x-originating-ip: [172.26.6.254]
Content-Type: text/plain; charset="utf-8"
Content-ID: <50A5B9DE2FFA63449BEE8A340EA24556@claranet.local>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/6pY002A5ZanexcygkOKezWz1gWY>
Subject: Re: [Idr] I-D Action: draft-ietf-idr-large-community-04.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2016 16:55:47 -0000

Apologies for the ultra-late-last-minute input, but I was discussing this with Job offlist and we felt it should be seen by list participants.

My point was about RFC1997 parity and the length validation. 

 " A Large BGP Communities attribute with a length of zero MUST be ignored upon receipt and removed when sending." 

Later wording here has been discussed to be amended (I understand) to:

" A Large BGP Communities attribute with a length of zero MUST NOT be sent and MUST be ignored upon receipt."

Well, I wanted to point out, that RFC1997 was of course updated by RFC7606.

In (7606), the following two comments are made:

" For all path attributes other than those specified as having an attribute length that may be zero, it SHALL be considered a syntax error for the attribute to have a length of zero." 

And 

" The error handling of [RFC1997] is revised as follows: The Community attribute SHALL be considered malformed if its length is not a non-zero multiple of 4" 

So really, if you apply RFC7606 to RFC1997 you have lost parity if you accept a zero length community (even if you just ignore it). 

My suggestion here is just to drop the passive receive tolerance of the zero length largecomm, since it seems out of place (even if it is harmless). 
and let it be considered malformed and handled by RFC7606. 

Thoughts? 

Dave.