Re: [Idr] Review of draft-ietf-large-community-06.txt

"Jakob Heitz (jheitz)" <jheitz@cisco.com> Fri, 04 November 2016 03:54 UTC

Return-Path: <jheitz@cisco.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E92601296ED; Thu, 3 Nov 2016 20:54:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -16.018
X-Spam-Level:
X-Spam-Status: No, score=-16.018 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.497, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VMSB9oG7A6gU; Thu, 3 Nov 2016 20:54:02 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D7ABE1294DF; Thu, 3 Nov 2016 20:54:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1946; q=dns/txt; s=iport; t=1478231641; x=1479441241; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=A04UT/XEPWo7o3PZNRAVCeQ9DYRmeHU+T+jmBeYkGuU=; b=RH7nHxq8jlFrU4F1Aiv0TxwZolycnJfOMnkZDzPX5rAMTOS/asdsoO0y OjUbDJ4Ms2TlVerjTgQKaC8avuRwrZyCIrDkFW79oumGMTWS7niQevUVY DiXJHP+IMzwZni9wZyKKJnpsdZm4byMqA8GshrEBGARvVwpE2QrN3nfL7 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0B3AQC8BRxY/4sNJK1dGgEBAQECAQEBA?= =?us-ascii?q?QgBAQEBgy4BAQEBAR+BW40xq0eCCIYjAhqBcD8UAQIBAQEBAQEBYiiEYgEBBCM?= =?us-ascii?q?RRRACAQgODAImAgICMBUQAgQBDQ0MiESuX40NAQEBAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBHIEJhTaEVYdLglwFlEKFXwGQNZARkSIBHjdrhR+HWoEMAQEB?=
X-IronPort-AV: E=Sophos;i="5.31,442,1473120000"; d="scan'208";a="167279388"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Nov 2016 03:54:01 +0000
Received: from XCH-ALN-014.cisco.com (xch-aln-014.cisco.com [173.36.7.24]) by alln-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id uA43s0W8011208 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 4 Nov 2016 03:54:01 GMT
Received: from xch-aln-014.cisco.com (173.36.7.24) by XCH-ALN-014.cisco.com (173.36.7.24) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 3 Nov 2016 22:54:00 -0500
Received: from xch-aln-014.cisco.com ([173.36.7.24]) by XCH-ALN-014.cisco.com ([173.36.7.24]) with mapi id 15.00.1210.000; Thu, 3 Nov 2016 22:54:00 -0500
From: "Jakob Heitz (jheitz)" <jheitz@cisco.com>
To: Geoff Huston <gih@apnic.net>, IETF IDR WG <idr@ietf.org>
Thread-Topic: [Idr] Review of draft-ietf-large-community-06.txt
Thread-Index: AQHSNjBz6sRcMeSZxEiIR579im5tsaDIKelQ
Date: Fri, 4 Nov 2016 03:54:00 +0000
Message-ID: <4080cfba032744f590fcbbb710f0d618@XCH-ALN-014.cisco.com>
References: <112dc01d235fd$57f9c370$07ed4a50$@ndzh.com> <C2DABF02-D3CB-4646-B869-FBCE5F05FDA1@apnic.net> <117ea01d23611$a28513e0$e78f3ba0$@ndzh.com> <CED07D95-A426-469C-85B4-DB2FBE52D14A@apnic.net>
In-Reply-To: <CED07D95-A426-469C-85B4-DB2FBE52D14A@apnic.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.32.83]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/8cq7ysyMMrDjyJxAw8YxpAD1tG8>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, Susan Hares <shares@ndzh.com>
Subject: Re: [Idr] Review of draft-ietf-large-community-06.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Nov 2016 03:54:03 -0000

Thanks Geoff, I'll fix them.

One thing about the aggregation.
I first had the condition "do not include the ATOMIC_AGGREGATE".
Then someone commented on the list that ATOMIC_AGGREGATE was dead.
I reviewed the function of ATOMIC_AGGREGATE and what our code does.
ATOMIC_AGGREGATE means that information was lost by aggregation.
In our code (and other code that I have worked on), when we
aggregate, we always add the ATOMIC_AGGREGATE attribute.
There is no case when we aggregate without adding the ATOMIC_AGGREGATE
attribute. Being of no consequence, I removed that part of the text.
I mean, the text tells you how to aggregate if the ATOMIC_AGGREGATE
is absent, but says nothing about how to aggregate if it's present.

Personally, I'm fine either way. It will not change any code I write.


Jakob.


> "3. Aggregation
> 
> If a set of routes is to be aggregated and the resulting aggregate route's
> path attributes do not include the ATOMIC_AGGREGATE attribute, then the
> resulting aggregate route SHOULD have a Large Communities Attribute formed
> from the set union of all the Large Community values from all of the
> aggregated set of routes.  This behavior MAY be overridden via local
> configuration, in which case handling the Large Communities attribute in
> the presence of route aggregation is determined by the local policy of the
> BGP speaker that performs the aggregation."